From 00a4db12130fb26f0a43604051cd08b3944b8a55 Mon Sep 17 00:00:00 2001 From: Paul Kaplan Date: Mon, 18 Mar 2019 15:09:31 -0400 Subject: [PATCH] Remove complexity around promise/non-promise. Since this is in a promise chain, it doesn't matter if onUpdateProjectData returns a promise or a primitive, it'll work either way --- src/lib/project-saver-hoc.jsx | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/lib/project-saver-hoc.jsx b/src/lib/project-saver-hoc.jsx index 846cfbe8b..911769762 100644 --- a/src/lib/project-saver-hoc.jsx +++ b/src/lib/project-saver-hoc.jsx @@ -232,16 +232,8 @@ const ProjectSaverHOC = function (WrappedComponent) { () => (asset.clean = true) ) ) - ).then(() => { - const {onUpdateProjectData} = this.props; - const saveReturnValue = onUpdateProjectData(projectId, - savedVMState, requestParams); - // Allow onUpdateProjectData to either return immediately or a promise. - if (!(saveReturnValue.then && saveReturnValue.catch)) { - return Promise.resolve(saveReturnValue); - } - return saveReturnValue; - }) + ) + .then(() => this.props.onUpdateProjectData(projectId, savedVMState, requestParams)) .then(response => { this.props.onSetProjectUnchanged(); const id = response.id.toString();