From 27de6521ebdaa51daad1a5a37d07411c0b22c6b8 Mon Sep 17 00:00:00 2001 From: Linda Date: Tue, 4 Sep 2018 11:52:30 -0400 Subject: [PATCH 1/4] set lang attribute when language is updated --- src/containers/language-selector.jsx | 1 + 1 file changed, 1 insertion(+) diff --git a/src/containers/language-selector.jsx b/src/containers/language-selector.jsx index c3f108efb..fe94b8500 100644 --- a/src/containers/language-selector.jsx +++ b/src/containers/language-selector.jsx @@ -27,6 +27,7 @@ class LanguageSelector extends React.Component { children, ...props } = this.props; + document.documentElement.lang = this.props.currentLocale; //update the lang attribute of the html for screenreaders return ( Date: Thu, 13 Sep 2018 13:44:53 -0400 Subject: [PATCH 2/4] set lang in constructor and updateHandler not in render --- src/containers/language-selector.jsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/containers/language-selector.jsx b/src/containers/language-selector.jsx index fe94b8500..c8f8acd35 100644 --- a/src/containers/language-selector.jsx +++ b/src/containers/language-selector.jsx @@ -13,11 +13,13 @@ class LanguageSelector extends React.Component { bindAll(this, [ 'handleChange' ]); + document.documentElement.lang = this.props.currentLocale; } handleChange (e) { const newLocale = e.target.value; if (this.props.supportedLocales.includes(newLocale)) { this.props.onChangeLanguage(newLocale); + document.documentElement.lang = newLocale; } } render () { @@ -27,7 +29,6 @@ class LanguageSelector extends React.Component { children, ...props } = this.props; - document.documentElement.lang = this.props.currentLocale; //update the lang attribute of the html for screenreaders return ( Date: Fri, 14 Sep 2018 13:07:24 -0400 Subject: [PATCH 3/4] no use of this in this case --- src/containers/language-selector.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/containers/language-selector.jsx b/src/containers/language-selector.jsx index c8f8acd35..8eb621bb1 100644 --- a/src/containers/language-selector.jsx +++ b/src/containers/language-selector.jsx @@ -13,7 +13,7 @@ class LanguageSelector extends React.Component { bindAll(this, [ 'handleChange' ]); - document.documentElement.lang = this.props.currentLocale; + document.documentElement.lang = props.currentLocale; } handleChange (e) { const newLocale = e.target.value; From d07f472607d4e6b3ab0657310cde3ddd0fcb177e Mon Sep 17 00:00:00 2001 From: DD Liu Date: Wed, 26 Sep 2018 11:30:26 -0400 Subject: [PATCH 4/4] Update scratch svg renderer (#3228) --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 00718bd23..2c57472f7 100644 --- a/package.json +++ b/package.json @@ -101,7 +101,7 @@ "scratch-paint": "0.2.0-prerelease.20180918203812", "scratch-render": "0.1.0-prerelease.20180918201144", "scratch-storage": "1.0.2", - "scratch-svg-renderer": "0.2.0-prerelease.20180907141232", + "scratch-svg-renderer": "0.2.0-prerelease.20180926143036", "scratch-vm": "0.2.0-prerelease.20180918201814", "selenium-webdriver": "3.6.0", "startaudiocontext": "1.2.1",