From b10422076038565782af4b681276b258b4278980 Mon Sep 17 00:00:00 2001 From: apple502j Date: Sat, 6 Oct 2018 10:51:19 +0900 Subject: [PATCH 1/3] Translate record modal --- .../record-modal/recording-step.jsx | 37 +++++++++++++++++-- 1 file changed, 33 insertions(+), 4 deletions(-) diff --git a/src/components/record-modal/recording-step.jsx b/src/components/record-modal/recording-step.jsx index e889a77e7..b4d4f3e9a 100644 --- a/src/components/record-modal/recording-step.jsx +++ b/src/components/record-modal/recording-step.jsx @@ -1,5 +1,6 @@ import PropTypes from 'prop-types'; import React from 'react'; +import {defineMessages, injectIntl, intlShape} from 'react-intl'; import Box from '../box/box.jsx'; import Meter from '../meter/meter.jsx'; import Waveform from '../waveform/waveform.jsx'; @@ -7,6 +8,29 @@ import Waveform from '../waveform/waveform.jsx'; import styles from './record-modal.css'; import stopIcon from './icon--stop-recording.svg'; +const messages = defineMessages({ + beginRecord: { + defaultMessage: 'Begin recording by clicking the button below', + description: 'Message for recording sound modal', + id: 'gui.recordingStep.beginRecord' + }, + permission: { + defaultMessage: '{arrow}We need your permission to use your microphone', + description: 'Permission required notice in recording sound modal. Do not translate {arrow}', + id: 'gui.recordingStep.permission' + }, + stop: { + defaultMessage: 'Stop recording', + description: 'Stop recording button label', + id: 'gui.recordingStep.stop' + }, + record: { + defaultMessage: 'Record', + description: 'Record button label', + id: 'gui.recordingStep.record' + } +}); + const RecordingStep = props => ( @@ -27,8 +51,8 @@ const RecordingStep = props => ( /> ) : ( - {props.listening ? 'Begin recording by clicking the button below' : - '↖️ \u00A0We need your permission to use your microphone'} + {props.listening ? props.intl.formatMessage(messages.beginRecord) : + props.intl.formatMessage(messages.permission, {arrow: '↖️ \u00A0'})} )} @@ -66,7 +90,11 @@ const RecordingStep = props => ( )}
- {props.recording ? 'Stop recording' : 'Record'} + { + props.recording ? + props.intl.formatMessage(messages.stop) : + props.intl.formatMessage(messages.record) + }
@@ -75,6 +103,7 @@ const RecordingStep = props => ( ); RecordingStep.propTypes = { + intl: intlShape.isRequired, level: PropTypes.number, levels: PropTypes.arrayOf(PropTypes.number), listening: PropTypes.bool, @@ -83,4 +112,4 @@ RecordingStep.propTypes = { recording: PropTypes.bool }; -export default RecordingStep; +export default injectIntl(RecordingStep); From 297d032be4c24c1446e1cdf2c65068e55554f3e3 Mon Sep 17 00:00:00 2001 From: apple502j <33279053+apple502j@users.noreply.github.com> Date: Thu, 11 Oct 2018 21:13:04 +0900 Subject: [PATCH 2/3] RTL --- src/components/record-modal/recording-step.jsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/components/record-modal/recording-step.jsx b/src/components/record-modal/recording-step.jsx index b4d4f3e9a..c38df20a5 100644 --- a/src/components/record-modal/recording-step.jsx +++ b/src/components/record-modal/recording-step.jsx @@ -52,7 +52,10 @@ const RecordingStep = props => ( ) : ( {props.listening ? props.intl.formatMessage(messages.beginRecord) : - props.intl.formatMessage(messages.permission, {arrow: '↖️ \u00A0'})} + props.intl.formatMessage(messages.permission, + {arrow: props.isRtl ? '↗️ \u00A0' : '↖️ \u00A0'} + ) + } )}
@@ -104,6 +107,7 @@ const RecordingStep = props => ( RecordingStep.propTypes = { intl: intlShape.isRequired, + isRtl: PropTypes.bool, level: PropTypes.number, levels: PropTypes.arrayOf(PropTypes.number), listening: PropTypes.bool, From 3c0d0752204169f627770835e20ec9bfed2f401b Mon Sep 17 00:00:00 2001 From: apple502j <33279053+apple502j@users.noreply.github.com> Date: Thu, 11 Oct 2018 21:20:06 +0900 Subject: [PATCH 3/3] Lint --- src/components/record-modal/recording-step.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/record-modal/recording-step.jsx b/src/components/record-modal/recording-step.jsx index c38df20a5..4940533a5 100644 --- a/src/components/record-modal/recording-step.jsx +++ b/src/components/record-modal/recording-step.jsx @@ -53,8 +53,8 @@ const RecordingStep = props => ( {props.listening ? props.intl.formatMessage(messages.beginRecord) : props.intl.formatMessage(messages.permission, - {arrow: props.isRtl ? '↗️ \u00A0' : '↖️ \u00A0'} - ) + {arrow: props.isRtl ? '↗️ \u00A0' : '↖️ \u00A0'} + ) } )}