diff --git a/src/components/cards/card.css b/src/components/cards/card.css index 3887a13c6..78801becb 100644 --- a/src/components/cards/card.css +++ b/src/components/cards/card.css @@ -114,7 +114,7 @@ flex-direction: row; } -.toggle-button { +.shrink-expand-button { cursor: pointer; color: white; display: flex; @@ -124,7 +124,7 @@ padding: 0.75rem; } -.toggle-button:hover, .all-button:hover { +.shrink-expand-button:hover, .all-button:hover { background-color: $ui-black-transparent; } diff --git a/src/components/cards/cards.jsx b/src/components/cards/cards.jsx index 566eb840a..c0d0c764c 100644 --- a/src/components/cards/cards.jsx +++ b/src/components/cards/cards.jsx @@ -18,8 +18,8 @@ import closeIcon from './icon--close.svg'; import {translateVideo} from '../../lib/libraries/decks/translate-video.js'; import {translateImage} from '../../lib/libraries/decks/translate-image.js'; -const CardHeader = ({onCloseCards, onToggleCards, onShowAll, totalSteps, step, toggle}) => ( -
+const CardHeader = ({onCloseCards, onShrinkExpandCards, onShowAll, totalSteps, step, expanded}) => ( +
- {toggle ? 'Shrink' : 'Expand'} + {expanded ? 'Shrink' : 'Expand'}
( +const NextPrevButtons = ({isRtl, onNextStep, onPrevStep, expanded}) => ( {onNextStep ? (
-
+
( ) : null} {onPrevStep ? (
-
+
( ); NextPrevButtons.propTypes = { + expanded: PropTypes.bool.isRequired, isRtl: PropTypes.bool, onNextStep: PropTypes.func, - onPrevStep: PropTypes.func, - toggle: PropTypes.bool.isRequired + onPrevStep: PropTypes.func }; CardHeader.propTypes = { + expanded: PropTypes.bool.isRequired, onCloseCards: PropTypes.func.isRequired, onShowAll: PropTypes.func.isRequired, - onToggleCards: PropTypes.func.isRequired, + onShrinkExpandCards: PropTypes.func.isRequired, step: PropTypes.number, - toggle: PropTypes.bool.isRequired, totalSteps: PropTypes.number }; @@ -238,7 +238,7 @@ const Cards = props => { locale, onActivateDeckFactory, onCloseCards, - onToggleCards, + onShrinkExpandCards, onDrag, onStartDrag, onEndDrag, @@ -246,7 +246,7 @@ const Cards = props => { onNextStep, onPrevStep, step, - toggle, + expanded, ...posProps } = props; let {x, y} = posProps; @@ -276,14 +276,14 @@ const Cards = props => {
-
+
{steps[step].deckIds ? ( { {steps[step].trackingPixel && steps[step].trackingPixel}
0 ? onPrevStep : null} /> @@ -333,6 +333,7 @@ Cards.propTypes = { }) }), dragging: PropTypes.bool.isRequired, + expanded: PropTypes.bool.isRequired, isRtl: PropTypes.bool.isRequired, locale: PropTypes.string.isRequired, onActivateDeckFactory: PropTypes.func.isRequired, @@ -342,10 +343,9 @@ Cards.propTypes = { onNextStep: PropTypes.func.isRequired, onPrevStep: PropTypes.func.isRequired, onShowAll: PropTypes.func, + onShrinkExpandCards: PropTypes.func.isRequired, onStartDrag: PropTypes.func, - onToggleCards: PropTypes.func.isRequired, step: PropTypes.number.isRequired, - toggle: PropTypes.bool.isRequired, x: PropTypes.number, y: PropTypes.number }; diff --git a/src/containers/cards.jsx b/src/containers/cards.jsx index 7492b367a..751d523f7 100644 --- a/src/containers/cards.jsx +++ b/src/containers/cards.jsx @@ -5,7 +5,7 @@ import React from 'react'; import { activateDeck, closeCards, - toggleCards, + shrinkExpandCards, nextStep, prevStep, dragCard, @@ -47,7 +47,7 @@ const mapStateToProps = state => ({ content: state.scratchGui.cards.content, activeDeckId: state.scratchGui.cards.activeDeckId, step: state.scratchGui.cards.step, - toggle: state.scratchGui.cards.toggle, + expanded: state.scratchGui.cards.expanded, x: state.scratchGui.cards.x, y: state.scratchGui.cards.y, isRtl: state.locales.isRtl, @@ -62,7 +62,7 @@ const mapDispatchToProps = dispatch => ({ dispatch(closeCards()); }, onCloseCards: () => dispatch(closeCards()), - onToggleCards: () => dispatch(toggleCards()), + onShrinkExpandCards: () => dispatch(shrinkExpandCards()), onNextStep: () => dispatch(nextStep()), onPrevStep: () => dispatch(prevStep()), onDrag: (e_, data) => dispatch(dragCard(data.x, data.y)), diff --git a/src/reducers/cards.js b/src/reducers/cards.js index ac0a0dced..c54161f4c 100644 --- a/src/reducers/cards.js +++ b/src/reducers/cards.js @@ -3,7 +3,7 @@ import analytics from '../lib/analytics'; import decks from '../lib/libraries/decks/index.jsx'; const CLOSE_CARDS = 'scratch-gui/cards/CLOSE_CARDS'; -const TOGGLE_CARDS = 'scratch-gui/cards/TOGGLE_CARDS'; +const SHRINK_EXPAND_CARDS = 'scratch-gui/cards/SHRINK_EXPAND_CARDS'; const VIEW_CARDS = 'scratch-gui/cards/VIEW_CARDS'; const ACTIVATE_DECK = 'scratch-gui/cards/ACTIVATE_DECK'; const NEXT_STEP = 'scratch-gui/cards/NEXT_STEP'; @@ -19,7 +19,7 @@ const initialState = { step: 0, x: 0, y: 0, - toggle: true, + expanded: true, dragging: false }; @@ -30,9 +30,9 @@ const reducer = function (state, action) { return Object.assign({}, state, { visible: false }); - case TOGGLE_CARDS: + case SHRINK_EXPAND_CARDS: return Object.assign({}, state, { - toggle: !state.toggle // TODO: make clearer + expanded: !state.expanded }); case VIEW_CARDS: return Object.assign({}, state, { @@ -98,8 +98,8 @@ const closeCards = function () { return {type: CLOSE_CARDS}; }; -const toggleCards = function () { - return {type: TOGGLE_CARDS}; +const shrinkExpandCards = function () { + return {type: SHRINK_EXPAND_CARDS}; }; const nextStep = function () { @@ -128,7 +128,7 @@ export { activateDeck, viewCards, closeCards, - toggleCards, + shrinkExpandCards, nextStep, prevStep, dragCard, diff --git a/src/reducers/gui.js b/src/reducers/gui.js index fa8b04317..9024b4742 100644 --- a/src/reducers/gui.js +++ b/src/reducers/gui.js @@ -107,7 +107,7 @@ const initTutorialCard = function (currentState, deckId) { visible: true, content: decks, activeDeckId: deckId, - toggle: true, + expanded: true, step: 0, x: 0, y: 0,