From 5051ba2105b58b5f4789b35ca62c5bfebd54b24b Mon Sep 17 00:00:00 2001 From: Christopher Willis-Ford Date: Thu, 14 Mar 2019 10:35:39 -0700 Subject: [PATCH] Code review: remove dead code, clarify arg name --- src/components/menu-bar/menu-bar.jsx | 15 ++++----------- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/src/components/menu-bar/menu-bar.jsx b/src/components/menu-bar/menu-bar.jsx index 966aa5271..972809d2d 100644 --- a/src/components/menu-bar/menu-bar.jsx +++ b/src/components/menu-bar/menu-bar.jsx @@ -150,7 +150,6 @@ class MenuBar extends React.Component { 'handleClickSaveAsCopy', 'handleClickSeeCommunity', 'handleClickShare', - 'handleCloseFileMenuAndThen', 'handleKeyPress', 'handleLanguageMouseUp', 'handleRestoreOption', @@ -221,12 +220,6 @@ class MenuBar extends React.Component { this.props.onRequestCloseEdit(); }; } - handleCloseFileMenuAndThen (fn) { - return () => { - this.props.onRequestCloseFile(); - fn(); - }; - } handleKeyPress (event) { const modifier = bowser.mac ? event.metaKey : event.ctrlKey; if (modifier && event.key === 's') { @@ -234,10 +227,10 @@ class MenuBar extends React.Component { event.preventDefault(); } } - handleSaveToComputer (downloadProject) { + handleSaveToComputer (downloadProjectCallback) { return () => { this.props.onRequestCloseFile(); - downloadProject(); + downloadProjectCallback(); if (this.props.onProjectTelemetryEvent) { const metadata = collectMetadata(this.props.vm, this.props.projectTitle, this.props.locale); this.props.onProjectTelemetryEvent('projectDidSave', metadata); @@ -417,10 +410,10 @@ class MenuBar extends React.Component { )} - {(className, downloadProject) => ( + {(className, downloadProjectCallback) => (