diff --git a/src/addons/settings/settings.css b/src/addons/settings/settings.css
index 146b8c65f..c5719d996 100644
--- a/src/addons/settings/settings.css
+++ b/src/addons/settings/settings.css
@@ -210,7 +210,7 @@ a[href] {
background-color: transparent;
}
.reset-button:hover {
- background: rgba(255, 255, 255, 0.05);
+ background: rgba(0, 0, 0, 0.05);
}
.reset-button:focus-within {
outline: none;
@@ -224,6 +224,9 @@ a[href] {
.reset-button-image {
filter: invert(100%);
}
+ .reset-button:hover {
+ background: rgba(255, 255, 255, 0.05);
+ }
}
.switch {
@@ -266,6 +269,10 @@ a[href] {
}
}
+.tag-container {
+ display: flex;
+ align-items: center;
+}
.tag {
border-radius: 4px;
padding: 2px 5px;
@@ -328,7 +335,7 @@ a[href] {
.setting {
margin: 10px;
- margin-right: 10px;
+ margin-right: 20px;
min-height: 35px;
display: flex;
align-items: center;
@@ -379,12 +386,17 @@ a[href] {
.setting input[type="color"] {
height: 30px;
width: 100px;
+ box-sizing: border-box;
padding: 0;
- overflow: hidden;
+ margin: 0;
+ outline: none;
+ border: 1px solid transparent;
border-radius: 4px 0px 0px 4px;
}
.reset-color-button {
border-radius: 0 4px 4px 0px;
+ box-sizing: border-box;
+ height: 30px;
}
.select {
display: flex;
@@ -433,7 +445,10 @@ a[href] {
}
.presets {
-
+ width: 100%;
+}
+.preset-button {
+ margin-right: 10px;
}
.footer-buttons {
diff --git a/src/addons/settings/settings.jsx b/src/addons/settings/settings.jsx
index c11418fa9..89d94c741 100644
--- a/src/addons/settings/settings.jsx
+++ b/src/addons/settings/settings.jsx
@@ -33,6 +33,7 @@ import undoImage from './undo.svg';
import styles from './settings.css';
/* eslint-disable no-alert */
+/* eslint-disable no-console */
const locale = detectLocale(upstreamMeta.languages);
const addonTranslations = getAddonTranslations(locale);
@@ -85,37 +86,33 @@ SwitchComponent.propTypes = {
};
const SelectComponent = ({
- addonId,
+ onChange,
value,
- setting
+ values
}) => (
- {setting.potentialValues.map(potentialValue => {
+ {values.map(potentialValue => {
const id = potentialValue.id;
const selected = id === value;
- const valueName = addonTranslations[`${addonId}/@settings-select-${setting.id}-${id}`] || potentialValue.name;
return (
);
})}
);
SelectComponent.propTypes = {
- addonId: PropTypes.string,
+ onChange: PropTypes.func,
value: PropTypes.string,
- setting: PropTypes.shape({
+ values: PropTypes.arrayOf(PropTypes.shape({
id: PropTypes.string,
- potentialValues: PropTypes.arrayOf(PropTypes.shape({
- id: PropTypes.string,
- name: PropTypes.string
- }))
- })
+ name: PropTypes.string
+ }))
};
const TagComponent = ({tags}) => tags.length > 0 && (
@@ -153,7 +150,7 @@ const SettingComponent = ({
}) => {
const settingId = setting.id;
const settingName = addonTranslations[`${addonId}/@settings-name-${settingId}`] || setting.name;
- const uniqueId = `setting/${addonId}/${settingId}`
+ const uniqueId = `setting/${addonId}/${settingId}`;
const label = (