From 10459eba7c35cede18f88b8af085c5e988b4380d Mon Sep 17 00:00:00 2001 From: Paul Kaplan Date: Fri, 14 Dec 2018 16:04:23 -0500 Subject: [PATCH 1/2] Revert "admins will see author credits, not title editing field, in editor" --- src/components/menu-bar/menu-bar.jsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/menu-bar/menu-bar.jsx b/src/components/menu-bar/menu-bar.jsx index 21ebc084c..5cf6cb6bb 100644 --- a/src/components/menu-bar/menu-bar.jsx +++ b/src/components/menu-bar/menu-bar.jsx @@ -461,7 +461,7 @@ class MenuBar extends React.Component { - {this.props.canSave && this.props.canEditTitle ? ( + {this.props.canEditTitle ? (
Date: Fri, 14 Dec 2018 16:19:15 -0500 Subject: [PATCH 2/2] Add a regression test to make sure bug does not come back --- test/integration/menu-bar.test.js | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/test/integration/menu-bar.test.js b/test/integration/menu-bar.test.js index ced505a91..6529b7bc4 100644 --- a/test/integration/menu-bar.test.js +++ b/test/integration/menu-bar.test.js @@ -2,6 +2,7 @@ import path from 'path'; import SeleniumHelper from '../helpers/selenium-helper'; const { + clickText, clickXpath, findByXpath, getDriver, @@ -64,4 +65,13 @@ describe('Menu bar settings', () => { const currentUrl = await driver.getCurrentUrl(); await expect(currentUrl).toEqual('https://scratch.mit.edu/'); }); + + test('(GH#4064) Project name should be editable', async () => { + await loadUri(uri); + await clickXpath('//button[@title="Try It"]'); + const el = await findByXpath('//input[@value="Scratch Project"]'); + await el.sendKeys(' - Personalized'); + await clickText('Costumes'); // just to blur the input + await clickXpath('//input[@value="Scratch Project - Personalized"]'); + }); });