From dadef73bfa050b4b00f3f2c4ff8c0c54e6b8ae65 Mon Sep 17 00:00:00 2001 From: unknown Date: Tue, 5 Mar 2019 14:12:41 -0500 Subject: [PATCH 1/3] Testing two icons side by side to see how the padding is currently working. --- src/components/library-item/library-item.jsx | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/components/library-item/library-item.jsx b/src/components/library-item/library-item.jsx index 3880a4cf6..0fa462311 100644 --- a/src/components/library-item/library-item.jsx +++ b/src/components/library-item/library-item.jsx @@ -78,6 +78,12 @@ class LibraryItemComponent extends React.PureComponent { internetConnectionIconURL } /> + ) : null} From 31625d68070ece780678a1b87663b7116d7147a0 Mon Sep 17 00:00:00 2001 From: Evelyn Eastmond Date: Tue, 12 Mar 2019 10:10:59 -0400 Subject: [PATCH 2/3] Adding ability to show both bluetooth and internet icons in extension library item tiles. --- src/components/library-item/library-item.jsx | 18 ++++++------------ src/lib/libraries/extensions/index.jsx | 6 +++++- 2 files changed, 11 insertions(+), 13 deletions(-) diff --git a/src/components/library-item/library-item.jsx b/src/components/library-item/library-item.jsx index 0fa462311..5af6fb159 100644 --- a/src/components/library-item/library-item.jsx +++ b/src/components/library-item/library-item.jsx @@ -72,18 +72,12 @@ class LibraryItemComponent extends React.PureComponent {
- - + {this.props.bluetoothRequired ? ( + + ) : null} + {this.props.internetConnectionRequired ? ( + + ) : null}
) : null} diff --git a/src/lib/libraries/extensions/index.jsx b/src/lib/libraries/extensions/index.jsx index 9bc3bc3d2..3d1dd6658 100644 --- a/src/lib/libraries/extensions/index.jsx +++ b/src/lib/libraries/extensions/index.jsx @@ -163,6 +163,7 @@ export default [ featured: true, disabled: false, bluetoothRequired: true, + internetConnectionRequired: true, launchPeripheralConnectionFlow: true, useAutoScan: false, peripheralImage: microbitPeripheralImage, @@ -192,6 +193,7 @@ export default [ featured: true, disabled: false, bluetoothRequired: true, + internetConnectionRequired: true, launchPeripheralConnectionFlow: true, useAutoScan: false, peripheralImage: ev3PeripheralImage, @@ -221,6 +223,7 @@ export default [ featured: true, disabled: false, bluetoothRequired: true, + internetConnectionRequired: true, launchPeripheralConnectionFlow: true, useAutoScan: true, peripheralImage: wedoPeripheralImage, @@ -250,6 +253,7 @@ export default [ ), featured: true, disabled: true, - bluetoothRequired: true + bluetoothRequired: true, + internetConnectionRequired: true } ]; From f29b82b63608999a088908944460c630bcc2f7ad Mon Sep 17 00:00:00 2001 From: Evelyn Eastmond Date: Tue, 12 Mar 2019 10:39:27 -0400 Subject: [PATCH 3/3] Adding right padding to icons. --- src/components/library-item/library-item.css | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/components/library-item/library-item.css b/src/components/library-item/library-item.css index 692e1b612..5e726a363 100644 --- a/src/components/library-item/library-item.css +++ b/src/components/library-item/library-item.css @@ -178,6 +178,10 @@ font-weight: bold; } +.featured-extension-metadata-detail img{ + margin-right: 0.25rem; +} + .coming-soon-text { position: absolute; background-color: $data-primary;