From bad3e8a49e25978366f3a78ec3c55401283a9ce8 Mon Sep 17 00:00:00 2001 From: Eric Rosenbaum Date: Fri, 27 Apr 2018 10:00:22 -0400 Subject: [PATCH] Prevent category menu jump on sprite switch --- src/containers/blocks.jsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/containers/blocks.jsx b/src/containers/blocks.jsx index 278a649bd..12eef6e91 100644 --- a/src/containers/blocks.jsx +++ b/src/containers/blocks.jsx @@ -99,7 +99,12 @@ class Blocks extends React.Component { const offset = this.workspace.toolbox_.getCategoryScrollOffset(); this.workspace.updateToolbox(this.props.toolboxXML); const currentCategoryPos = this.workspace.toolbox_.getCategoryPositionByName(categoryName); - this.workspace.toolbox_.setFlyoutScrollPos(currentCategoryPos + offset); + const currentCategoryLen = this.workspace.toolbox_.getCategoryLengthByName(categoryName); + if (offset < currentCategoryLen) { + this.workspace.toolbox_.setFlyoutScrollPos(currentCategoryPos + offset); + } else { + this.workspace.toolbox_.setFlyoutScrollPos(currentCategoryPos); + } } if (this.props.isVisible === prevProps.isVisible) { return;