From 52a3600819b58040f9091b4e4309b3d1d345c038 Mon Sep 17 00:00:00 2001 From: Eric Rosenbaum Date: Thu, 9 May 2019 15:06:26 -0400 Subject: [PATCH 1/2] Surprise sprites do not include letters and numbers --- src/containers/target-pane.jsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/containers/target-pane.jsx b/src/containers/target-pane.jsx index a11506d2f..db316385b 100644 --- a/src/containers/target-pane.jsx +++ b/src/containers/target-pane.jsx @@ -105,7 +105,10 @@ class TargetPane extends React.Component { } } handleSurpriseSpriteClick () { - const item = spriteLibraryContent[Math.floor(Math.random() * spriteLibraryContent.length)]; + const supriseSprites = spriteLibraryContent.filter(sprite => + (sprite.tags.indexOf('letters') === -1) && (sprite.tags.indexOf('numbers') === -1) + ); + const item = supriseSprites[Math.floor(Math.random() * supriseSprites.length)]; randomizeSpritePosition(item); this.props.vm.addSprite(JSON.stringify(item.json)) .then(this.handleActivateBlocksTab); From a11fcfe3738f5a53474d690072e5b559ff47f182 Mon Sep 17 00:00:00 2001 From: Eric Rosenbaum Date: Thu, 9 May 2019 15:12:13 -0400 Subject: [PATCH 2/2] Fix typo in variable name --- src/containers/target-pane.jsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/containers/target-pane.jsx b/src/containers/target-pane.jsx index db316385b..11fd2b9f5 100644 --- a/src/containers/target-pane.jsx +++ b/src/containers/target-pane.jsx @@ -105,10 +105,10 @@ class TargetPane extends React.Component { } } handleSurpriseSpriteClick () { - const supriseSprites = spriteLibraryContent.filter(sprite => + const surpriseSprites = spriteLibraryContent.filter(sprite => (sprite.tags.indexOf('letters') === -1) && (sprite.tags.indexOf('numbers') === -1) ); - const item = supriseSprites[Math.floor(Math.random() * supriseSprites.length)]; + const item = surpriseSprites[Math.floor(Math.random() * surpriseSprites.length)]; randomizeSpritePosition(item); this.props.vm.addSprite(JSON.stringify(item.json)) .then(this.handleActivateBlocksTab);