Commit Graph
1090 Commits
Author SHA1 Message Date
Ray Schamp 25dbc25272 De-cruft 2018-04-12 16:35:18 -04:00
Ray Schamp 5f3cc97633 Add edit menu 2018-04-12 16:33:52 -04:00
Ray Schamp 7b80e44370 Fix menu border radius 2018-04-12 16:28:03 -04:00
Ray Schamp 241598c5aa Fix hover states 2018-04-12 16:27:28 -04:00
Ray Schamp 5f8f0481fe Dropdown drop shadow, dropped a bit from the comp
It's shifted downward to not overlap the menubar, since it's hard to make a child z-indexed below its parent.
2018-04-12 15:47:47 -04:00
Ray Schamp f116363403 Add dividers
It's a cleaner API IMO but ended up being a messy implementation...
2018-04-12 15:13:43 -04:00
Ray Schamp 56b431da04 Highlight on hover/active 2018-04-12 14:21:30 -04:00
Ray Schamp d47a065090 Finish .menu-bar -> .menu-bar-item rename 2018-04-12 14:21:17 -04:00
Ray Schamp cde8a78e86 Hook up save and load buttons
These use a technique where the save/load functionality is passed from the component to its children via a function argument.  I opted for this rather than a higher order component because it is more readable and requires fewer intermediary components.

This could just as easily been done with a higher order component and would be happy to change it to that instead.

There is a performance implication since there is a function being defined in render. However the menu bar is not a highly re-rendered component, so I thought it would be ok in this case.
2018-04-12 13:34:18 -04:00
Ray Schamp bab8ddabc4 Clean up menu positioning 2018-04-12 10:51:25 -04:00
Ray Schamp e33d73269a Fix cat avatar
Sorry @carljbowman
2018-04-12 10:42:51 -04:00
Ray Schamp b30d3ed230 Consolidate coming soon tooltips into a component
Mostly to remove the repeated props
2018-04-12 10:19:16 -04:00
Ray Schamp defd8b0b44 Rename menu item class name
We have actual menu items now so the things that were menu items should be considered menu bar items
2018-04-12 09:57:41 -04:00
Ray Schamp bad41dab97 First pass on menus
They open and close what more do you want?
2018-04-12 09:51:21 -04:00
Ray Schamp a3b8a917aa Remove the redundant error line
The error message is included in the first line of the stack
2018-04-12 09:39:15 -04:00
Ray Schamp cd4a055bb7 Add more information to error boundary messages
While working on the menubar, I couldn't find the source of an error. This adds more stack info to the error messages emitted by the error boundary.
2018-04-11 21:04:14 -04:00
kchadha b5335eeb0a Merge branch 'develop' into default-project-precompression 2018-04-11 19:43:19 -04:00
Paul Kaplan ce3fadd27e Merge branch 'develop' into sprite-tile-update 2018-04-11 13:42:53 -04:00
Helio 50609c4568 Fixing issue #1753 - Style fixing 2018-04-10 15:30:32 -03:00
Helio 4bfd99659b Fixing issue #1753 2018-04-10 15:25:46 -03:00
Paul Kaplan af9a178f80 Fix linting 2018-04-10 10:03:55 -04:00
Paul Kaplan 2a1ae917a8 Add shadow filter for selected tiles, making all-white costumes visible. 2018-04-10 09:45:13 -04:00
Paul Kaplan f6a89dbd69 Fix spacing and sizing for tile details 2018-04-10 09:44:46 -04:00
Paul Kaplan 66347c83a4 Add details to sprite tile and update styling 2018-04-10 09:10:23 -04:00
Karishma Chadha 380dc59027 Remove camera upload options from sprite and backdrop selectors. 2018-04-09 15:41:54 -04:00
kchadha 7e4004bab8 Merge pull request #1750 from kchadha/load-button-fix
Fixes for load button issues.
2018-04-09 15:30:20 -04:00
Karishma Chadha bb9f63ce67 Fixes for load button issues. 2018-04-09 15:02:53 -04:00
Paul Kaplan 63623c9f7b Merge pull request #1745 from carljbowman/develop
Phase 1 - Audit/Update GUI Colors
2018-04-09 14:54:11 -04:00
carljbowman 013c9a1872 Modified some UI details with new color system
Updates include modifications to interaction states for the following: tabs, add menus, forms, and stage selector.
2018-04-09 13:19:05 -04:00
carljbowman 4e30c0b0c7 Unifiy colors variables
- Auditing color CSS and componet CSS to make consistent.
- Made a first pass of changes to increase contrast to elements that previously were problematic
2018-04-09 13:16:26 -04:00
kchadha 90d2e88d4c Merge pull request #1727 from kchadha/remove-to-string-project-loader
Remove toString call in the project-loader.
2018-04-09 13:14:48 -04:00
Karishma Chadha 9a0170c07e Update default project with new more compact serialization. 2018-04-06 17:54:21 -04:00
Chris Willis-Ford 66ca6fe730 Merge pull request #1725 from cwillisf/fix-handle-extension-added
Fix handleExtensionAdded when no targets present
2018-04-06 10:29:42 -07:00
Paul Kaplan 4cd58dc2f2 Only add handlers for costumes/sounds, not needed for blocks. 2018-04-06 10:56:00 -04:00
Paul Kaplan d50766a827 Fix linting 2018-04-06 09:36:09 -04:00
Paul Kaplan 21c37410e6 Manually fire tab change events onclick to fix touching tabs not working
It seems like there is some kind of touch action interference coming
from the blocks panel, where if you touch the tabs on a touchscreen
chromebook/chrome responsive mode, it does not select the tab if the
touch radius is overlapping the blocks panel at all. See gifs in PR for
more explanation. Fixes issue #1283, making chromebooks useable!
2018-04-06 09:24:30 -04:00
Karishma Chadha aa682aaae8 Remove unnecessary toString call in the project-loader. Let VM/Parser handle it. 2018-04-05 15:35:00 -04:00
Christopher Willis-Ford abf33be29a Fix handleExtensionAdded when no targets present
If an extension is loaded at project-load time, there won't be any
targets. In that case, `handleExtensionAdded` now skips target-specific
steps.

This change also adds a filter for JSON block info to support upcoming
block separators, which have XML but no JSON.
2018-04-05 11:09:42 -07:00
Paul Kaplan 505e4af66f Merge pull request #1718 from kchadha/recorded-sound-metadata
Store sample rate/count for recorded sounds
2018-04-05 09:51:18 -04:00
Karishma Chadha d3d1de96e1 Remove whitespace from sound recording name. 2018-04-05 09:43:29 -04:00
Paul Kaplan db54c6c593 Merge pull request #1714 from rschamp/feature/stage-shadow
Make the stage thumbnail match the comps
2018-04-05 08:53:46 -04:00
Paul Kaplan 6eb5755333 Merge pull request #1717 from paulkaplan/editor-tabs
Update design for editor tabs with icons, changing blocks to code.
2018-04-05 08:53:35 -04:00
Karishma Chadha a2d7e6525d Recording names should start at 1, and let the vm create fresh names as needed. 2018-04-04 22:00:22 -04:00
Karishma Chadha 8b81ef310a Pass sample rate and sample count data to vm for recorded sounds. 2018-04-04 21:44:36 -04:00
Paul Kaplan 0753d0794d Update design for editor tabs with icons, changing blocks to code.
Resolves https://github.com/LLK/scratch-gui/issues/1713
2018-04-04 09:20:30 -04:00
Jake Bartles edec051bd4 fixed issue 1691 2018-04-03 20:28:01 -04:00
Michael "Z" Goddard 3f4132612e Merge pull request #1670 from mzgoddard/enable-video-sensing
Enable video sensing extension
2018-04-03 16:23:01 -04:00
Ray Schamp 919469f391 Make the stage thumbnail match the comps 2018-04-03 15:33:07 -04:00
Paul Kaplan 8bf73ed3fa Show the costume/sound number similar to Scratch 2.
Add a jest unit test for making sure the number is rendered out when
provided and not when not provided.
2018-04-02 10:48:01 -04:00
Paul Kaplan 04e108240d Merge pull request #1675 from paulkaplan/fix-1644
Do not autofocus filter in libraries.
2018-03-29 10:02:10 -04:00