ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,171 Commits 3 Branches 499 Tags
28cd140d9f23aeb3131359a12e669d192b2b60de
Commit Graph
423 Commits
Author SHA1 Message Date
Christopher Willis-Ford 1fd9a1f689 Merge branch 'develop' into load-library-images-through-storage 2019-03-14 11:49:47 -07:00
Chris Willis-Ford 33f3d1d79b Merge pull request #4645 from cwillisf/add-telemetry-hooks 
Add telemetry hooks
 2019-03-14 10:47:59 -07:00
Chris Willis-Ford f773ee2dab Merge branch 'develop' into load-library-images-through-storage 2019-03-13 16:33:38 -07:00
chrisgarrity 3e33c10b04 Fix mock store for project-saver-hoc test 
Account for the addition of locale prop expected in mapStateToProps.
Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
 2019-03-12 16:13:44 -07:00
Christopher Willis-Ford face0d20d4 Test library icon rotation by comparing src over time 2019-03-12 15:01:50 -07:00
Paul Kaplan 158409d4d8 Merge pull request #4568 from apple502j/slider-decimal 
Slider range change with decimal value support
 2019-03-11 11:19:49 -04:00
Paul Kaplan 127e1a9632 Add container test for slider prompt 
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.

Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
 2019-03-11 10:51:50 -04:00
Paul Kaplan 1e532745b7 Add a selenium test for slider range 2019-03-11 09:44:56 -04:00
picklesrus 0dd0fd8e7a Merge pull request #4537 from picklesrus/init-locale-vm 
Fixes #4253 by telling the vm the langauge when it is initialized.  B…
 2019-02-27 16:37:31 -05:00
Paul Kaplan 6d5183f99d Merge pull request #4567 from paulkaplan/project-thumbnailer 
Add a way for GUI consumer to retrieve snapshots of the stage
 2019-02-20 13:39:30 -05:00
Paul Kaplan d301794463 Add a way for GUI consumer to retrieve snapshots of the stage 2019-02-15 14:21:37 -05:00
Paul Kaplan 0f803dfc41 Request a toolbox refresh after switching between tabs to fix #4561 2019-02-15 09:10:42 -05:00
Paul Kaplan 208060e441 Merge pull request #4534 from paulkaplan/importing-alert 
Show an "Importing..." alert during file import
 2019-02-13 16:30:28 -05:00
Paul Kaplan 59ca7fc771 Merge pull request #4529 from paulkaplan/support-is-discrete-sliders 
Support isDiscrete sliders
 2019-02-13 12:58:38 -05:00
Paul Kaplan 7847f9e775 Show an "Importing..." alert during file import 2019-02-13 10:21:48 -05:00
picklesrus 1aa241749b Fix up the tests and add a couple checks. 2019-02-12 11:41:32 -05:00
Paul Kaplan ebd372a090 Update to develop and remove try-it steps from new tests 2019-02-12 09:22:24 -05:00
Paul Kaplan 24ca96971e Merge branch 'develop' into prompt-before-upload-replace 2019-02-12 09:21:53 -05:00
Paul Kaplan 4500c4f781 Remove more try-it steps 2019-02-12 09:05:05 -05:00
Paul Kaplan cae9d9a683 Merge branch 'develop' into nj/ui-changes 2019-02-12 09:04:31 -05:00
Paul Kaplan 9bef38e977 Remove try-it step from more integration tests 2019-02-12 08:53:28 -05:00
Paul Kaplan d51c984b90 Add integration test for uploading a file and seeing the prompt 2019-02-11 15:22:40 -05:00
Paul Kaplan 4ef98ec0fe Add unit test to make sure isDiscrete becomes correct step size 2019-02-11 11:48:18 -05:00
Nikhil Jha fb9c3eed74 Merge branch 'develop' into nj/ui-changes 2019-02-08 20:21:32 -08:00
Paul Kaplan b618f2493c Fix backdrop uploading from gif 2019-02-08 13:56:00 -05:00
Paul Kaplan 28635d8028 Remove namer from costume and sound upload helpers to reduce spaghetti 2019-02-08 13:18:57 -05:00
Paul Kaplan 489467e63d Pass function for naming costumes, add integration tests 2019-02-08 13:18:57 -05:00
Paul Kaplan da65b41366 Merge pull request #4499 from LLK/multi-upload 
Multiple file upload for costumes, sounds, backdrops and sprites
 2019-02-08 10:47:15 -05:00
Nikhil Jha 781c682e60 Merge branch 'develop' into nj/ui-changes 2019-02-06 14:56:46 -08:00
Paul Kaplan 6ede63433d Merge pull request #4495 from paulkaplan/dynamic-wait-for-loader 
Wait until loader becomes stale to continue in project loader tests
 2019-02-06 14:34:14 -05:00
Karishma Chadha aa7d52553a Merge pull request #4486 from kchadha/xml-escape 
Escape special characters in toolbox xml
 2019-02-06 14:22:19 -05:00
Paul Kaplan 15642ba661 There is no loading screen for blocks example, dont wait for it 2019-02-06 14:21:20 -05:00
Paul Kaplan 7eabc4d9cd Add integration tests for multiple file upload 
Including sprites, backdrops, costumes and sounds inputs
 2019-02-06 12:09:43 -05:00
Paul Kaplan 35413c6383 Include the waitUntilGone helper in the other project load tests 2019-02-06 11:20:24 -05:00
Paul Kaplan 8daed6d14c Wait until loader becomes stale to continue in project loader tests 2019-02-06 11:10:09 -05:00
Paul Kaplan 6dd6c68595 Add an integration test for toolbox updating after see-inside. 
I needed to update the player css because the editor side wasn't large enough to be useable.
 2019-02-06 09:42:37 -05:00
Karishma Chadha c062d0589b Escape special characters in user defined strings that can appear in the toolbox xml. 2019-02-04 21:31:37 -05:00
Paul Kaplan 52a6136caa Merge pull request #4475 from LukeSchlangen/fix/mode-reducer 
Retain showBranding mode property after SET_FULL_SCREEN action is dispatched
 2019-02-04 14:33:48 -05:00
Luke Schlangen 7494482c9e remove isAdmin from mode reducer 2019-02-04 11:24:42 -06:00
Paul Kaplan 4ae4000682 Remove beforeunload callback that was breaking tests 2019-02-04 11:51:10 -05:00
Paul Kaplan 984eb1b073 Include a regression test for #4476 2019-02-04 09:46:58 -05:00
Luke Schlangen 4db64ca560 add mode reducer unit tests 2019-02-03 12:12:56 -06:00
Nikhil Jha cc80ee345f remove "try it" 2019-02-01 15:29:00 -08:00
Nikhil Jha 9232b1c656 Merge branch 'develop' into nj/ui-changes 2019-02-01 15:19:38 -08:00
Nikhil Jha fcfff18426 try building again 2019-02-01 15:18:30 -08:00
Paul Kaplan 719c5d3c6f Merge branch 'develop' into improve-toolbox-perf 2019-01-30 14:47:06 -05:00
Karishma Chadha af462ec372 Update project changes test to test a project change that should actually emit a change event. Clicking on blocks should not emit a project changed event. 2019-01-30 11:25:07 -05:00
Paul Kaplan f7b5463461 Add test for menus not updating when adding new costumes 
I know we will want to change this eventually, so I added comments about that. But the next commit originally contained an inadvertent change to this functionality, so I wanted to add an integration test so that when we do change it, we
 2019-01-30 09:37:27 -05:00
Paul Kaplan 81bbcf8348 Add an integration test to cover renaming costumes updating the blocks 
It looks like an "test.only" was left in on one of these tests by mistake.
 2019-01-30 09:12:27 -05:00
Nikhil Jha 3d588321ca Different tests fail each time I run them. 2019-01-28 17:39:36 -08:00