ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,208 Commits 3 Branches 499 Tags
327983fc8cad6fc04a451e00a50825b817526ac7
Commit Graph
2796 Commits
Author SHA1 Message Date
Karishma Chadha e82e370e83 Register callback keys for buttons used in future extensions. 2019-04-03 11:10:10 -04:00
Ben Wheeler 2b5196106a remove code in sb-file-uploader that sets uri history on loading project from file 2019-04-01 14:08:11 -04:00
Paul Kaplan 839deda612 Merge pull request #4674 from mzgoddard/project-changed 
dispatch projectChange redux action when project has not changed
 2019-03-28 14:01:18 -04:00
Paul Kaplan dac1ece8fd Merge pull request #4665 from mzgoddard/locale-string 
use Collator.compare in place of localeCompare
 2019-03-28 13:51:42 -04:00
Michael "Z" Goddard 3f73c6df7b dispatch projectChange redux action when project has not changed 
Dispatching a message through redux makes it reconsider all currently
listening components. Dispatching for each block, while loading, can
mean dispatching and reconsidering thousands of times if not more.
While dispatching is pretty quick doing this for every block ends up
taking a lot of time.
 2019-03-20 14:37:02 -04:00
Michael "Z" Goddard f5d1dd7e03 use Collator.compare in place of localeCompare 2019-03-19 17:14:05 -04:00
Evelyn Eastmond 66b3f43581 Merge pull request #4657 from evhan55/extensions/lib-index-file-refactor 
Refactor extensions library index file
 2019-03-19 11:10:58 -04:00
Paul Kaplan 00a4db1213 Remove complexity around promise/non-promise. 
Since this is in a promise chain, it doesn't matter if onUpdateProjectData returns a promise or a primitive, it'll work either way
 2019-03-18 15:09:31 -04:00
Evelyn Eastmond a4cb3b1eb5 Changing React property name for connection tip icon throughout. 2019-03-18 15:04:12 -04:00
Evelyn Eastmond 8e3bd8c631 Changing prop names throughout React chain to reflect new extension library property names. 2019-03-18 14:58:32 -04:00
Evelyn Eastmond a74bb9afc7 Renaming more variable names related to connection modal properties. 2019-03-18 14:50:49 -04:00
Evelyn Eastmond a082d8329e Adding speech2text folder for extension library. 2019-03-18 14:44:43 -04:00
Evelyn Eastmond 9f9a780093 Adding TODO comments for some file renaming suggestions. 2019-03-18 14:44:43 -04:00
Evelyn Eastmond 8c36ad3cc2 Adding some comments for possible variable name changes. 2019-03-18 14:44:43 -04:00
Evelyn Eastmond 1b2555c7de Renaming some more variables in the extensions library index file. 2019-03-18 14:44:43 -04:00
Evelyn Eastmond 996ed08908 Adding asset folders, moving files, and renaming some extension library variables. 2019-03-18 14:44:43 -04:00
Paul Kaplan 7709580710 Move project saving to server to helper, allow external save action 2019-03-18 12:00:01 -04:00
Chris Willis-Ford 33f3d1d79b Merge pull request #4645 from cwillisf/add-telemetry-hooks 
Add telemetry hooks
 2019-03-14 10:47:59 -07:00
Christopher Willis-Ford 5051ba2105 Code review: remove dead code, clarify arg name 2019-03-14 10:35:39 -07:00
Evelyn Eastmond 98ec67d728 Merge pull request #4641 from evhan55/feature/extensions-wifi-icon 
Allow for both bluetooth and internet connection icons in extensions
 2019-03-13 19:39:57 -04:00
Paul Kaplan 1dd3e1d26a Merge pull request #4638 from paulkaplan/remove-analytics 
Remove most of the GA events
 2019-03-13 17:03:21 -04:00
Christopher Willis-Ford f0ba4180c7 Fix spacing in comments 2019-03-12 16:13:44 -07:00
Christopher Willis-Ford f6b9f11d3b Merge branch 'develop' into scratch-desktop 
Conflicts:
	src/components/library-item/library-item.jsx
	src/components/library/library.jsx
	src/components/menu-bar/menu-bar.jsx
	src/containers/library-item.jsx
	src/lib/project-saver-hoc.jsx
 2019-03-12 16:13:40 -07:00
Christopher Willis-Ford 5c4f50c1b8 Merge branch 'develop' into scratch-desktop 2019-03-12 16:13:28 -07:00
Christopher Willis-Ford 4d671ddfab Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 16:13:27 -07:00
Christopher Willis-Ford 94901b33fe Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 16:13:27 -07:00
Christopher Willis-Ford f6dc2726b5 Implement projectDidSave telemetry event 2019-03-12 16:13:21 -07:00
Christopher Willis-Ford 7b4c0657c6 Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 15:55:50 -07:00
Christopher Willis-Ford 39279fa0ef Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 15:55:50 -07:00
Christopher Willis-Ford 5f2f95a6db HACK: report telemetry events if telemetry is active 2019-03-12 15:55:49 -07:00
Paul Kaplan 3a33e7ea86 Update blocks.jsx 2019-03-12 14:34:45 -04:00
Evelyn Eastmond f29b82b636 Adding right padding to icons. 2019-03-12 10:39:27 -04:00
Evelyn Eastmond 31625d6807 Adding ability to show both bluetooth and internet icons in extension library item tiles. 2019-03-12 10:10:59 -04:00
unknown dadef73bfa Testing two icons side by side to see how the padding is currently working. 2019-03-12 09:39:24 -04:00
Paul Kaplan 51f9aafec1 Remove analytics library imports 2019-03-11 15:41:07 -04:00
Paul Kaplan e746b98d83 Remove some of the high-volume analytics events 
Too much traffic, not enough value. Leaving stuff having to do with tips library/tutorial card navigation as well as hardware extension connectivity, as those help us find issues with Scratch.
 2019-03-11 15:14:30 -04:00
Paul Kaplan f72d0b5985 Remove focus selecting in slider prompt 
It is not reliably selecting the input and is making it hard to type into.
 2019-03-11 15:02:46 -04:00
Paul Kaplan 158409d4d8 Merge pull request #4568 from apple502j/slider-decimal 
Slider range change with decimal value support
 2019-03-11 11:19:49 -04:00
Paul Kaplan abf49b3115 Fix more prop ordering for linter 2019-03-11 11:05:16 -04:00
Paul Kaplan 4af0d9fe27 Merge pull request #4628 from LLK/touch-picker 
Make the stage color picker work with touch.
 2019-03-11 11:00:31 -04:00
Paul Kaplan a627552c8e Fix prop ordering for linter 2019-03-11 10:58:09 -04:00
Paul Kaplan 127e1a9632 Add container test for slider prompt 
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.

Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
 2019-03-11 10:51:50 -04:00
Paul Kaplan 438e0f9cf7 Add default values for non-required props 2019-03-11 09:52:48 -04:00
apple502j ef05591d20 Remove decimal option and use type=text 2019-03-08 19:32:01 +09:00
Benjamin Wheeler c83d85e368 Merge pull request #4589 from JinXJinX/fix_account_nav 
fix(UI): fix cursor property when hovering account nav items
 2019-03-07 15:48:50 -05:00
Paul Kaplan d8d39b1d61 Merge pull request #4585 from JinXJinX/develop 
fix(css): fix css value has mixed support warning
 2019-03-07 13:31:39 -05:00
Paul Kaplan f364994a46 Fix trying to get color info before pickX/Y was set 2019-03-07 11:17:48 -05:00
Paul Kaplan b2b4da2f68 Make the stage color picker work with touch. 2019-03-06 11:17:36 -05:00
Eric Rosenbaum 7c557db8b4 Merge pull request #4621 from ericrosenbaum/feature/boost-coming-soon 
Add Boost extension "coming soon" tile
 2019-03-05 14:50:44 -05:00
Eric Rosenbaum b76593cabb Optimize svg and png 2019-03-05 14:36:43 -05:00