ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,208 Commits 3 Branches 499 Tags
327983fc8cad6fc04a451e00a50825b817526ac7
Commit Graph
1291 Commits
Author SHA1 Message Date
Evelyn Eastmond a4cb3b1eb5 Changing React property name for connection tip icon throughout. 2019-03-18 15:04:12 -04:00
Evelyn Eastmond 8e3bd8c631 Changing prop names throughout React chain to reflect new extension library property names. 2019-03-18 14:58:32 -04:00
Chris Willis-Ford 33f3d1d79b Merge pull request #4645 from cwillisf/add-telemetry-hooks 
Add telemetry hooks
 2019-03-14 10:47:59 -07:00
Christopher Willis-Ford 5051ba2105 Code review: remove dead code, clarify arg name 2019-03-14 10:35:39 -07:00
Evelyn Eastmond 98ec67d728 Merge pull request #4641 from evhan55/feature/extensions-wifi-icon 
Allow for both bluetooth and internet connection icons in extensions
 2019-03-13 19:39:57 -04:00
Paul Kaplan 1dd3e1d26a Merge pull request #4638 from paulkaplan/remove-analytics 
Remove most of the GA events
 2019-03-13 17:03:21 -04:00
Christopher Willis-Ford f6b9f11d3b Merge branch 'develop' into scratch-desktop 
Conflicts:
	src/components/library-item/library-item.jsx
	src/components/library/library.jsx
	src/components/menu-bar/menu-bar.jsx
	src/containers/library-item.jsx
	src/lib/project-saver-hoc.jsx
 2019-03-12 16:13:40 -07:00
Christopher Willis-Ford 5c4f50c1b8 Merge branch 'develop' into scratch-desktop 2019-03-12 16:13:28 -07:00
Christopher Willis-Ford 4d671ddfab Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 16:13:27 -07:00
Christopher Willis-Ford 94901b33fe Merge remote-tracking branch 'upstream/develop' into scratch-desktop 2019-03-12 16:13:27 -07:00
Christopher Willis-Ford f6dc2726b5 Implement projectDidSave telemetry event 2019-03-12 16:13:21 -07:00
Evelyn Eastmond f29b82b636 Adding right padding to icons. 2019-03-12 10:39:27 -04:00
Evelyn Eastmond 31625d6807 Adding ability to show both bluetooth and internet icons in extension library item tiles. 2019-03-12 10:10:59 -04:00
unknown dadef73bfa Testing two icons side by side to see how the padding is currently working. 2019-03-12 09:39:24 -04:00
Paul Kaplan 51f9aafec1 Remove analytics library imports 2019-03-11 15:41:07 -04:00
Paul Kaplan e746b98d83 Remove some of the high-volume analytics events 
Too much traffic, not enough value. Leaving stuff having to do with tips library/tutorial card navigation as well as hardware extension connectivity, as those help us find issues with Scratch.
 2019-03-11 15:14:30 -04:00
Paul Kaplan f72d0b5985 Remove focus selecting in slider prompt 
It is not reliably selecting the input and is making it hard to type into.
 2019-03-11 15:02:46 -04:00
Paul Kaplan 158409d4d8 Merge pull request #4568 from apple502j/slider-decimal 
Slider range change with decimal value support
 2019-03-11 11:19:49 -04:00
Paul Kaplan abf49b3115 Fix more prop ordering for linter 2019-03-11 11:05:16 -04:00
Paul Kaplan a627552c8e Fix prop ordering for linter 2019-03-11 10:58:09 -04:00
Paul Kaplan 127e1a9632 Add container test for slider prompt 
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.

Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
 2019-03-11 10:51:50 -04:00
apple502j ef05591d20 Remove decimal option and use type=text 2019-03-08 19:32:01 +09:00
Benjamin Wheeler c83d85e368 Merge pull request #4589 from JinXJinX/fix_account_nav 
fix(UI): fix cursor property when hovering account nav items
 2019-03-07 15:48:50 -05:00
Paul Kaplan d8d39b1d61 Merge pull request #4585 from JinXJinX/develop 
fix(css): fix css value has mixed support warning
 2019-03-07 13:31:39 -05:00
Eric Rosenbaum 08ec713bff update scratch link icon 2019-03-04 14:10:20 -05:00
chrisgarrity 6468395ba5 Merge pull request #4507 from chrisgarrity/issue/3632-localize-tutorials 
Initial version of translated tutorial gifs
 2019-03-04 14:15:15 +01:00
Xu Jing 742e9e327a fix(UI): fix cursor property when hovering account nav items 2019-02-25 18:11:27 -05:00
Xu Jing 9efcadad5d fix(css): fix css justify-content property's value 'start, end' has mixed support warning 2019-02-25 01:51:53 -05:00
apple502j d431c3f8ba Slider range change with decimal value support 2019-02-17 08:58:20 +09:00
Paul Kaplan a10704c44b Merge pull request #4528 from paulkaplan/ask-above-monitors 
Put the ask blocks text input above the monitors on the stage.
 2019-02-13 16:29:55 -05:00
Paul Kaplan 59ca7fc771 Merge pull request #4529 from paulkaplan/support-is-discrete-sliders 
Support isDiscrete sliders
 2019-02-13 12:58:38 -05:00
Paul Kaplan 4927e12e80 Share the replace project confirmation string between new and upload 2019-02-13 09:29:05 -05:00
Paul Kaplan cae9d9a683 Merge branch 'develop' into nj/ui-changes 2019-02-12 09:04:31 -05:00
Paul Kaplan 0ae9d70685 Support the isDiscrete flag on slider monitors 2019-02-11 11:19:41 -05:00
Paul Kaplan 3993d5c8f1 Put the ask blocks text input above the monitors on the stage. 2019-02-11 10:45:03 -05:00
Paul Kaplan 7563eddb2b Merge pull request #4509 from LLK/gif-upload 
Gif upload v1: sprites, costumes
 2019-02-11 10:12:40 -05:00
Nikhil Jha fb9c3eed74 Merge branch 'develop' into nj/ui-changes 2019-02-08 20:21:32 -08:00
Paul Kaplan 38fb199533 Merge pull request #4500 from mzgoddard/loading 
Set an initial message number to skip rendering a second time
 2019-02-08 13:25:54 -05:00
Paul Kaplan 88651e6e48 Gif upload v1: sprites, costumes 2019-02-08 13:18:57 -05:00
chrisgarrity 96668b5b04 Initial version of translated tutorial gifs 
Proof of concept with spanish as the only example.
 2019-02-07 19:14:33 +01:00
Nikhil Jha 781c682e60 Merge branch 'develop' into nj/ui-changes 2019-02-06 14:56:46 -08:00
Michael "Z" Goddard c9cfda8ca8 set an initial message number to skip rendering a second time 2019-02-06 16:53:14 -05:00
Paul Kaplan 8a46b8f71b Make file uploader call callback for each uploaded file 2019-02-06 12:09:32 -05:00
chrisgarrity 865f4306c6 Merge pull request #4477 from chrisgarrity/override-blocksdrag-zindex 
Move blocks z-index up to match gui
 2019-02-05 13:10:59 +01:00
chrisgarrity c9b3f831c4 Move blocks z-index up to match gui 
Override the z-index for the blocks drag layer. At 1000, it will be over everything in the gui other than the navbar itself (monitors on the stage, tutorials, alerts, dropdown menus, etc.)
 2019-02-04 18:37:32 +01:00
Paul Kaplan 359c491093 Merge pull request #4433 from towerofnix/ctrl-s-to-save-2 
Control/Command+S to save
 2019-02-04 09:59:23 -05:00
Nikhil Jha 9232b1c656 Merge branch 'develop' into nj/ui-changes 2019-02-01 15:19:38 -08:00
Florrie 528b3412d6 Use bowser for macOS detection 2019-02-01 17:00:52 -04:00
Nikhil Jha aaa8fd20e4 Fix Lint 2019-01-28 17:07:43 -08:00
Nikhil Jha 9da0937ebb Remove References 2019-01-28 16:52:46 -08:00