Commit Graph
1740 Commits
Author SHA1 Message Date
chrisgarrity a0d6d049d5 Merge pull request #2799 from chrisgarrity/feature/2756-rtl-libraries
Handle RTL for the Modal Component (and things that used the modal component)

Fixes #2756
2018-08-08 11:15:17 -04:00
chrisgarrity f201c5fd47 Don’t reverse all button icons
The ‘back/retry’ button in the connection modal should be reversed, but the others (bluetooth icon, question mark) probably shouldn’t.
2018-08-08 10:00:21 -04:00
chrisgarrity 4cadc55733 Fix modal help button padding 2018-08-07 15:50:07 -04:00
Ray Schamp a46b6caef5 Merge pull request #2745 from paulkaplan/backpack-to-tiles
Add from backpack to sprite/stage tiles
2018-08-07 10:17:00 -04:00
chrisgarrity ee50ef99e0 RTL corrections
* center the title on full screen modals.
Adding the `[dir=“ltr”]` atttribute to the css rule for a child style didn’t work the way I expected.
`[dir="ltr"] .full-screen .header-item-title` did not match the fullscreen title element, so the style wasn’t applied.
`.full-screen [dir="ltr"] .header-item-title` did match.
* fix the filter to reverse the icon and ‘x’ in the filter input
* more space after the library back icon
* reverse the arrow on camera -retake image and rerecord sound.
2018-08-06 16:46:05 -04:00
chrisgarrity 486d38d0ea make css format consistent 2018-08-06 14:44:57 -04:00
chrisgarrity 3f68678541 Handle RTL for the Modal Component
Fixes #2756 Libraries and many other modals share the Modal Component.

Connected the Modal container to redux to make it aware of the RTL state, and then made sure that all places that use the modal component import the container, not the component directly.
2018-08-06 12:15:30 -04:00
Paul Kaplan bc93a131d8 Merge pull request #2580 from rschamp/bugfix/player-loader
Fix loading projects by hash on player example
2018-08-06 11:32:17 -04:00
chrisgarrity 9e31cd2e8a Merge pull request #2760 from chrisgarrity/feature/1579-rtl
fixes #1579
2018-08-03 15:57:09 -04:00
Paul Kaplan ff7daa189b Merge pull request #2777 from paulkaplan/instrument-device-connections
Instrument device connection events
2018-08-03 13:41:39 -04:00
Paul Kaplan f50cf118d9 Merge pull request #2727 from paulkaplan/drop-area-for-stage
Share costumes and sounds to stage
2018-08-03 13:02:41 -04:00
Paul Kaplan d80078a224 Do not call handleConnected in componentDidMount
Two reasons: 
1. Avoid triggering "connected" event, because the device was already connected
2. It is not good to call `setState` in componentDidMount, which is effectively what it was doing.
2018-08-03 08:56:30 -04:00
Paul Kaplan 11b2fee8a8 Add instrumentation for connecting and connected events for extensions 2018-08-03 08:55:16 -04:00
Paul Kaplan 9bb65cd05d Fix proptypes 2018-08-03 08:39:50 -04:00
Ray Schamp 0973a528d4 Use explicit projectId prop
/ht @gnarf
2018-08-03 08:39:50 -04:00
Ray Schamp 90228ad8ec Fix loading projects by hash on player example 2018-08-03 08:39:49 -04:00
chrisgarrity ea6980e39c Flip the direction of a bunch of icons
I think this switches all the icons we saw. I also switched the icons on the tabs (the blocks going the wrong way looked bad).
2018-08-02 17:06:55 -04:00
Paul Kaplan 65626dc777 Merge pull request #2764 from paulkaplan/direction-picker
Add direction popover with dial and rotation style changing
2018-08-02 17:01:18 -04:00
Paul Kaplan 1f23d09315 Merge pull request #2767 from paulkaplan/turbo-events
Turbo mode menu
2018-08-02 13:15:50 -04:00
Paul Kaplan 93977e8534 Fix prop type warning 2018-08-02 12:53:16 -04:00
Paul Kaplan 0dff636adc Fix comment 2018-08-02 12:49:01 -04:00
Paul Kaplan a768eccf8c Enable turbo mode menu item with composer container 2018-08-02 10:42:21 -04:00
Paul Kaplan cb7e0e6e52 Add vm status reducer to hold running and turbo state.
Move listeners up to vmListenerHOC, and add listeners for new turbo mode events from scratch-vm#1413
2018-08-02 10:22:18 -04:00
Paul Kaplan 849744a64b Prevent selection of icons by highlighting 2018-08-02 08:54:32 -04:00
Paul Kaplan 45f762b01b Merge pull request #2761 from LLK/master
Bring in hotfix to beta stuff to develop
2018-08-01 20:19:36 -04:00
Paul Kaplan fe4b5f7429 Fix rotation styles import 2018-08-01 20:18:42 -04:00
Paul Kaplan ed0bb757ab Fix lint 2018-08-01 15:56:17 -04:00
chrisgarrity e8c888ee02 Sprite info and Sprite selector RTL
Changed left/right to first/last. Added direction aware styles.
2018-08-01 15:55:11 -04:00
chrisgarrity 2c30f66c11 RTL tabs
Correct margins for tabs, tab icons.
2018-08-01 15:55:11 -04:00
chrisgarrity 749683b39a Sound Editor RTL
Checked with Moran, and the sound waveform along with play button should stay LTR. So added a `row-reverse` that only applies when `dir=“rtl”`
2018-08-01 15:55:11 -04:00
chrisgarrity 07d53b24ff RTL Labels
Move the margin to the other side.
2018-08-01 15:55:10 -04:00
chrisgarrity 7872583517 Extension button RTL 2018-08-01 15:55:10 -04:00
chrisgarrity ca19e77106 Stage-header RTL
Rename buttons first and last instead of left/right. Add RTL styles.
2018-08-01 15:55:10 -04:00
chrisgarrity 67f4496947 Action menu RTL
This bled into normalizing z-indices for the action menus in the z-index.css. The tooltip id was not unique between action menus for ‘suprise’ and ‘paint’, so `mainTooltipId` was used as a prefix to make them unique.
2018-08-01 15:55:10 -04:00
chrisgarrity 375e9c3f07 Basic RTL 2018-08-01 15:55:10 -04:00
Paul Kaplan bd0e329568 Add direction popover with dial and rotation style changing 2018-08-01 15:41:10 -04:00
Andrew Sliwinski 63c189e531 Merge pull request #2678 from LLK/preview-to-beta
Hotfix: Preview to Beta changes
2018-08-01 08:28:28 -04:00
Paul Kaplan 7fce62b648 Update the feedback link to point to dedicated discussion area 2018-07-31 09:55:27 -04:00
Paul Kaplan b39323858c Allow backpack sounds/costumes to be dragged into sprite and stage tiles 2018-07-31 09:45:42 -04:00
chrisgarrity 3037745f76 Merge pull request #2739 from apple502j/patch-1
Translate Spin & Arrow How-To
2018-07-31 08:07:25 -04:00
Paul Kaplan 770002a49e Merge pull request #2729 from paulkaplan/only-two-next-steps
Show only 2 other tutorials in last step of each tutorial.
2018-07-30 11:41:24 -04:00
Paul Kaplan 25cbeb7e48 Merge pull request #2732 from paulkaplan/pad-asset-list
Pad bottom of costume/sound list to allow you to reach the bottom tile
2018-07-28 14:43:12 -04:00
apple502j 496f8c494b Translate Spin & Arrow How-To 2018-07-28 19:59:39 +09:00
Paul Kaplan a338692f42 Pad bottom of costume/sound list to allow you to reach the bottom tile 2018-07-25 15:52:12 -04:00
Paul Kaplan e1fbfe0f17 Merge pull request #2730 from paulkaplan/remove-costume-canvas
Remove costume canvas and just display tiles using <img> tags
2018-07-25 14:15:43 -04:00
Paul Kaplan 465e28a222 Use img instead of CostumeCanvas 2018-07-25 13:53:11 -04:00
Paul Kaplan 7f37a52f46 Show only 2 other tutorials in last step of each tutorial.
Enforce this by using `slice` so that no more are ever shown, which would mess up the layout.

Also fixes the issue where the card text could push out when translated into other languages
2018-07-25 13:22:56 -04:00
Paul Kaplan c4f5820bc2 Generalize drop area code into HOC to get sharing assets to stage 2018-07-25 11:48:16 -04:00
Paul Kaplan 156e62c742 Merge pull request #2699 from paulkaplan/set-username
Add username setting to vm listener HOC
2018-07-25 09:58:59 -04:00
Karishma Chadha a5abdfeae5 Clear the workspace undo when the workspace updates. 2018-07-24 15:01:03 -04:00