Commit Graph
43 Commits
Author SHA1 Message Date
chrisgarrity c530cb1235 Fix connection modal padding for RTL 2018-08-27 09:18:39 -04:00
chrisgarrity 4cadc55733 Fix modal help button padding 2018-08-07 15:50:07 -04:00
chrisgarrity ee50ef99e0 RTL corrections
* center the title on full screen modals.
Adding the `[dir=“ltr”]` atttribute to the css rule for a child style didn’t work the way I expected.
`[dir="ltr"] .full-screen .header-item-title` did not match the fullscreen title element, so the style wasn’t applied.
`.full-screen [dir="ltr"] .header-item-title` did match.
* fix the filter to reverse the icon and ‘x’ in the filter input
* more space after the library back icon
* reverse the arrow on camera -retake image and rerecord sound.
2018-08-06 16:46:05 -04:00
chrisgarrity 3f68678541 Handle RTL for the Modal Component
Fixes #2756 Libraries and many other modals share the Modal Component.

Connected the Modal container to redux to make it aware of the RTL state, and then made sure that all places that use the modal component import the container, not the component directly.
2018-08-06 12:15:30 -04:00
Connor Hudson ee8ec95aaa Set a z-index on the help item in the extension modal header 2018-07-23 11:04:13 -04:00
Paul Kaplan 61c2358b42 Add "help" to the modal for device connection flow 2018-07-18 11:42:11 -04:00
Paul Kaplan 18fc37c129 Propagate extension device images to make extension specific flows 2018-07-10 14:43:36 -04:00
Eric Rosenbaum 554e591343 wip 2018-07-02 10:18:13 -04:00
sjhuang26 582d591231 Move z-index values to separate file 2018-06-02 15:54:37 -04:00
chrisgarrity 0448f7e80e Add setAppElement function to exported GUI
Fixes #1853
2018-05-09 10:03:30 -04:00
chrisgarrity 45032cc291 Add translation to missing strings
Question, should ‘x’ and ‘y’ be localizable?
2018-04-30 12:22:23 -04:00
Ray Schamp a36ff212ea Final spacing and height tweaks with @carljbowman 2018-04-20 12:05:17 -04:00
Ray Schamp e943ba2d28 Fix back button in modals on Firefox
Thanks @towerofnix!
2018-04-20 09:48:39 -04:00
Ray Schamp 1e8bca53fb Rearrange to use existing back icon 2018-04-19 14:00:38 -04:00
Ray Schamp dde95cc35f WIP: Stuff is sketched in 2018-04-19 14:00:37 -04:00
carljbowman 4e30c0b0c7 Unifiy colors variables
- Auditing color CSS and componet CSS to make consistent.
- Made a first pass of changes to increase contrast to elements that previously were problematic
2018-04-09 13:16:26 -04:00
Paul Kaplan fffec19302 Remove visible property from modal and library components 2017-09-01 09:09:08 -04:00
Paul Kaplan 8a10c04f42 Add import/export rules and fix lint errors 2017-07-21 08:58:24 -04:00
Paul Kaplan df5d8bc8a5 Convert requires to import 2017-06-30 15:14:05 -04:00
Paul Kaplan 7950eb6bfd Refactor modal component to be used by prompt, library and recorder 2017-06-27 10:27:06 -04:00
Paul Kaplan 7026590619 Cleanup css and modules 2017-06-23 11:37:39 -04:00
Paul Kaplan 736cb4c41f Pass onRequestClose to ReactModal to handle escape key 2017-06-07 09:47:07 -04:00
DD Liu ec2fd08be9 remove unused code 2017-05-25 16:40:13 -04:00
DD Liu c7f05a807c implement the close button on filter 2017-05-25 15:42:20 -04:00
DD Liu 616df9be2c make there not be two scroll bars sometimes 2017-05-25 15:26:31 -04:00
DD Liu 95ddb56afd fix a warning on grow box 2017-05-25 14:58:19 -04:00
DD Liu e16f794050 fix css so that when the library doesn't fill the screen, the modal does not shrink 2017-05-25 14:47:30 -04:00
DD Liu 4d573a3a6c Merge filter container with library component and get rid of 'active' state of filter component 2017-05-25 14:17:48 -04:00
steven dale a71b751c4c lint fixes 2017-05-16 14:22:39 -04:00
steven dale 0b499bf24e * Library component: moved header logic + css to Modal component. Updated sprite alignment
* Close button component: large: added similar transition to add button
* Filter component: added autofocs, made full width
2017-05-16 13:43:07 -04:00
steven dale c13573d0ad moving stuff into modal 2017-05-16 10:34:23 -04:00
steven dale c2322d3aa8 wip 2017-05-11 08:46:53 -04:00
steven dale 0bb0341698 Full height/width modal for libraries 2017-05-10 18:07:31 -04:00
Ray Schamp 58d482d102 Move to PropTypes for React 15.5
With jscodeshift thank God
2017-04-20 19:02:59 -04:00
Paul Kaplan 402f85ef91 Add isRequired to required prop types 2017-03-28 10:19:00 -04:00
Steven Dale 648aebaa45 Made UI elements non-selectable (#234)
Affects SpriteSelector Pane, StageSelector Pane, Stage, MenuBar, Libraries Modal, Add/Import buttons, for Chrome, Ffx + Safari on Sierra.

Fixes #162
2017-03-20 16:26:15 -04:00
Paul Kaplan a28be80b61 Move modal close button to shared component 2017-03-09 11:20:15 -05:00
Steven Dale 0e56f866e5 TODO: -> @todo: (#213)
Refactored towards better convention for linting.
2017-03-07 17:43:10 -05:00
Steven Dale 702dddbb8d Libraries: Design pass (#160)
* Design pass on libraries to make sprites look more like they do in the SpriteSelector. Fixed scrolling overflow when reaching the bottom
* Started a colors variables file
* Added a light transform on sprite item hover

Related #12
2017-03-06 11:08:04 -05:00
Steven Dale 74dde69fd0 Design pass: layout panes, sprite libraries, info area, import buttons, + menu bar (#83)
* Covers parts of these issues: GUI layout panes (#69), sprite libraries (#12), import buttons (#64), menu bar (#67), and sprite info area (#53)

~ Refactored layout pane structure by removing `display: flex` from `.box`, by default. Declaring flex instead only where specifically needed. This helped fix layout quirks, and should help us avoid hard to find issues related to nested flex boxes

~ Added descriptive classnames to boxes/containers/wrappers. Moved more padding, margins + layout into these wrappers to help with component reusability.

~ Set up a spacer unit variable inside `gui.css`, to start keeping consistent padding, margins and rounded corners between panes. Used [CSS/PostCSS Modules](https://github.com/css-modules/postcss-modules-values) to avoid SCSS dependency.

~ Refactored inline styles from JSX, into CSS files. 2 reasons: a) prepping for reuse of CSS Module variables. b) Feels easier to debug complex flex layouts when all the styles are in one place vs JS/HTML/CSS syntax mixed together

~ Added menu bar into layout via new component, and sprite info header in sprite selector pane, with stubs for the labels + forms. Sprite items are correctly scrolling, while leaving the header fixed, in Chrome. Mostly working in FFx. Not working in Safari, IE yet.

~ Style pass on library modal

~ Experimenting with a few different transition styles: Logo in menu bar, sprite library items, Add buttons.
2017-02-15 08:46:16 -05:00
Ray Schamp 16b1c90706 Fix components for react-modal 1.6.5 2017-02-02 14:48:24 -05:00
Ray Schamp 6ae2fbb6a0 Use Box in libraries and modal 2016-12-15 11:15:18 -05:00
Ray Schamp 16fbb64cca Use CSS modules for styles
The inline css method gives us nothing that CSS modules can't give us. This puts the project more in line with the way www works, and makes CSS actually readable.

Using class names gives us full control of the modal styles.
2016-12-07 15:59:07 -05:00