ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,721 Commits 3 Branches 499 Tags
6db27c7fd9bb0bb097828acbfb4cf0efd329e216
Commit Graph
225 Commits
Author SHA1 Message Date
Paul Kaplan b07c645124 Fix saving after recording a sound 2019-08-02 09:31:53 -04:00
chrisgarrity 3feff9fea8 Merge pull request #5017 from chrisgarrity/fix-up-delete-button 
Make delete button accessible
 2019-08-02 08:39:27 -04:00
rschamp 3c6bfe0607 Add Jest-specific linting rules 
Adding this caught a couple of important things:
- The sound integration tests have a `.only` in them
- The project-saver-hoc tests had two tests with the same description, causing possible confusion if that test broke
 2019-08-01 11:31:01 -04:00
Chris Garrity 3701a4fb44 Refactor to separate container/component 
Also noticed that Delete aria label was not localized.
 2019-07-31 16:20:34 -04:00
Eric Rosenbaum 7d1dfb67b7 Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4 
Sound editor update: selection-based editing
 2019-07-30 15:27:04 -04:00
Eric Rosenbaum 2890609053 Add unit test for audio effect adjustedTrim times 2019-07-30 11:38:52 -04:00
Chris Garrity cd7b5d93ee fix focus styling 
Don’t use default focus style it’s ugly.

Don’t allow the image to be dragged.
 2019-07-26 09:36:16 -04:00
Eric Rosenbaum 8f23093617 Update snapshot 2019-07-25 15:12:04 -04:00
Eric Rosenbaum 0b9969c412 Update snapshot 2019-07-24 17:11:36 -04:00
Eric Rosenbaum 0f17157a3d Update tests without echo effect 2019-07-23 16:14:56 -04:00
Eric Rosenbaum d9409f0f0c Cleanup test 2019-07-22 17:48:25 -04:00
Eric Rosenbaum 40dc8487f4 Fix off-by-one error in reverse effect, add a test 2019-07-22 17:47:44 -04:00
Chris Garrity 4e47cc875a Cleanup 
* removed commented out cruft
* added tabIndex prop to delete button (with default=0)
* the last change also required a change to the sprite selector test snapshot
 2019-07-22 12:02:14 -04:00
Chris Garrity 415ecee8ba Update tests 2019-07-22 12:02:14 -04:00
Eric Rosenbaum 2659490a70 Update snapshot 2019-07-15 12:00:27 -04:00
Eric Rosenbaum c11624ab06 Fix tests and remove unused icons 2019-07-09 17:23:20 -04:00
Eric Rosenbaum 1e147e4397 Fix tests 2019-07-09 15:32:29 -04:00
Eric Rosenbaum fdd4b61d5d Revert and fix tests 
This reverts commit 42ff50300cff7558fd03cdebb757eca8caf85199.
 2019-07-09 15:32:29 -04:00
Eric Rosenbaum 0d88c7755b Update tests 2019-07-09 15:32:28 -04:00
Paul Kaplan 0bbb11012d Merge pull request #4935 from LLK/drag-angle 
Allow vertical scrolling of sprite tile pane on touch devices
 2019-06-24 14:05:32 -04:00
chrisgarrity 164ddbe4f4 Revert "Revert "Merge pull request #4790 from LLK/e16n"" 2019-06-20 17:12:59 -04:00
picklesrus 8d3a85860e Revert "Merge pull request #4790 from LLK/e16n" 
This reverts commit c061f2e2f0, reversing
changes made to 6e007b1e4a.
 2019-06-20 11:21:56 -04:00
Paul Kaplan 8611c9ff1a Refactor gesture recognizer with tests 2019-06-19 11:26:42 -04:00
Chris Willis-Ford dc49c0ebe4 Merge branch 'develop' into e16n 2019-06-18 16:06:46 -07:00
Christopher Willis-Ford 7755f76215 simplify MockBlock construction 2019-06-18 14:15:43 -07:00
Christopher Willis-Ford 6e44bfea95 fix lint errors in define-dynamic-block.test.js 2019-06-18 11:37:17 -07:00
Paul Kaplan 13e324b52d Use title card instead of video if using scratchDesktop flag 2019-06-05 12:53:32 -04:00
Christopher Willis-Ford a6fe8585fb add unit tests for defineDynamicBlock 2019-06-03 13:04:15 -07:00
Paul Kaplan eb74d6c033 Include a unit test to ensure default project assets are included 2019-05-23 11:22:36 -04:00
Ben Wheeler 516baedad9 added tests, rewrote menu-bar-hoc to accomodate tests 2019-05-01 07:02:07 -04:00
Paul Kaplan 9d185bd6c8 Merge pull request #4753 from paulkaplan/project-save-trigger 
Allow GUI consumer to receive a function for triggering saves.
 2019-04-23 08:32:36 -04:00
Paul Kaplan a0745e4f40 Allow GUI consumer to receive a function for triggering saves. 
Use the same implementation as onSetProjectThumbnailer which does the same thing for getting a thumbnail externally.
 2019-04-19 09:19:00 -04:00
Ben Wheeler c064eaed4e upload in current project id, rather than creating new project id 2019-04-16 23:34:07 -04:00
Chris Willis-Ford 33f3d1d79b Merge pull request #4645 from cwillisf/add-telemetry-hooks 
Add telemetry hooks
 2019-03-14 10:47:59 -07:00
chrisgarrity 3e33c10b04 Fix mock store for project-saver-hoc test 
Account for the addition of locale prop expected in mapStateToProps.
Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
 2019-03-12 16:13:44 -07:00
Paul Kaplan 158409d4d8 Merge pull request #4568 from apple502j/slider-decimal 
Slider range change with decimal value support
 2019-03-11 11:19:49 -04:00
Paul Kaplan 127e1a9632 Add container test for slider prompt 
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.

Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
 2019-03-11 10:51:50 -04:00
picklesrus 0dd0fd8e7a Merge pull request #4537 from picklesrus/init-locale-vm 
Fixes #4253 by telling the vm the langauge when it is initialized.  B…
 2019-02-27 16:37:31 -05:00
Paul Kaplan d301794463 Add a way for GUI consumer to retrieve snapshots of the stage 2019-02-15 14:21:37 -05:00
Paul Kaplan 208060e441 Merge pull request #4534 from paulkaplan/importing-alert 
Show an "Importing..." alert during file import
 2019-02-13 16:30:28 -05:00
Paul Kaplan 7847f9e775 Show an "Importing..." alert during file import 2019-02-13 10:21:48 -05:00
picklesrus 1aa241749b Fix up the tests and add a couple checks. 2019-02-12 11:41:32 -05:00
Paul Kaplan 4ef98ec0fe Add unit test to make sure isDiscrete becomes correct step size 2019-02-11 11:48:18 -05:00
Luke Schlangen 7494482c9e remove isAdmin from mode reducer 2019-02-04 11:24:42 -06:00
Luke Schlangen 4db64ca560 add mode reducer unit tests 2019-02-03 12:12:56 -06:00
picklesrus 0eeff37d09 Fix test broken in #4422 by updating the snapshot. 2019-01-23 17:37:12 -05:00
Paul Kaplan 655a179cb8 Merge pull request #4417 from paulkaplan/throttle-costume-updates 
Throttle costume and watermark updates
 2019-01-23 16:24:01 -05:00
Paul Kaplan d9c5ad6aa4 Use curried style for HOC configuration 2019-01-23 15:56:23 -05:00
Paul Kaplan 0bc6de1362 Throttle updates to assets on sprite selector item via HOC 
Adds unit tests for this HOC.
 2019-01-23 14:30:41 -05:00
Paul Kaplan 8e22161a7d Merge pull request #4407 from paulkaplan/no-updates-while-recording 
Disable target updates while sound recording
 2019-01-23 12:12:33 -05:00