ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,788 Commits 3 Branches 499 Tags
b74f19e6e673dfb52ced74de639b2ca4be3425c4
Commit Graph
3061 Commits
Author SHA1 Message Date
Florrie b74f19e6e6 Use list-area:after to pad scroll area 2019-09-02 23:26:46 -03:00
Zoë Bentley 2f08acae45 Fixed Portuguese (Brazilian) locale 2019-08-29 15:41:06 -04:00
Eric Rosenbaum 8ba5ecbec0 Add Marian sprite and costumes 2019-08-28 10:14:28 -04:00
Paul Kaplan 25611283c4 Merge pull request #5103 from zoebentley/imagine-if-video 
Added the Imagine If video to Imagine If tutorial, and changed last step
 2019-08-16 11:09:39 -04:00
Zoë Bentley 4a19260911 Added Imagine If Wistia link to translate-video.js 2019-08-15 18:14:18 -04:00
Zoë Bentley e9880c4d17 Removed Imagine If video (supposed to be part of a different PR) 2019-08-15 18:06:45 -04:00
Zoë Bentley b2bf8605ae Added video links for Portuguese and Italian tutorials 2019-08-15 17:56:07 -04:00
Zoë Bentley 3f5e5fbc0e Reduced image size 2019-08-15 17:51:03 -04:00
Zoë Bentley ad1d7e2751 Added the Imagine If video to the Imagine If tutorial, and changed the last card 2019-08-15 17:43:55 -04:00
Paul Kaplan 593c3448eb Merge pull request #5092 from paulkaplan/fix-import-hang 
Close importing after failing to import
 2019-08-14 11:15:06 -04:00
picklesrus 907059be00 Revert "Fix duplicate running blocks by removing pointer-events: none" 2019-08-13 17:34:02 -04:00
Paul Kaplan ab0ee830d8 Close importing after failing to import 2019-08-13 11:33:32 -04:00
Chris Garrity 8c94fef24c Get the mime-type for the file from the blob 
Depends on the VM change that sets the mime-type
 2019-08-12 15:32:30 -04:00
Paul Kaplan ec386be590 Merge pull request #5078 from LLK/fix-duplicate-run 
Fix duplicate running blocks by removing pointer-events: none
 2019-08-12 08:42:42 -04:00
DD Liu 0adf321455 Merge pull request #5071 from fsih/webpackResolver 
Add webpack resolver to eslintrc so linter doesn't give false positive noUnresolved errors
 2019-08-08 16:08:04 -04:00
Paul Kaplan d4d6dede94 Fix duplicate running blocks by removing pointer-events: none; 2019-08-08 15:16:55 -04:00
Ray Schamp 445874cb9c Revert "Make delete button accessible" 2019-08-08 10:30:58 -04:00
DD Liu 6658158972 Merge branch 'develop' into webpackResolver 2019-08-08 00:35:46 -04:00
DD Liu 127aa38f58 use path.resolve for config 2019-08-08 00:26:51 -04:00
Paul Kaplan 90b71ce5e5 Merge pull request #5039 from paulkaplan/fix-context-menu-after-drag 
Fix issue where context menu wouldn't come back after dragging
 2019-08-07 15:59:28 -04:00
DD Liu eb989d7b2e Add webpack resolver to eslintrc so linter doesnt give false positive noUnresolved errors 2019-08-06 16:05:06 -04:00
Paul Kaplan b07c645124 Fix saving after recording a sound 2019-08-02 09:31:53 -04:00
chrisgarrity 69b7eef768 Merge pull request #4926 from LLK/sound-lib-touch 
Add play buttons to sound library tiles for touch
 2019-08-02 08:39:48 -04:00
chrisgarrity 3feff9fea8 Merge pull request #5017 from chrisgarrity/fix-up-delete-button 
Make delete button accessible
 2019-08-02 08:39:27 -04:00
Chris Garrity 3701a4fb44 Refactor to separate container/component 
Also noticed that Delete aria label was not localized.
 2019-07-31 16:20:34 -04:00
Chris Garrity e2c2bd3927 remove callbacks 2019-07-31 15:38:30 -04:00
Chris Garrity ab1537dab4 Use classNames instead of ternary 
Use the classNames feature to include/exclude a class based on a boolean instead of ternary operator
 2019-07-31 12:05:16 -04:00
Chris Garrity 043e31a472 Refactor 
* split play-button into container and component
* revised sound library tile:
  * play button in upper right
  * smaller sound icon (make the tile less loaded)
 2019-07-31 12:05:16 -04:00
Chris Garrity 91f5c4910f refactor to create play-button for sound items 
Play button doesn’t have a ‘touch-outside’ listener to stop sounds. That seems to be ok as other events cause the sound to stop.

Both handleClick and handleMouseDown are needed. Must use handleMouseDown for `preventDefault` to skip setting focus on the item. handleClick is needed to prevent the Click from propagating to the item and selecting it.
 2019-07-31 12:05:16 -04:00
Chris Garrity 41cc11c32e Handle sound ending 
Update UI play/stop button when the sound ends
 2019-07-31 12:05:16 -04:00
Chris Garrity 6216e7dfa7 improve touch interactions 
Play button is larger (easier to touch). Can both start and stop sounds.
Sound doesn’t restart on mouseEnter if the sound is already playing.
Sound stops if you move off play button

Missing: stop button does not revert to play button when the sound finishes.
 2019-07-31 12:05:16 -04:00
Chris Garrity 8ff41a3986 revise styles 
Checked with Carl and updated the style of the play button.
 2019-07-31 12:05:16 -04:00
Chris Garrity f3d1a91533 Add play buttons to sound library tiles for touch 
Add prop to library items to show a play button. If a play button is present the ‘play on hover’ only applies over the icon rather than the full tile.
 2019-07-31 12:05:16 -04:00
Paul Kaplan 6222c79bee Merge pull request #5048 from ericrosenbaum/bugfix/update-fade-icons 
Update fade icons
 2019-07-31 10:50:03 -04:00
Paul Kaplan e4ebd53e69 Merge pull request #5050 from paulkaplan/fix-recording-drag-firefox 
Prevent default when dragging trim handles to prevent image drag
 2019-07-31 10:49:20 -04:00
Paul Kaplan c855152e86 Prevent default when dragging trim handles to prevent image drag 2019-07-31 10:48:06 -04:00
Eric Rosenbaum dce65e33a5 Update fade icons 2019-07-31 10:43:54 -04:00
Paul Kaplan 4757bb73e4 Do not update trimmers only if both have not changed 2019-07-31 10:27:15 -04:00
Eric Rosenbaum 7d1dfb67b7 Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4 
Sound editor update: selection-based editing
 2019-07-30 15:27:04 -04:00
Paul Kaplan 227d747c72 Fix gestureInProgress after dragEnd to return the correct value 
Fixes #5031, which is happening because the gestureInProgress call is still returning true after a drag ends.
 2019-07-29 15:52:15 -04:00
Chris Garrity 1b4b50b09a Make space and enter actually work if focused 
If the delete button is the current active element (e.g. focused by tab) make hitting ‘space’ or ‘Enter’ do the actual delete.
 2019-07-26 09:37:39 -04:00
Chris Garrity cd7b5d93ee fix focus styling 
Don’t use default focus style it’s ugly.

Don’t allow the image to be dragged.
 2019-07-26 09:36:16 -04:00
Eric Rosenbaum 032cd5aa02 Use DragRecognizer in AudioTrimmer 2019-07-25 15:53:07 -04:00
Eric Rosenbaum b0dbe9e323 Flip copy to new button in RTL, and use a class for flipping buttons 2019-07-25 15:29:10 -04:00
Eric Rosenbaum afccf65157 Improve accuracy of waveform rendering 2019-07-25 15:10:13 -04:00
Eric Rosenbaum c215104522 Only deselect-outside if there’s a selection 2019-07-25 14:33:49 -04:00
Ray Schamp 68389c8e6f Merge pull request #5027 from chrisgarrity/remove-delete-slop 
Remove touch slop
 2019-07-25 11:52:02 -04:00
Chris Garrity d4201075d0 Remove touch slop 2019-07-25 11:47:21 -04:00
Chris Garrity dd0c3d7468 Check for null child before cloning menu item 2019-07-25 11:20:18 -04:00
Eric Rosenbaum d8df13a12c Prevent selection from moving when handles cross over 2019-07-24 17:02:54 -04:00