ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
5,716 Commits 3 Branches 499 Tags
bdcb54f8b1f8df233ebdf24fb8596a981837ac2b
Commit Graph
3039 Commits
Author SHA1 Message Date
Paul Kaplan b07c645124 Fix saving after recording a sound 2019-08-02 09:31:53 -04:00
chrisgarrity 69b7eef768 Merge pull request #4926 from LLK/sound-lib-touch 
Add play buttons to sound library tiles for touch
 2019-08-02 08:39:48 -04:00
chrisgarrity 3feff9fea8 Merge pull request #5017 from chrisgarrity/fix-up-delete-button 
Make delete button accessible
 2019-08-02 08:39:27 -04:00
Chris Garrity 3701a4fb44 Refactor to separate container/component 
Also noticed that Delete aria label was not localized.
 2019-07-31 16:20:34 -04:00
Chris Garrity e2c2bd3927 remove callbacks 2019-07-31 15:38:30 -04:00
Chris Garrity ab1537dab4 Use classNames instead of ternary 
Use the classNames feature to include/exclude a class based on a boolean instead of ternary operator
 2019-07-31 12:05:16 -04:00
Chris Garrity 043e31a472 Refactor 
* split play-button into container and component
* revised sound library tile:
  * play button in upper right
  * smaller sound icon (make the tile less loaded)
 2019-07-31 12:05:16 -04:00
Chris Garrity 91f5c4910f refactor to create play-button for sound items 
Play button doesn’t have a ‘touch-outside’ listener to stop sounds. That seems to be ok as other events cause the sound to stop.

Both handleClick and handleMouseDown are needed. Must use handleMouseDown for `preventDefault` to skip setting focus on the item. handleClick is needed to prevent the Click from propagating to the item and selecting it.
 2019-07-31 12:05:16 -04:00
Chris Garrity 41cc11c32e Handle sound ending 
Update UI play/stop button when the sound ends
 2019-07-31 12:05:16 -04:00
Chris Garrity 6216e7dfa7 improve touch interactions 
Play button is larger (easier to touch). Can both start and stop sounds.
Sound doesn’t restart on mouseEnter if the sound is already playing.
Sound stops if you move off play button

Missing: stop button does not revert to play button when the sound finishes.
 2019-07-31 12:05:16 -04:00
Chris Garrity 8ff41a3986 revise styles 
Checked with Carl and updated the style of the play button.
 2019-07-31 12:05:16 -04:00
Chris Garrity f3d1a91533 Add play buttons to sound library tiles for touch 
Add prop to library items to show a play button. If a play button is present the ‘play on hover’ only applies over the icon rather than the full tile.
 2019-07-31 12:05:16 -04:00
Paul Kaplan 6222c79bee Merge pull request #5048 from ericrosenbaum/bugfix/update-fade-icons 
Update fade icons
 2019-07-31 10:50:03 -04:00
Paul Kaplan e4ebd53e69 Merge pull request #5050 from paulkaplan/fix-recording-drag-firefox 
Prevent default when dragging trim handles to prevent image drag
 2019-07-31 10:49:20 -04:00
Paul Kaplan c855152e86 Prevent default when dragging trim handles to prevent image drag 2019-07-31 10:48:06 -04:00
Eric Rosenbaum dce65e33a5 Update fade icons 2019-07-31 10:43:54 -04:00
Paul Kaplan 4757bb73e4 Do not update trimmers only if both have not changed 2019-07-31 10:27:15 -04:00
Eric Rosenbaum 7d1dfb67b7 Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4 
Sound editor update: selection-based editing
 2019-07-30 15:27:04 -04:00
Chris Garrity 1b4b50b09a Make space and enter actually work if focused 
If the delete button is the current active element (e.g. focused by tab) make hitting ‘space’ or ‘Enter’ do the actual delete.
 2019-07-26 09:37:39 -04:00
Chris Garrity cd7b5d93ee fix focus styling 
Don’t use default focus style it’s ugly.

Don’t allow the image to be dragged.
 2019-07-26 09:36:16 -04:00
Eric Rosenbaum 032cd5aa02 Use DragRecognizer in AudioTrimmer 2019-07-25 15:53:07 -04:00
Eric Rosenbaum b0dbe9e323 Flip copy to new button in RTL, and use a class for flipping buttons 2019-07-25 15:29:10 -04:00
Eric Rosenbaum afccf65157 Improve accuracy of waveform rendering 2019-07-25 15:10:13 -04:00
Eric Rosenbaum c215104522 Only deselect-outside if there’s a selection 2019-07-25 14:33:49 -04:00
Ray Schamp 68389c8e6f Merge pull request #5027 from chrisgarrity/remove-delete-slop 
Remove touch slop
 2019-07-25 11:52:02 -04:00
Chris Garrity d4201075d0 Remove touch slop 2019-07-25 11:47:21 -04:00
Chris Garrity dd0c3d7468 Check for null child before cloning menu item 2019-07-25 11:20:18 -04:00
Eric Rosenbaum d8df13a12c Prevent selection from moving when handles cross over 2019-07-24 17:02:54 -04:00
Eric Rosenbaum f28b6d8e00 Make the waveform rendering more precisely positioned 2019-07-24 17:01:56 -04:00
Eric Rosenbaum c23e4c4611 Improve effect button active state padding 2019-07-24 15:03:40 -04:00
Eric Rosenbaum bc3e69d047 Prevent dragging img in trimmer handles on firefox 2019-07-24 14:08:36 -04:00
Eric Rosenbaum aaa9c355e9 Use svgs w/o masks to prevent blurriness on safari 2019-07-24 14:02:20 -04:00
Eric Rosenbaum 6e5f378633 Prevent buffer detach issues with copy/paste on firefox 2019-07-24 12:05:27 -04:00
Eric Rosenbaum 24d2e344e5 Prevent default on keyboard shortcuts 2019-07-24 11:31:20 -04:00
Eric Rosenbaum 79a819989f Prevent img drag and select issues 2019-07-24 11:22:25 -04:00
Eric Rosenbaum d882d180a5 Use separate play and stop icons for sound editor 2019-07-24 11:07:10 -04:00
Eric Rosenbaum 6be4e5e122 Fix mirroring of effect icons for RTL 2019-07-23 18:00:38 -04:00
Eric Rosenbaum 75dbed61fa Fix bug where play after paste used old selection state 2019-07-23 17:51:46 -04:00
chrisgarrity c4122ec03f Merge pull request #4960 from chrisgarrity/customize-menubar 
Customize menubar
 2019-07-23 16:32:35 -04:00
Eric Rosenbaum 5d2287b0b5 Use DragRecognizer to fix draggging on touch 2019-07-23 16:05:29 -04:00
Eric Rosenbaum c9ec59dc8a Remove unused icon 2019-07-23 15:37:00 -04:00
Eric Rosenbaum 3ab1b8254b Fix tool button styles 2019-07-23 15:29:03 -04:00
Eric Rosenbaum bf5b05e63f Re-order effects buttons and remove echo 2019-07-23 15:00:35 -04:00
Eric Rosenbaum 0eacc4b718 Prevent undo button layout from breaking 2019-07-23 15:00:22 -04:00
Eric Rosenbaum e1100f975c Fix handle div position 2019-07-23 14:48:22 -04:00
Eric Rosenbaum da4b492e08 Show trim handles over the edge of the asset panel 2019-07-23 14:21:18 -04:00
Eric Rosenbaum 324f3a6687 styles for trim handles and play button 2019-07-23 11:08:05 -04:00
Eric Rosenbaum 40dc8487f4 Fix off-by-one error in reverse effect, add a test 2019-07-22 17:47:44 -04:00
Eric Rosenbaum bbe72e3485 Remove extra spaces 2019-07-22 16:10:31 -04:00
Eric Rosenbaum d6f2b0a48a Clean up AudioEffects constructor (needs a refactor) 2019-07-22 16:05:08 -04:00