Paul Kaplan
cf0d5487d6
Avoid double toolbox update when setting the locale
2019-01-28 09:15:19 -05:00
Paul Kaplan
d0efc9a907
Add container with overflow hidden to prevent scrollbars from playhead
2019-01-23 17:03:23 -05:00
Paul Kaplan
655a179cb8
Merge pull request #4417 from paulkaplan/throttle-costume-updates
...
Throttle costume and watermark updates
2019-01-23 16:24:01 -05:00
Paul Kaplan
d9c5ad6aa4
Use curried style for HOC configuration
2019-01-23 15:56:23 -05:00
Paul Kaplan
eccbfe71a5
Throttle updates to stage images also
2019-01-23 14:49:35 -05:00
Paul Kaplan
cc7a087e80
Throttle the watermark updates using the same HOC
2019-01-23 14:37:57 -05:00
Paul Kaplan
0bc6de1362
Throttle updates to assets on sprite selector item via HOC
...
Adds unit tests for this HOC.
2019-01-23 14:30:41 -05:00
Paul Kaplan
0910b2ece1
Remove dead code
2019-01-23 13:58:52 -05:00
Paul Kaplan
6713c7ad0f
Fix issue where dragPayload was being invalidated for sprites
...
Use PureComponent instead since it is a simple shouldComponentUpdate check now.
2019-01-23 13:58:42 -05:00
Paul Kaplan
7485aaf03d
Merge pull request #4413 from paulkaplan/improve-meter-paint-perf
...
Move the mask on the audio meter outside the SVG for repaint performance
2019-01-23 12:35:18 -05:00
Paul Kaplan
12c89a96f4
Merge pull request #4415 from paulkaplan/no-double-throttling
...
Remove the redux throttle for targets update.
2019-01-23 12:34:33 -05:00
Paul Kaplan
8e22161a7d
Merge pull request #4407 from paulkaplan/no-updates-while-recording
...
Disable target updates while sound recording
2019-01-23 12:12:33 -05:00
Paul Kaplan
c75e2acfb4
Remove the redux throttle for targets update.
...
This fixes the root cause of #2858 , which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.
The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.
This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
2019-01-23 12:01:23 -05:00
Paul Kaplan
99c8e61f4c
Move the mask on the audio meter outside the svg for repaint performance
2019-01-23 11:01:15 -05:00
Paul Kaplan
9a4ef280f8
Merge pull request #4396 from paulkaplan/improve-sound-editor-perf
...
Improve sound editor performance with longer sounds
2019-01-23 09:07:13 -05:00
Paul Kaplan
743f7d5e7c
Merge pull request #4393 from paulkaplan/fix-black-drag-transition
...
Remove transition on sprite tiles to make placeholder not flash black.
2019-01-23 08:47:43 -05:00
Paul Kaplan
22f6774e30
Merge pull request #4383 from paulkaplan/fix-transition-perf
...
Remove scale transition from green flag, stop and sound editor buttons
2019-01-23 08:45:23 -05:00
Paul Kaplan
d3511f6020
Disable target updates while sound recording
2019-01-22 14:26:16 -05:00
Eric Rosenbaum
da2f290d7f
Update WeDo 2.0 extension name
2019-01-22 11:38:20 -05:00
Paul Kaplan
6b6662f569
Improve paint/composite time for sound editor while sound is playing.
...
Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.
2019-01-22 09:15:51 -05:00
Paul Kaplan
bcb287cda5
Optimize Waveform component to reduce renders and cap max nodes in svg.
...
The waveform component was being re-rendered while the playhead changed, which is a costly operation because it has to calculate the full svg path data string.
2019-01-19 09:57:31 -05:00
Paul Kaplan
f4ad5b05d7
Remove transition on sprite tiles to make placholder not flash black.
...
Also use white as the background since it gives the same impact and will not look bad if the filter isn't applied or takes a while to be applied
2019-01-19 09:02:22 -05:00
Eric Rosenbaum
ff473e8fb0
Merge pull request #3922 from evhan55/extensions/disconnect-errors
...
Peripheral disconnect status using new runtime/vm event
2019-01-18 16:59:22 -05:00
Benjamin Wheeler
4498ba3724
Merge pull request #4385 from LLK/revert-4374-revert-4359-delete-select
...
Add BorderedMenuItem and use it for delete menu, with updated style
2019-01-18 16:57:12 -05:00
Ben Wheeler
7fb57a03d8
use error-primary color rather than error-light
2019-01-18 16:47:51 -05:00
Paul Kaplan
eb8746382c
Merge pull request #4389 from paulkaplan/fix-sound-reord
...
Fix sound reorder crash
2019-01-18 15:20:48 -05:00
Paul Kaplan
1146689f42
Fix sound reorder bug.
...
We were emitting drops when getMouseOverIndex was null, which could happen either when the drop is outside the container, or there were zero boxes to check for ordering. Treat these two cases separately, and continue to not emit drops when outside the container.
2019-01-18 15:14:06 -05:00
Paul Kaplan
5e2055fc84
Revert "Merge pull request #4354 from paulkaplan/fix-backpack-sprite"
...
This reverts commit 97f8eb63b42e017f060f
2019-01-18 15:09:12 -05:00
Ben Wheeler
3bbfe94d19
reduced size, color intensity of sprite context menu separator
2019-01-18 14:12:13 -05:00
Benjamin Wheeler
1d28f52161
Revert "Revert "Adds BorderedMenuItem and use it for delete menu""
2019-01-18 13:39:06 -05:00
Paul Kaplan
7485aabb68
Remove scale transition from green flag, stop and sound editor buttons
...
See #4382 for more info about why, and what we need to follow up on it
2019-01-18 12:58:11 -05:00
Paul Kaplan
8be41dda09
Fix backpack squishing
2019-01-17 15:31:08 -05:00
Paul Kaplan
dfc13e2e54
Fix ordering to allow close button to be clicked.
...
The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable
2019-01-17 09:14:47 -05:00
Paul Kaplan
980a6acd53
Revert "Adds BorderedMenuItem and use it for delete menu"
2019-01-17 09:03:17 -05:00
Evelyn Eastmond
c1ad2b51b6
Changes to event names to clarify them.
2019-01-16 20:48:49 -05:00
Evelyn Eastmond
d72d2c5de2
Adding a new runtime event for peripheral disconnects that are intentional.
2019-01-16 20:48:49 -05:00
Karishma Chadha
d2f834d702
Merge pull request #4362 from paulkaplan/layout-perf
...
Improve layout/paint performance in editor while running a project
2019-01-16 15:45:23 -05:00
Karishma Chadha
97f8eb63b4
Merge pull request #4354 from paulkaplan/fix-backpack-sprite
...
Fix issue where you couldn't add sprites from backpack when there are no sprites
2019-01-16 15:39:13 -05:00
Benjamin Wheeler
2e017f060f
Merge pull request #4359 from apple502j/delete-select
...
Adds BorderedMenuItem and use it for delete menu
2019-01-16 15:23:49 -05:00
Ben Wheeler
6f543ae36c
Refactored the css for sprite context menu items a bit to separate classes
2019-01-16 15:22:28 -05:00
Paul Kaplan
7b217c6fce
Make sprite selector item absolutely position images to prevent layouts
...
On some projects, the sprite image changes frequently, which can cause global layouts and paints if we arent careful. Use the same absolute positioning strategy from the sprite library animations to contain layouts to the sprite image itself
2019-01-16 11:09:39 -05:00
apple502j
97f2241635
Adds BorderedMenuItem and use it for delete menu
2019-01-16 12:26:42 +09:00
Paul Kaplan
a2cc320d1f
Clear trim handles if trim cannot be completed.
...
There was a useability issue discovered in testing where trying to trim a sound to be of zero length would fail, but just leave the trimmers active. Clear them out, since the trim is invalid
2019-01-15 15:25:26 -05:00
Paul Kaplan
16994e35f8
Allow drop event in sortableHOC even when there are no items to sort.
...
This is used because the sortable drop is also used for general dropping as well as sorting drop, so you need to be able to drop into a sortable list that does not contain any items.
Make the corresponding reorder code be more careful to check if there is a newIndex.
2019-01-15 12:42:34 -05:00
Paul Kaplan
4d136c727b
Merge pull request #4339 from paulkaplan/prevent-large-sounds
...
Prevent creating sounds that are too big in the sound editor
2019-01-15 12:25:00 -05:00
Paul Kaplan
50a9541999
Merge pull request #4338 from paulkaplan/fix-sound-recorder-issues
...
Fix sound recorder issues
2019-01-15 12:24:47 -05:00
Paul Kaplan
2e30f1d426
Limit the size of sounds coming from effects.
2019-01-14 13:10:55 -05:00
Paul Kaplan
395b3d9d8f
Prevent 0 sample sounds while trimming #715
2019-01-14 12:54:34 -05:00
Paul Kaplan
329a6b5fd6
Fix typo in alert message
2019-01-14 12:20:30 -05:00
Paul Kaplan
3f51775f07
Only stop recording if we have collected some samples.
...
On slow machines it was possible to double click record before the chunk of samples had been processed, causing zero-length audio buffers
2019-01-14 12:20:20 -05:00
Paul Kaplan