Paul Kaplan
d0efc9a907
Add container with overflow hidden to prevent scrollbars from playhead
2019-01-23 17:03:23 -05:00
Paul Kaplan
655a179cb8
Merge pull request #4417 from paulkaplan/throttle-costume-updates
...
Throttle costume and watermark updates
2019-01-23 16:24:01 -05:00
Paul Kaplan
d9c5ad6aa4
Use curried style for HOC configuration
2019-01-23 15:56:23 -05:00
Paul Kaplan
0bc6de1362
Throttle updates to assets on sprite selector item via HOC
...
Adds unit tests for this HOC.
2019-01-23 14:30:41 -05:00
Paul Kaplan
6713c7ad0f
Fix issue where dragPayload was being invalidated for sprites
...
Use PureComponent instead since it is a simple shouldComponentUpdate check now.
2019-01-23 13:58:42 -05:00
Paul Kaplan
99c8e61f4c
Move the mask on the audio meter outside the svg for repaint performance
2019-01-23 11:01:15 -05:00
Paul Kaplan
9a4ef280f8
Merge pull request #4396 from paulkaplan/improve-sound-editor-perf
...
Improve sound editor performance with longer sounds
2019-01-23 09:07:13 -05:00
Paul Kaplan
743f7d5e7c
Merge pull request #4393 from paulkaplan/fix-black-drag-transition
...
Remove transition on sprite tiles to make placeholder not flash black.
2019-01-23 08:47:43 -05:00
Paul Kaplan
22f6774e30
Merge pull request #4383 from paulkaplan/fix-transition-perf
...
Remove scale transition from green flag, stop and sound editor buttons
2019-01-23 08:45:23 -05:00
Paul Kaplan
6b6662f569
Improve paint/composite time for sound editor while sound is playing.
...
Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.
2019-01-22 09:15:51 -05:00
Paul Kaplan
bcb287cda5
Optimize Waveform component to reduce renders and cap max nodes in svg.
...
The waveform component was being re-rendered while the playhead changed, which is a costly operation because it has to calculate the full svg path data string.
2019-01-19 09:57:31 -05:00
Paul Kaplan
f4ad5b05d7
Remove transition on sprite tiles to make placholder not flash black.
...
Also use white as the background since it gives the same impact and will not look bad if the filter isn't applied or takes a while to be applied
2019-01-19 09:02:22 -05:00
Ben Wheeler
7fb57a03d8
use error-primary color rather than error-light
2019-01-18 16:47:51 -05:00
Ben Wheeler
3bbfe94d19
reduced size, color intensity of sprite context menu separator
2019-01-18 14:12:13 -05:00
Benjamin Wheeler
1d28f52161
Revert "Revert "Adds BorderedMenuItem and use it for delete menu""
2019-01-18 13:39:06 -05:00
Paul Kaplan
7485aabb68
Remove scale transition from green flag, stop and sound editor buttons
...
See #4382 for more info about why, and what we need to follow up on it
2019-01-18 12:58:11 -05:00
Paul Kaplan
8be41dda09
Fix backpack squishing
2019-01-17 15:31:08 -05:00
Paul Kaplan
dfc13e2e54
Fix ordering to allow close button to be clicked.
...
The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable
2019-01-17 09:14:47 -05:00
Paul Kaplan
980a6acd53
Revert "Adds BorderedMenuItem and use it for delete menu"
2019-01-17 09:03:17 -05:00
Karishma Chadha
d2f834d702
Merge pull request #4362 from paulkaplan/layout-perf
...
Improve layout/paint performance in editor while running a project
2019-01-16 15:45:23 -05:00
Ben Wheeler
6f543ae36c
Refactored the css for sprite context menu items a bit to separate classes
2019-01-16 15:22:28 -05:00
Paul Kaplan
7b217c6fce
Make sprite selector item absolutely position images to prevent layouts
...
On some projects, the sprite image changes frequently, which can cause global layouts and paints if we arent careful. Use the same absolute positioning strategy from the sprite library animations to contain layouts to the sprite image itself
2019-01-16 11:09:39 -05:00
apple502j
97f2241635
Adds BorderedMenuItem and use it for delete menu
2019-01-16 12:26:42 +09:00
Paul Kaplan
db946df68b
Merge pull request #4322 from paulkaplan/show-loading-fullscreen
...
Show loading screen in fullscreen mode
2019-01-11 13:32:22 -05:00
Paul Kaplan
ae8ba47441
Cover the fullscreen player mode stage with a loading screen
2019-01-11 11:02:09 -05:00
Paul Kaplan
15c9c1fbeb
Pass isRTL to the stage wrapper in both player and editor modes.
...
Discovered this while trying to pass other props to the stage wrapper, we were not passing isRTL to the stage wrapper, causing ask/answer bubble to not display the right direction.
2019-01-11 10:58:19 -05:00
chrisgarrity
07eb519b09
Make whole stage clickable for green flag overlay
...
Move the onClick handler to the overlay wrapper so that the whole stage is clickable to start the project instead of just the green flag button
2019-01-10 14:21:09 -05:00
chrisgarrity
cf5183a3ee
Revise how unsupported browsers are handled
...
Browsers other than IE will be allowed to load the GUI.
However, if there is an error, the error boundary will display an unsupported browser message recommending they update to the latest version of a supported browser.
For the purposes of this PR, ‘supported’ means you can load the gui (anything other than IE), and recommended is just the browsers that meet our minimum requirements for Chrome, Firefox, Edge and Safari.
2019-01-09 12:24:01 -05:00
Paul Kaplan
d3608ead52
Revert "Check for minimum versions of recommended browsers"
2019-01-08 16:08:06 -05:00
Paul Kaplan
4af0e92465
Merge pull request #4287 from chrisgarrity/issue/unsupported-versions
...
Check for minimum versions of recommended browsers
2019-01-08 14:02:36 -05:00
chrisgarrity
b129c1e1bb
Check for minimum versions of recommended browsers
2019-01-08 09:14:07 -05:00
Eric Rosenbaum
e3345ca1b8
Merge pull request #4023 from epicfaace/features/sound-editor-buttons
...
Fix sound editor button spacing
2019-01-07 11:58:14 -05:00
Paul Kaplan
cb401ec6d8
Make the sprite drop area from the backpack highlight and large
...
Fixes useability issue where the drop area was too small, and you couldn't see it.
2019-01-07 10:09:03 -05:00
Andrew Sliwinski
8de8c02f6b
Merge pull request #4196 from Cqoicebordel/Cqoicebordel-patch-1
...
Remove Vivaldi block
2019-01-04 09:18:32 -05:00
adroitwhiz
0b228433ba
whitespace tweak 2: electric boogaloo
2019-01-02 21:02:41 -05:00
adroitwhiz
c6a2da76c3
Fixed blurry stage
2019-01-02 20:31:07 -05:00
Andrew Sliwinski
a9280c918e
Merge pull request #4208 from apple502j/patch-9
...
Change WebGL link
2018-12-27 17:05:48 -05:00
Paul Kaplan
70eb240a7c
Use the loading screen in player mode
2018-12-27 10:34:02 -05:00
apple502j
31730cc776
Change WebGL link
2018-12-27 09:46:18 +09:00
Cqoicebordel
4a8a976813
Update gui.unsupportedBrowser.description text to be less precise
2018-12-26 16:36:19 +01:00
Cqoicebordel
d028b93308
Remove Vivaldi block text
2018-12-26 15:43:02 +01:00
chrisgarrity
543d23970c
Merge pull request #4169 from benjiwheeler/translate-validation
...
translate form validation string
2018-12-20 22:02:48 -05:00
Christopher Willis-Ford
e3c205a9d1
Update telemetry image placeholder
2018-12-20 16:23:18 -08:00
Christopher Willis-Ford
f4daec5160
Don't bundle telemetry modal event handlers
2018-12-20 13:51:26 -08:00
Christopher Willis-Ford
ee80e07ade
Add telemetry opt-in/opt-out dialog
...
The playground now displays this on startup when in Scratch Desktop
simulation mode.
2018-12-20 13:50:36 -08:00
Paul Kaplan
57e841b19b
Merge pull request #4146 from paulkaplan/list-import
...
Implement list import and export from files
2018-12-20 13:35:54 -05:00
Ben Wheeler
39e1229c4e
translate form validation string
2018-12-19 22:45:57 -05:00
Paul Kaplan
5ed340c789
Fix typo
2018-12-19 13:51:52 -05:00
Paul Kaplan
40ca680e39
Show error ID if available from Raven
2018-12-19 13:39:56 -05:00
Paul Kaplan
aa253d7de0
Implement list import and export from files
2018-12-19 10:54:37 -05:00
Paul Kaplan