chrisgarrity
164ddbe4f4
Revert "Revert "Merge pull request #4790 from LLK/e16n""
2019-06-20 17:12:59 -04:00
picklesrus
8d3a85860e
Revert "Merge pull request #4790 from LLK/e16n"
...
This reverts commit c061f2e2f06e007b1e4a
2019-06-20 11:21:56 -04:00
Chris Willis-Ford
dc49c0ebe4
Merge branch 'develop' into e16n
2019-06-18 16:06:46 -07:00
Christopher Willis-Ford
7755f76215
simplify MockBlock construction
2019-06-18 14:15:43 -07:00
Christopher Willis-Ford
6e44bfea95
fix lint errors in define-dynamic-block.test.js
2019-06-18 11:37:17 -07:00
Paul Kaplan
13e324b52d
Use title card instead of video if using scratchDesktop flag
2019-06-05 12:53:32 -04:00
Christopher Willis-Ford
a6fe8585fb
add unit tests for defineDynamicBlock
2019-06-03 13:04:15 -07:00
Paul Kaplan
eb74d6c033
Include a unit test to ensure default project assets are included
2019-05-23 11:22:36 -04:00
Ben Wheeler
516baedad9
added tests, rewrote menu-bar-hoc to accomodate tests
2019-05-01 07:02:07 -04:00
Paul Kaplan
9d185bd6c8
Merge pull request #4753 from paulkaplan/project-save-trigger
...
Allow GUI consumer to receive a function for triggering saves.
2019-04-23 08:32:36 -04:00
Paul Kaplan
a0745e4f40
Allow GUI consumer to receive a function for triggering saves.
...
Use the same implementation as onSetProjectThumbnailer which does the same thing for getting a thumbnail externally.
2019-04-19 09:19:00 -04:00
Ben Wheeler
c064eaed4e
upload in current project id, rather than creating new project id
2019-04-16 23:34:07 -04:00
Chris Willis-Ford
33f3d1d79b
Merge pull request #4645 from cwillisf/add-telemetry-hooks
...
Add telemetry hooks
2019-03-14 10:47:59 -07:00
chrisgarrity
3e33c10b04
Fix mock store for project-saver-hoc test
...
Account for the addition of locale prop expected in mapStateToProps.
Note: if/when the telemetry code gets moved into its own hoc, the prop should get removed, and the test should get updated as well.
2019-03-12 16:13:44 -07:00
Paul Kaplan
158409d4d8
Merge pull request #4568 from apple502j/slider-decimal
...
Slider range change with decimal value support
2019-03-11 11:19:49 -04:00
Paul Kaplan
127e1a9632
Add container test for slider prompt
...
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
2019-03-11 10:51:50 -04:00
picklesrus
0dd0fd8e7a
Merge pull request #4537 from picklesrus/init-locale-vm
...
Fixes #4253 by telling the vm the langauge when it is initialized. B…
2019-02-27 16:37:31 -05:00
Paul Kaplan
d301794463
Add a way for GUI consumer to retrieve snapshots of the stage
2019-02-15 14:21:37 -05:00
Paul Kaplan
208060e441
Merge pull request #4534 from paulkaplan/importing-alert
...
Show an "Importing..." alert during file import
2019-02-13 16:30:28 -05:00
Paul Kaplan
7847f9e775
Show an "Importing..." alert during file import
2019-02-13 10:21:48 -05:00
picklesrus
1aa241749b
Fix up the tests and add a couple checks.
2019-02-12 11:41:32 -05:00
Paul Kaplan
4ef98ec0fe
Add unit test to make sure isDiscrete becomes correct step size
2019-02-11 11:48:18 -05:00
Luke Schlangen
7494482c9e
remove isAdmin from mode reducer
2019-02-04 11:24:42 -06:00
Luke Schlangen
4db64ca560
add mode reducer unit tests
2019-02-03 12:12:56 -06:00
picklesrus
0eeff37d09
Fix test broken in #4422 by updating the snapshot.
2019-01-23 17:37:12 -05:00
Paul Kaplan
655a179cb8
Merge pull request #4417 from paulkaplan/throttle-costume-updates
...
Throttle costume and watermark updates
2019-01-23 16:24:01 -05:00
Paul Kaplan
d9c5ad6aa4
Use curried style for HOC configuration
2019-01-23 15:56:23 -05:00
Paul Kaplan
0bc6de1362
Throttle updates to assets on sprite selector item via HOC
...
Adds unit tests for this HOC.
2019-01-23 14:30:41 -05:00
Paul Kaplan
8e22161a7d
Merge pull request #4407 from paulkaplan/no-updates-while-recording
...
Disable target updates while sound recording
2019-01-23 12:12:33 -05:00
Paul Kaplan
d3511f6020
Disable target updates while sound recording
2019-01-22 14:26:16 -05:00
Paul Kaplan
6b6662f569
Improve paint/composite time for sound editor while sound is playing.
...
Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.
2019-01-22 09:15:51 -05:00
Paul Kaplan
cc81cc75fc
Fix snapshot tests
2019-01-17 09:15:22 -05:00
Paul Kaplan
1945a72673
Update snapshots for component unit tests
2019-01-16 12:12:29 -05:00
Karishma Chadha
41d910057b
Update unit test that was checking that .sb files don't get project titles extracted.
2018-12-26 09:22:51 -05:00
Ben Wheeler
ac730dd336
got tests passing
2018-12-18 15:50:57 -05:00
Benjamin Wheeler
765e4bd74a
Merge pull request #3937 from benjiwheeler/alert-text
...
use blue creating screen for new projects; revised alert text for copy/remix
2018-12-07 09:17:08 -05:00
Ben Wheeler
da66dd9766
fixed tests
2018-12-06 14:47:24 -05:00
Benjamin Wheeler
c7c64b1bff
Merge pull request #3965 from benjiwheeler/handle-is-remixing2
...
handle the onRemixing prop from www
2018-12-06 13:41:09 -05:00
Paul Kaplan
fe8b1543df
Merge pull request #3972 from paulkaplan/bind-green-flag
...
Bind vm project_start event to passed in onGreenFlag prop
2018-12-06 12:59:27 -05:00
Paul Kaplan
c0e105dd94
Bind vm project_start event to passed in onGreenFlag prop
2018-12-06 11:49:06 -05:00
Ben Wheeler
96fd7b0818
added tests for onRemixing
2018-12-06 08:41:02 -05:00
Paul Kaplan
43959e4205
Add "SaveStatus" component to control showing "Save Now" and save alerts
2018-12-05 10:46:22 -05:00
Paul Kaplan
af0155910b
Increase test coverage of alerts reducer
2018-12-05 10:45:39 -05:00
Paul Kaplan
09a22e061f
Add an alert that is shown when you first add a cloud variable
2018-12-04 15:12:23 -05:00
Karishma Chadha
6bdf803028
Add unit test for new hasCloudPermission prop. Update existing tests.
2018-12-03 15:00:37 -05:00
Benjamin Wheeler
03370ab5f9
Merge pull request #3820 from benjiwheeler/save-before-save-as-copy
...
save before saving as a copy
2018-11-29 15:03:28 -08:00
Benjamin Wheeler
bcca5bf1e8
Merge pull request #3856 from benjiwheeler/autosave-draft
...
autosave periodically when project is dirty
2018-11-28 19:28:09 -08:00
Ben Wheeler
5d36b584d0
make project saver tests pass; correct misnamed action
2018-11-28 19:08:58 -08:00
Ben Wheeler
c326e3f073
made tests for autosaving on a schedule
2018-11-28 16:08:39 -08:00
Karishma Chadha
2ca51904b4
Clean up merge conflict resolution.
2018-11-28 18:37:55 -05:00
chrisgarrity