Commit Graph
252 Commits
Author SHA1 Message Date
chrisgarrity 23605ead86 Merge pull request #5482 from apple502j/fullscreen-space
Ignore sound editor keyboard shortcut on fullscreen stage
2020-11-13 15:53:07 -05:00
Benjamin Wheeler 49e7ca7471 Merge pull request #4542 from towerofnix/better-shareBlocksToTarget
Position blocks added from "share the love" within the viewport
2020-08-18 16:11:07 -04:00
Ben Wheeler bd73f83172 default blocks editor zoom level; other minor corrections 2020-08-17 15:22:49 -04:00
Noam Yorav-Raphael 22cf3184c1 Make SortableHOC work properly in RTL mode 2020-07-22 19:18:35 +03:00
Benjamin Wheeler 560a057e15 Merge pull request #5444 from watilde/fix/audio-context
fix: initialize audio context only with user interaction
2020-06-10 11:40:03 -04:00
Chris Willis-Ford 952a584d74 Merge pull request #5434 from cwillisf/add-about-menu-button
Add about menu button
2020-05-20 11:15:51 -07:00
Daijiro Wachi c3b32570be fix: follow eslint rule 2020-05-19 22:45:59 +09:00
Daijiro Wachi f9183b954b test: add unit test for shared-audio-context.js 2020-05-19 22:34:42 +09:00
Benjamin Wheeler d0eb28f11c Merge pull request #5362 from benjiwheeler/project-state-tests
refactor onLoadedProject() creator to handle success==false consistently; add tests of project state action creators
2020-03-18 12:04:53 -04:00
apple502j f034dec5d0 Fix test 2020-02-28 23:00:06 +09:00
Ben Wheeler 2e11787ac5 test resulting projectId; add comments; fix params 2020-02-26 17:05:22 -05:00
Christopher Willis-Ford 2ebcd850d6 add unit tests for About button on menu bar 2020-02-10 13:49:54 -08:00
Benjamin Wheeler af4ad81811 Revert "refactor SB* file uploader into top-level HOC" 2020-02-06 11:33:03 -05:00
Ben Wheeler 48245be395 reverted project state changes in f2291d96 2020-01-30 14:18:13 -05:00
Ben Wheeler f2291d963c continuing sb file uploader refactor into hoc
draft of refactor to make custom confirm modal work for upload; need to further edit sb-file-uploader

Add support for custom confirm modal to sb-file-uploader

Show custom confirm modal when confirming project upload

got custom upload refactor of file upload working, and tested failure case

cleaned up debug code, make project file upload work

simplified logic around canceling file upload

removed old sb-file-uploader.jsx; fixed linter errors

reverted two components to use old strings, not shared

(can do that refactor another time)

removed unnecessary confirm container

removed stray comment

moved, updated sb file uploader tests, related project state tests

removed custom modal, to reduce scope of changes

sb file uploader test uses intl
2020-01-28 14:57:09 -05:00
Benjamin Wheeler 97885c7518 Merge pull request #5198 from benjiwheeler/block-cloud-on-embed
simplify props of cloud-manager-hoc
2020-01-28 14:13:40 -05:00
Ben Wheeler 3a8fe3f1b2 reorganized switch and conditionals to be clearer; clarified test names 2020-01-27 16:25:26 -05:00
Ben Wheeler a23dd3e349 shouldNotModifyCloudData into prop canModifyCloudData ; add defaultProps 2020-01-27 14:29:56 -05:00
Paul Kaplan 76f5cfe1cf Correctly return the sampleRate from the sample dropper 2020-01-09 12:12:41 -05:00
Paul Kaplan fcbf1b051b Make submitNewSamples async and use promises 2020-01-09 12:12:41 -05:00
Ben Wheeler a4e27112ab fixed typo 2020-01-06 15:11:18 -05:00
Ben Wheeler 50265fe843 added tests for project loading states 2020-01-06 15:10:51 -05:00
Ben Wheeler 22e2c17ff4 don’t pass onUpdateProjectTitle below titledHIC 2019-10-17 13:26:33 -04:00
Paul Kaplan def5cdc450 Send keyCode if the key information is gone 2019-08-21 15:28:04 -04:00
Ray Schamp 445874cb9c Revert "Make delete button accessible" 2019-08-08 10:30:58 -04:00
Paul Kaplan 90b71ce5e5 Merge pull request #5039 from paulkaplan/fix-context-menu-after-drag
Fix issue where context menu wouldn't come back after dragging
2019-08-07 15:59:28 -04:00
Paul Kaplan b07c645124 Fix saving after recording a sound 2019-08-02 09:31:53 -04:00
chrisgarrity 3feff9fea8 Merge pull request #5017 from chrisgarrity/fix-up-delete-button
Make delete button accessible
2019-08-02 08:39:27 -04:00
rschamp 3c6bfe0607 Add Jest-specific linting rules
Adding this caught a couple of important things:
- The sound integration tests have a `.only` in them
- The project-saver-hoc tests had two tests with the same description, causing possible confusion if that test broke
2019-08-01 11:31:01 -04:00
Chris Garrity 3701a4fb44 Refactor to separate container/component
Also noticed that Delete aria label was not localized.
2019-07-31 16:20:34 -04:00
Eric Rosenbaum 7d1dfb67b7 Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4
Sound editor update: selection-based editing
2019-07-30 15:27:04 -04:00
Eric Rosenbaum 2890609053 Add unit test for audio effect adjustedTrim times 2019-07-30 11:38:52 -04:00
Paul Kaplan 227d747c72 Fix gestureInProgress after dragEnd to return the correct value
Fixes #5031, which is happening because the gestureInProgress call is still returning true after a drag ends.
2019-07-29 15:52:15 -04:00
Chris Garrity cd7b5d93ee fix focus styling
Don’t use default focus style it’s ugly.

Don’t allow the image to be dragged.
2019-07-26 09:36:16 -04:00
Eric Rosenbaum 8f23093617 Update snapshot 2019-07-25 15:12:04 -04:00
Eric Rosenbaum 0b9969c412 Update snapshot 2019-07-24 17:11:36 -04:00
Eric Rosenbaum 0f17157a3d Update tests without echo effect 2019-07-23 16:14:56 -04:00
Eric Rosenbaum d9409f0f0c Cleanup test 2019-07-22 17:48:25 -04:00
Eric Rosenbaum 40dc8487f4 Fix off-by-one error in reverse effect, add a test 2019-07-22 17:47:44 -04:00
Chris Garrity 4e47cc875a Cleanup
* removed commented out cruft
* added tabIndex prop to delete button (with default=0)
* the last change also required a change to the sprite selector test snapshot
2019-07-22 12:02:14 -04:00
Chris Garrity 415ecee8ba Update tests 2019-07-22 12:02:14 -04:00
Eric Rosenbaum 2659490a70 Update snapshot 2019-07-15 12:00:27 -04:00
Eric Rosenbaum c11624ab06 Fix tests and remove unused icons 2019-07-09 17:23:20 -04:00
Eric Rosenbaum 1e147e4397 Fix tests 2019-07-09 15:32:29 -04:00
Eric Rosenbaum fdd4b61d5d Revert and fix tests
This reverts commit 42ff50300cff7558fd03cdebb757eca8caf85199.
2019-07-09 15:32:29 -04:00
Eric Rosenbaum 0d88c7755b Update tests 2019-07-09 15:32:28 -04:00
Paul Kaplan 0bbb11012d Merge pull request #4935 from LLK/drag-angle
Allow vertical scrolling of sprite tile pane on touch devices
2019-06-24 14:05:32 -04:00
chrisgarrity 164ddbe4f4 Revert "Revert "Merge pull request #4790 from LLK/e16n"" 2019-06-20 17:12:59 -04:00
picklesrus 8d3a85860e Revert "Merge pull request #4790 from LLK/e16n"
This reverts commit c061f2e2f0, reversing
changes made to 6e007b1e4a.
2019-06-20 11:21:56 -04:00
Paul Kaplan 8611c9ff1a Refactor gesture recognizer with tests 2019-06-19 11:26:42 -04:00