From b9ce26918d795ac4fcffd9fa58eae4aea7c3a644 Mon Sep 17 00:00:00 2001
From: DD <liudi08@gmail.com>
Date: Tue, 8 May 2018 18:30:52 -0400
Subject: [PATCH] Fix review comments

---
 src/import/load-costume.js | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/import/load-costume.js b/src/import/load-costume.js
index eb269a99..6499a53d 100644
--- a/src/import/load-costume.js
+++ b/src/import/load-costume.js
@@ -31,11 +31,10 @@ const loadCostumeFromAsset = function (costume, costumeAsset, runtime) {
         ];
     }
     if (costumeAsset.assetType === AssetType.ImageVector) {
-        // createSVGSkin does the right thing if rotationCenter isn't provided, so it's okay if it's
-        // undefined here
         let svgString = costumeAsset.decodeText();
+        // SVG Renderer load fixes "quirks" associated with Scratch 2 projects
+        // Currently costume.version only exists for scratch 2 costumes
         if (costume.version && costume.version === 2) {
-            // SVG Renderer load fixes "quirks" associated with Scratch 2 projects
             const svgRenderer = new SvgRenderer();
             svgRenderer.loadString(svgString);
             svgString = svgRenderer.toString();
@@ -49,7 +48,11 @@ const loadCostumeFromAsset = function (costume, costumeAsset, runtime) {
                 (new TextEncoder()).encode(svgString)
             );
             costume.md5 = `${costume.assetId}.${costume.dataFormat}`;
+        } else {
+            delete costume.version;
         }
+        // createSVGSkin does the right thing if rotationCenter isn't provided, so it's okay if it's
+        // undefined here
         costume.skinId = renderer.createSVGSkin(svgString, rotationCenter);
         costume.size = renderer.getSkinSize(costume.skinId);
         // Now we should have a rotationCenter even if we didn't before
@@ -61,6 +64,8 @@ const loadCostumeFromAsset = function (costume, costumeAsset, runtime) {
 
         return costume;
     }
+    // Other image types do not need a compatibility step
+    delete costume.version;
 
     return new Promise((resolve, reject) => {
         const imageElement = new Image();