From d2dbf860357fb02eb44d850bb8353f4aed9e05a8 Mon Sep 17 00:00:00 2001 From: GarboMuffin Date: Sat, 29 Oct 2022 22:58:15 -0500 Subject: [PATCH] Improve error messages for extension script errors Browsers won't tell us any specifics, but the console will let the user find out what happened. --- src/extension-support/extension-worker.js | 4 +++- src/extension-support/tw-unsandboxed-extension-runner.js | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/extension-support/extension-worker.js b/src/extension-support/extension-worker.js index d69566c7..e86f8a7e 100644 --- a/src/extension-support/extension-worker.js +++ b/src/extension-support/extension-worker.js @@ -14,7 +14,9 @@ const loadScripts = url => { return new Promise((resolve, reject) => { const script = document.createElement('script'); script.onload = () => resolve(); - script.onerror = () => reject(new Error(`Error when loading custom extension script: ${url}`)); + script.onerror = () => { + reject(new Error(`Error in sandboxed script: ${url}. Check the console for more information.`)); + }; script.src = url; document.body.appendChild(script); }); diff --git a/src/extension-support/tw-unsandboxed-extension-runner.js b/src/extension-support/tw-unsandboxed-extension-runner.js index 5d0e0880..2bab382f 100644 --- a/src/extension-support/tw-unsandboxed-extension-runner.js +++ b/src/extension-support/tw-unsandboxed-extension-runner.js @@ -49,7 +49,9 @@ const loadUnsandboxedExtension = (extensionURL, vm) => new Promise((resolve, rej createUnsandboxedExtensionAPI(vm).then(resolve); const script = document.createElement('script'); - script.onerror = () => reject(new Error(`Error in unsandboxed script ${extensionURL}`)); + script.onerror = () => { + reject(new Error(`Error in unsandboxed script ${extensionURL}. Check the console for more information.`)); + }; script.src = extensionURL; document.body.appendChild(script); }).then(objects => {