Clean up our scratch-storage subclass

- Remove shadowing of `asset`
 - Replace deprecated `ScratchStorage.AssetType`
 - Rename the class to something more descriptive
This commit is contained in:
GarboMuffin committed 2023-01-06 18:34:23 -06:00
1 parent 66bb1ac81b
commit d2b40bb5a3
1 file changed
+7 -7
+7 -7
View File
@@ -1,6 +1,6 @@
import ScratchStorage from 'scratch-storage';
class Storage extends ScratchStorage {
class StorageWithProgress extends ScratchStorage {
constructor () {
super();
@@ -16,22 +16,22 @@ class Storage extends ScratchStorage {
load (assetType, asset, assetFormat) {
const isAsset = (
assetType === ScratchStorage.AssetType.ImageBitmap ||
assetType === ScratchStorage.AssetType.ImageVector ||
assetType === ScratchStorage.AssetType.Sound
assetType === this.AssetType.ImageBitmap ||
assetType === this.AssetType.ImageVector ||
assetType === this.AssetType.Sound
);
if (isAsset) {
this._totalAssets++;
this._updateProgress();
return super.load(assetType, asset, assetFormat)
.then((asset) => {
.then((loadedAsset) => {
this._loadedAssets++;
this._updateProgress();
return asset;
return loadedAsset;
});
}
return super.load(assetType, asset, assetFormat);
}
}
export default Storage;
export default StorageWithProgress;