Merge pull request #3696 from paulkaplan/split-backpack-options

Split up the backpack visible and backpack host options
This commit is contained in:
Paul Kaplan authored and GitHub committed 2018-11-09 08:19:51 -05:00
commit 3c75bfc730
2 files changed
+10 -16

No files matched your search

+8 -11
View File
@@ -60,7 +60,8 @@ const GUIComponent = props => {
alertsVisible,
basePath,
backdropLibraryVisible,
backpackOptions,
backpackHost,
backpackVisible,
blocksTabVisible,
cardsVisible,
canCreateNew,
@@ -294,8 +295,8 @@ const GUIComponent = props => {
{soundsTabVisible ? <SoundTab vm={vm} /> : null}
</TabPanel>
</Tabs>
{backpackOptions.visible ? (
<Backpack host={backpackOptions.host} />
{backpackVisible ? (
<Backpack host={backpackHost} />
) : null}
</Box>
@@ -324,10 +325,8 @@ GUIComponent.propTypes = {
accountNavOpen: PropTypes.bool,
activeTabIndex: PropTypes.number,
backdropLibraryVisible: PropTypes.bool,
backpackOptions: PropTypes.shape({
host: PropTypes.string,
visible: PropTypes.bool
}),
backpackHost: PropTypes.string,
backpackVisible: PropTypes.bool,
basePath: PropTypes.string,
blocksTabVisible: PropTypes.bool,
canCreateCopy: PropTypes.bool,
@@ -371,10 +370,8 @@ GUIComponent.propTypes = {
vm: PropTypes.instanceOf(VM).isRequired
};
GUIComponent.defaultProps = {
backpackOptions: {
host: null,
visible: false
},
backpackHost: null,
backpackVisible: false,
basePath: './',
canCreateNew: false,
canRemix: false,
+2 -5
View File
@@ -28,10 +28,6 @@ export default appTarget => {
const backpackHostMatches = window.location.href.match(/[?&]backpack_host=([^&]*)&?/);
const backpackHost = backpackHostMatches ? backpackHostMatches[1] : null;
const backpackOptions = {
visible: true,
host: backpackHost
};
if (process.env.NODE_ENV === 'production' && typeof window === 'object') {
// Warn before navigating away
window.onbeforeunload = () => true;
@@ -39,8 +35,9 @@ export default appTarget => {
ReactDOM.render(
<WrappedGui
backpackVisible
showComingSoon
backpackOptions={backpackOptions}
backpackHost={backpackHost}
/>,
appTarget);
};