ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hardcode aspect-ratio: 2 for featured extension images

Browse Source
This commit is contained in:
Muffin committed 2023-08-24 12:29:38 -05:00
1 parent 3f0fef19d2
commit 898fc12ee7
6 files changed
+1 -25
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

src/components/library-item/library-item.css
+1
View File
@@ -121,6 +121,7 @@
.featured-image {
width: 100%;
aspect-ratio: 2;
}
.featured-text {
src/components/library-item/library-item.jsx
-4
View File
@@ -71,9 +71,6 @@ class LibraryItemComponent extends React.PureComponent {
) : null}
<img
className={styles.featuredImage}
style={{
aspectRatio: this.props.iconAspectRatio ? this.props.iconAspectRatio.toString() : ''
}}
loading="lazy"
draggable={false}
src={this.props.iconURL}
@@ -237,7 +234,6 @@ LibraryItemComponent.propTypes = {
featured: PropTypes.bool,
hidden: PropTypes.bool,
iconURL: PropTypes.string,
iconAspectRatio: PropTypes.number,
insetIconURL: PropTypes.string,
internetConnectionRequired: PropTypes.bool,
isPlaying: PropTypes.bool,
src/components/library/library.jsx
-1
View File
@@ -325,7 +325,6 @@ class LibraryComponent extends React.Component {
hidden={dataItem.hidden}
iconMd5={dataItem.costumes ? dataItem.costumes[0].md5ext : dataItem.md5ext}
iconRawURL={dataItem.rawURL}
iconAspectRatio={dataItem.iconAspectRatio}
icons={dataItem.costumes}
id={index}
incompatibleWithScratch={dataItem.incompatibleWithScratch}
src/containers/extension-library.jsx
-1
View File
@@ -52,7 +52,6 @@ const fetchLibrary = async () => {
extensionId: extension.id,
extensionURL: `https://extensions.turbowarp.org/${extension.slug}.js`,
iconURL: `https://extensions.turbowarp.org/${extension.image || 'images/unknown.svg'}`,
iconAspectRatio: 2,
tags: ['tw'],
credits: allCredits.map(credit => {
if (credit.link) {
src/containers/library-item.jsx
-2
View File
@@ -151,7 +151,6 @@ class LibraryItem extends React.PureComponent {
featured={this.props.featured}
hidden={this.props.hidden}
iconURL={iconURL}
iconAspectRatio={this.props.iconAspectRatio}
icons={this.props.icons}
id={this.props.id}
insetIconURL={this.props.insetIconURL}
@@ -190,7 +189,6 @@ LibraryItem.propTypes = {
hidden: PropTypes.bool,
iconMd5: PropTypes.string,
iconRawURL: PropTypes.string,
iconAspectRatio: PropTypes.number,
icons: PropTypes.arrayOf(
PropTypes.shape({
baseLayerMD5: PropTypes.string, // 2.0 library format, TODO GH-5084
src/lib/libraries/extensions/index.jsx
-17
View File
@@ -62,7 +62,6 @@ export default [
),
extensionId: 'music',
iconURL: musicIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: musicInsetIconURL,
description: (
<FormattedMessage
@@ -84,7 +83,6 @@ export default [
),
extensionId: 'pen',
iconURL: penIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: penInsetIconURL,
description: (
<FormattedMessage
@@ -106,7 +104,6 @@ export default [
),
extensionId: 'videoSensing',
iconURL: videoSensingIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: videoSensingInsetIconURL,
description: (
<FormattedMessage
@@ -129,7 +126,6 @@ export default [
extensionId: 'text2speech',
collaborator: 'Amazon Web Services',
iconURL: text2speechIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: text2speechInsetIconURL,
description: (
<FormattedMessage
@@ -153,7 +149,6 @@ export default [
extensionId: 'translate',
collaborator: 'Google',
iconURL: translateIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: translateInsetIconURL,
description: (
<FormattedMessage
@@ -171,7 +166,6 @@ export default [
extensionId: 'makeymakey',
collaborator: 'JoyLabz',
iconURL: makeymakeyIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: makeymakeyInsetIconURL,
description: (
<FormattedMessage
@@ -188,7 +182,6 @@ export default [
extensionId: 'microbit',
collaborator: 'micro:bit',
iconURL: microbitIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: microbitInsetIconURL,
description: (
<FormattedMessage
@@ -220,7 +213,6 @@ export default [
extensionId: 'ev3',
collaborator: 'LEGO',
iconURL: ev3IconURL,
iconAspectRatio: 600 / 372,
insetIconURL: ev3InsetIconURL,
description: (
<FormattedMessage
@@ -252,7 +244,6 @@ export default [
extensionId: 'boost',
collaborator: 'LEGO',
iconURL: boostIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: boostInsetIconURL,
description: (
<FormattedMessage
@@ -285,7 +276,6 @@ export default [
extensionId: 'wedo2',
collaborator: 'LEGO',
iconURL: wedo2IconURL,
iconAspectRatio: 600 / 372,
insetIconURL: wedo2InsetIconURL,
description: (
<FormattedMessage
@@ -318,7 +308,6 @@ export default [
extensionId: 'gdxfor',
collaborator: 'Vernier',
iconURL: gdxforIconURL,
iconAspectRatio: 600 / 372,
insetIconURL: gdxforInsetIconURL,
description: (
<FormattedMessage
@@ -356,7 +345,6 @@ export default [
),
extensionId: 'procedures_enable_return',
iconURL: returnIcon,
iconAspectRatio: 600 / 372,
description: (
<FormattedMessage
defaultMessage="Allow custom blocks to output values and be used as inputs."
@@ -378,7 +366,6 @@ export default [
),
extensionId: 'tw',
iconURL: twIcon,
iconAspectRatio: 600 / 372,
description: (
<FormattedMessage
defaultMessage="Weird new blocks."
@@ -400,7 +387,6 @@ export default [
),
extensionId: 'custom_extension',
iconURL: customExtensionIcon,
iconAspectRatio: 600 / 372,
description: (
<FormattedMessage
defaultMessage="Load custom extensions from URLs, files, or JavaScript source code."
@@ -425,7 +411,6 @@ export const galleryLoading = {
href: 'https://extensions.turbowarp.org/',
extensionId: 'gallery',
iconURL: galleryIcon,
iconAspectRatio: 2,
description: (
<FormattedMessage
// eslint-disable-next-line max-len
@@ -449,7 +434,6 @@ export const galleryMore = {
href: 'https://extensions.turbowarp.org/',
extensionId: 'gallery',
iconURL: galleryIcon,
iconAspectRatio: 2,
description: (
<FormattedMessage
// eslint-disable-next-line max-len
@@ -473,7 +457,6 @@ export const galleryError = {
href: 'https://extensions.turbowarp.org/',
extensionId: 'gallery',
iconURL: galleryIcon,
iconAspectRatio: 2,
description: (
<FormattedMessage
// eslint-disable-next-line max-len