Address minor PR review comments.
This commit is contained in:
1 parent
310fac3e59
commit
fe2ebd9b92
2 files changed
+3
-4
No files matched your search
@@ -384,8 +384,6 @@ class Blocks extends React.Component {
|
||||
optVarType !== this.ScratchBlocks.BROADCAST_MESSAGE_VARIABLE_TYPE &&
|
||||
p.prompt.title !== this.ScratchBlocks.Msg.RENAME_VARIABLE_MODAL_TITLE &&
|
||||
p.prompt.title !== this.ScratchBlocks.Msg.RENAME_LIST_MODAL_TITLE;
|
||||
// TODO CLOUD add flag about showing the cloud variable option, which will necessitate
|
||||
// that the flag above is true, e.g. p.prompt.showVariableOptions && canUseCloudData
|
||||
this.setState(p);
|
||||
}
|
||||
handleConnectionModalStart (extensionId) {
|
||||
|
||||
@@ -45,7 +45,8 @@ class CloudProvider {
|
||||
const messageString = event.data;
|
||||
log.info(`Received websocket message: ${messageString}`);
|
||||
const message = JSON.parse(messageString);
|
||||
this.parseMessage(message);
|
||||
const parsedData = this.parseMessage(message);
|
||||
this.vm.postIOData('cloud', parsedData);
|
||||
};
|
||||
|
||||
this.connection.onopen = () => {
|
||||
@@ -75,7 +76,7 @@ class CloudProvider {
|
||||
break;
|
||||
}
|
||||
}
|
||||
this.vm.postIOData('cloud', varData);
|
||||
return varData;
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in new issue
Block a user