Paul Kaplan
1146689f42
Fix sound reorder bug.
...
We were emitting drops when getMouseOverIndex was null, which could happen either when the drop is outside the container, or there were zero boxes to check for ordering. Treat these two cases separately, and continue to not emit drops when outside the container.
2019-01-18 15:14:06 -05:00
Paul Kaplan
5e2055fc84
Revert "Merge pull request #4354 from paulkaplan/fix-backpack-sprite"
...
This reverts commit 97f8eb63b42e017f060f
2019-01-18 15:09:12 -05:00
Karishma Chadha
97f8eb63b4
Merge pull request #4354 from paulkaplan/fix-backpack-sprite
...
Fix issue where you couldn't add sprites from backpack when there are no sprites
2019-01-16 15:39:13 -05:00
Paul Kaplan
16994e35f8
Allow drop event in sortableHOC even when there are no items to sort.
...
This is used because the sortable drop is also used for general dropping as well as sorting drop, so you need to be able to drop into a sortable list that does not contain any items.
Make the corresponding reorder code be more careful to check if there is a newIndex.
2019-01-15 12:42:34 -05:00
Paul Kaplan
4d136c727b
Merge pull request #4339 from paulkaplan/prevent-large-sounds
...
Prevent creating sounds that are too big in the sound editor
2019-01-15 12:25:00 -05:00
Paul Kaplan
50a9541999
Merge pull request #4338 from paulkaplan/fix-sound-recorder-issues
...
Fix sound recorder issues
2019-01-15 12:24:47 -05:00
Paul Kaplan
2e30f1d426
Limit the size of sounds coming from effects.
2019-01-14 13:10:55 -05:00
Paul Kaplan
f3c15c402f
Prevent auto-trim from producing invalid start and stop points
2019-01-14 12:17:52 -05:00
Karishma Chadha
214393f060
Merge pull request #4315 from kchadha/fix-backpack-mp3
...
Allow putting mp3 sounds in the backpack.
2019-01-14 12:05:51 -05:00
Ben Wheeler
95b11a7b7d
resolve function name conflict by renaming onProjectLoaded in project-fetcher-hoc
...
https://github.com/LLK/scratch-gui/pull/4312 had a function name conflict with the existing code. This change fixes that by renaming the conflicting function, and removes redundant code.
2019-01-10 17:28:40 -05:00
Karishma Chadha
40de587b0d
Allow putting mp3 sounds in the backpack.
2019-01-10 14:55:33 -05:00
chrisgarrity
cf5183a3ee
Revise how unsupported browsers are handled
...
Browsers other than IE will be allowed to load the GUI.
However, if there is an error, the error boundary will display an unsupported browser message recommending they update to the latest version of a supported browser.
For the purposes of this PR, ‘supported’ means you can load the gui (anything other than IE), and recommended is just the browsers that meet our minimum requirements for Chrome, Firefox, Edge and Safari.
2019-01-09 12:24:01 -05:00
Paul Kaplan
d3608ead52
Revert "Check for minimum versions of recommended browsers"
2019-01-08 16:08:06 -05:00
Paul Kaplan
4af0e92465
Merge pull request #4287 from chrisgarrity/issue/unsupported-versions
...
Check for minimum versions of recommended browsers
2019-01-08 14:02:36 -05:00
chrisgarrity
b129c1e1bb
Check for minimum versions of recommended browsers
2019-01-08 09:14:07 -05:00
Karishma Chadha
933bdd7c05
Save project state before storing assets instead of after.
2019-01-07 17:14:51 -05:00
Andrew Sliwinski
8de8c02f6b
Merge pull request #4196 from Cqoicebordel/Cqoicebordel-patch-1
...
Remove Vivaldi block
2019-01-04 09:18:32 -05:00
picklesrus
97b9f5cf30
Stop waiting for non scratch fonts to load.
2019-01-03 15:32:21 -05:00
adroitwhiz
e23e29b027
whitespace tweak
2019-01-02 20:54:52 -05:00
adroitwhiz
50b7d3ad53
Round off getStageDimensions()
2019-01-02 20:54:36 -05:00
picklesrus
9cd41199c5
Fix #4203 by checking whether a target exists before asking whether it has an variables
2018-12-26 16:26:34 -05:00
Cqoicebordel
8e69ea7cf1
Remove Vivaldi block
2018-12-26 15:41:22 +01:00
Paul Kaplan
3c53bac17b
Revert "Make remixing/saving faster by marking all assets as clean to start."
2018-12-21 11:22:16 -05:00
Chris Willis-Ford
744076babf
Merge pull request #4162 from cwillisf/telemetry-opt-in
...
Add telemetry opt-in/opt-out dialog
2018-12-20 18:44:13 -08:00
Andrew Sliwinski
3ba85ebd74
Merge pull request #4172 from ericrosenbaum/bugfix/another-library-update
...
More library updates
2018-12-20 17:37:59 -05:00
Eric Rosenbaum
fb6da98bfd
More library updates
2018-12-20 17:23:25 -05:00
Christopher Willis-Ford
ee80e07ade
Add telemetry opt-in/opt-out dialog
...
The playground now displays this on startup when in Scratch Desktop
simulation mode.
2018-12-20 13:50:36 -08:00
Paul Kaplan
57e841b19b
Merge pull request #4146 from paulkaplan/list-import
...
Implement list import and export from files
2018-12-20 13:35:54 -05:00
Paul Kaplan
54eea42e15
Remove most of the analytics.pageview events, keeping the search queries
2018-12-20 13:19:24 -05:00
Paul Kaplan
50a917280a
Use new sentry API provided by www, and use analytics ID from www
2018-12-20 12:53:33 -05:00
Benjamin Wheeler
19f5b196bd
Merge pull request #4160 from benjiwheeler/load-fonts-in-redux
...
refactored font loading state to be in redux
2018-12-20 10:00:37 -05:00
Paul Kaplan
fc28a7256d
Add txt import so file can be imported/exported from symmetrically
2018-12-20 08:43:07 -05:00
Paul Kaplan
54c8588279
Merge pull request #4153 from paulkaplan/enfasten-remix
...
Make remixing/saving faster by marking all assets as clean to start.
2018-12-20 08:30:26 -05:00
Paul Kaplan
ef43a17c1e
Merge pull request #4156 from paulkaplan/only-trigger-saves-from-editor
...
Ignore projectChange updates from the VM when not in editor mode
2018-12-20 08:29:56 -05:00
Paul Kaplan
8f554a74e0
Merge pull request #4158 from paulkaplan/fix-unload-alert
...
Do not remove the window beforeunload handler in componentWillUnmount.
2018-12-20 08:29:17 -05:00
Ben Wheeler
8a9996b247
refactored font loading state to be in redux
2018-12-19 19:45:38 -05:00
Paul Kaplan
c492602a9f
Do not remove the window beforeunload handler in componentWillUnmount.
...
This is because when switching from project to editor view, this component gets unmounted and then remounted, but the componentDidMount seems to happen before the componentWillUnmount. Because it is dealing with a global variable, it is unsafe to always unset the beforeunload when unmounting.
2018-12-19 16:37:32 -05:00
Paul Kaplan
c799541d8e
Ignore projectChange updates from the VM when not in editor mode
...
This prevents unnecassary changes that do not matter to the player view because they were made by the project in progress (i.e. made by running the blocks, or by cloud var updates)
2018-12-19 16:02:31 -05:00
Paul Kaplan
faadda3007
Make remixing/saving faster by marking all assets as clean to start.
...
They were not being marked as clean when loaded from the server, causing remixes that included only minimal (or no) changes to take a very long time as it waited for hundreds of network requests to resolve. Mark them as clean when loaded from the server so we know they do not need to be resaved
2018-12-19 15:11:30 -05:00
Eric Rosenbaum
8263a734ca
Add city and bedroom assets
2018-12-19 13:55:22 -05:00
Eric Rosenbaum
6355abe0a8
Merge pull request #4149 from ericrosenbaum/bugfix/library-update-fixes
...
Sprite and costume library fixes
2018-12-19 13:38:57 -05:00
Eric Rosenbaum
0f83046f7d
Zebrafixes
2018-12-19 13:28:33 -05:00
Eric Rosenbaum
ba06a64e9d
Fixilations
2018-12-19 13:20:03 -05:00
Eric Rosenbaum
2c7ffe9f3b
Fixifications
2018-12-19 13:16:54 -05:00
Eric Rosenbaum
010078d8a7
Yet more fixes
2018-12-19 13:15:33 -05:00
Eric Rosenbaum
400fc676a9
More fixes
2018-12-19 13:14:34 -05:00
Chris Willis-Ford
0544641515
Merge pull request #4113 from cwillisf/isScratchDesktop
...
Add a helper function to check if GUI is running in Scratch Desktop
2018-12-19 10:00:51 -08:00
Christopher Willis-Ford
af50ac76bf
Remove ready check from isScratchDesktop()
...
This was intended as a safety check but it causes problems with some
tests.
2018-12-19 09:50:27 -08:00
Eric Rosenbaum
829616db44
Sprite and costume library fixes
2018-12-19 12:48:37 -05:00
Paul Kaplan
aa253d7de0
Implement list import and export from files
2018-12-19 10:54:37 -05:00
Paul Kaplan