Commit Graph
1438 Commits
Author SHA1 Message Date
Chris Garrity 41cc11c32e Handle sound ending
Update UI play/stop button when the sound ends
2019-07-31 12:05:16 -04:00
Chris Garrity 6216e7dfa7 improve touch interactions
Play button is larger (easier to touch). Can both start and stop sounds.
Sound doesn’t restart on mouseEnter if the sound is already playing.
Sound stops if you move off play button

Missing: stop button does not revert to play button when the sound finishes.
2019-07-31 12:05:16 -04:00
Chris Garrity 8ff41a3986 revise styles
Checked with Carl and updated the style of the play button.
2019-07-31 12:05:16 -04:00
Chris Garrity f3d1a91533 Add play buttons to sound library tiles for touch
Add prop to library items to show a play button. If a play button is present the ‘play on hover’ only applies over the icon rather than the full tile.
2019-07-31 12:05:16 -04:00
Eric Rosenbaum dce65e33a5 Update fade icons 2019-07-31 10:43:54 -04:00
Eric Rosenbaum 7d1dfb67b7 Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4
Sound editor update: selection-based editing
2019-07-30 15:27:04 -04:00
Eric Rosenbaum b0dbe9e323 Flip copy to new button in RTL, and use a class for flipping buttons 2019-07-25 15:29:10 -04:00
Eric Rosenbaum afccf65157 Improve accuracy of waveform rendering 2019-07-25 15:10:13 -04:00
Ray Schamp 68389c8e6f Merge pull request #5027 from chrisgarrity/remove-delete-slop
Remove touch slop
2019-07-25 11:52:02 -04:00
Chris Garrity d4201075d0 Remove touch slop 2019-07-25 11:47:21 -04:00
Chris Garrity dd0c3d7468 Check for null child before cloning menu item 2019-07-25 11:20:18 -04:00
Eric Rosenbaum d8df13a12c Prevent selection from moving when handles cross over 2019-07-24 17:02:54 -04:00
Eric Rosenbaum f28b6d8e00 Make the waveform rendering more precisely positioned 2019-07-24 17:01:56 -04:00
Eric Rosenbaum c23e4c4611 Improve effect button active state padding 2019-07-24 15:03:40 -04:00
Eric Rosenbaum aaa9c355e9 Use svgs w/o masks to prevent blurriness on safari 2019-07-24 14:02:20 -04:00
Eric Rosenbaum 79a819989f Prevent img drag and select issues 2019-07-24 11:22:25 -04:00
Eric Rosenbaum d882d180a5 Use separate play and stop icons for sound editor 2019-07-24 11:07:10 -04:00
Eric Rosenbaum 6be4e5e122 Fix mirroring of effect icons for RTL 2019-07-23 18:00:38 -04:00
chrisgarrity c4122ec03f Merge pull request #4960 from chrisgarrity/customize-menubar
Customize menubar
2019-07-23 16:32:35 -04:00
Eric Rosenbaum c9ec59dc8a Remove unused icon 2019-07-23 15:37:00 -04:00
Eric Rosenbaum 3ab1b8254b Fix tool button styles 2019-07-23 15:29:03 -04:00
Eric Rosenbaum bf5b05e63f Re-order effects buttons and remove echo 2019-07-23 15:00:35 -04:00
Eric Rosenbaum 0eacc4b718 Prevent undo button layout from breaking 2019-07-23 15:00:22 -04:00
Eric Rosenbaum e1100f975c Fix handle div position 2019-07-23 14:48:22 -04:00
Eric Rosenbaum da4b492e08 Show trim handles over the edge of the asset panel 2019-07-23 14:21:18 -04:00
Eric Rosenbaum 324f3a6687 styles for trim handles and play button 2019-07-23 11:08:05 -04:00
Eric Rosenbaum 3823dd0629 Remove unused prop 2019-07-22 13:56:00 -04:00
Chris Garrity 6bf9fac393 addressing comments
* add scratchLogo as default for logo prop
* prefer `{featureAllowed && (<Component />)} over ternary operator with a null ‘else’
* renamed `handleSaveToComputer` as `getSaveToComputerHandler` to more clearly represent what it’s doing (returning a function to be the handler)
* renamed the parameter that is the function to handle clicking on the load project menu item (also updated the comments in `SBFileUploader`)
2019-07-22 12:25:43 -04:00
Chris Garrity 6d482fdd5e Allow customized logo
Show alternate logo if GUI is initialized with a different file.
2019-07-22 12:05:04 -04:00
Chris Garrity 48c50692fc Add flags for language and file menus
Show or hide the language and file menus.
2019-07-22 12:05:04 -04:00
Chris Garrity 4e47cc875a Cleanup
* removed commented out cruft
* added tabIndex prop to delete button (with default=0)
* the last change also required a change to the sprite selector test snapshot
2019-07-22 12:02:14 -04:00
Chris Garrity d1e6960cd4 Modify tile delete button for touch
Prototype of larger delete button for sprites, costumes and sounds to better support touch devices.

I split it out from `CloseButton` as it made the changes simpler, and we may end up going in a different direction (open context menu).
2019-07-22 12:02:14 -04:00
Eric Rosenbaum 5062518d16 Fix playhead CSS 2019-07-16 16:41:36 -04:00
Eric Rosenbaum df7e77c865 Localize button titles 2019-07-16 16:14:28 -04:00
Eric Rosenbaum f0a18d3fd3 Extract selection handle and playhead components from trimmer and selector 2019-07-16 16:00:43 -04:00
Eric Rosenbaum cff0b17881 Combine CSS for trimmer and selector into single file 2019-07-15 11:40:10 -04:00
Eric Rosenbaum c11624ab06 Fix tests and remove unused icons 2019-07-09 17:23:20 -04:00
Eric Rosenbaum ee44e225f5 Icon button styling 2019-07-09 15:32:29 -04:00
Eric Rosenbaum 0a489ea2ea Add copy, paste, copy to new and delete buttons 2019-07-09 15:32:29 -04:00
Eric Rosenbaum 7bbe5f0589 Add fade in, fade out and mute effects 2019-07-09 15:32:29 -04:00
Eric Rosenbaum f71a481d0e Remove icons not yet in use 2019-07-09 15:32:29 -04:00
Eric Rosenbaum b34e1c69f0 Cleanup and connect trim button to delete 2019-07-09 15:32:29 -04:00
Eric Rosenbaum 64562a8a05 Selection and delete 2019-07-09 15:32:29 -04:00
Eric Rosenbaum 7704bafb00 Add icons 2019-07-09 15:32:28 -04:00
Paul Kaplan 4e3f2160ae Merge pull request #4938 from LLK/touch-share
Allow sharing blocks/costumes/sounds on touch devices
2019-06-26 12:55:33 -04:00
Paul Kaplan 095fea939d Merge pull request #4941 from paulkaplan/proper-keys
Fix library images lagging behind filter changes
2019-06-26 12:53:44 -04:00
Paul Kaplan 18241a5cbd Merge branch 'develop' into touch-share 2019-06-26 10:35:13 -04:00
Paul Kaplan d8cd3e38c7 Merge pull request #4931 from paulkaplan/fix-wistia-crash
Prevent crash when wistia API takes a while to load
2019-06-26 10:28:32 -04:00
Paul Kaplan 0bbb11012d Merge pull request #4935 from LLK/drag-angle
Allow vertical scrolling of sprite tile pane on touch devices
2019-06-24 14:05:32 -04:00
Paul Kaplan 547640bfcc Add sprite prop to proptypes 2019-06-24 10:11:17 -04:00