Chris Garrity
91f5c4910f
refactor to create play-button for sound items
...
Play button doesn’t have a ‘touch-outside’ listener to stop sounds. That seems to be ok as other events cause the sound to stop.
Both handleClick and handleMouseDown are needed. Must use handleMouseDown for `preventDefault` to skip setting focus on the item. handleClick is needed to prevent the Click from propagating to the item and selecting it.
2019-07-31 12:05:16 -04:00
Chris Garrity
41cc11c32e
Handle sound ending
...
Update UI play/stop button when the sound ends
2019-07-31 12:05:16 -04:00
Chris Garrity
6216e7dfa7
improve touch interactions
...
Play button is larger (easier to touch). Can both start and stop sounds.
Sound doesn’t restart on mouseEnter if the sound is already playing.
Sound stops if you move off play button
Missing: stop button does not revert to play button when the sound finishes.
2019-07-31 12:05:16 -04:00
Chris Garrity
8ff41a3986
revise styles
...
Checked with Carl and updated the style of the play button.
2019-07-31 12:05:16 -04:00
Chris Garrity
f3d1a91533
Add play buttons to sound library tiles for touch
...
Add prop to library items to show a play button. If a play button is present the ‘play on hover’ only applies over the icon rather than the full tile.
2019-07-31 12:05:16 -04:00
Paul Kaplan
a72a420bd3
Merge pull request #5053 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190731151656
...
Update scratch-vm to the latest version 🚀
2019-07-31 11:40:41 -04:00
greenkeeper[bot]
6df151d244
chore(package): update lockfile package-lock.json
2019-07-31 15:30:16 +00:00
greenkeeper[bot]
14fa71d7f7
chore(package): update scratch-vm to version 0.2.0-prerelease.20190731151656
2019-07-31 15:30:12 +00:00
Paul Kaplan
d73f912944
Merge pull request #5043 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190730131442
...
Update scratch-vm to the latest version 🚀
2019-07-31 11:17:26 -04:00
Eric Rosenbaum
593d919d48
Merge pull request #5049 from ericrosenbaum/bugfix/remove-test-only
...
Remove test.only
2019-07-31 11:10:18 -04:00
Paul Kaplan
d452607c7a
Merge pull request #5045 from LLK/greenkeeper/chromedriver-76.0.0
...
Update chromedriver to the latest version 🚀
2019-07-31 11:05:23 -04:00
Paul Kaplan
5987562bcb
Merge branch 'develop' into greenkeeper/chromedriver-76.0.0
2019-07-31 11:04:59 -04:00
Paul Kaplan
3fae69e035
Merge pull request #5051 from LLK/greenkeeper/scratch-blocks-0.1.0-prerelease.1564581595
...
Greenkeeper/scratch blocks 0.1.0 prerelease.1564581595
2019-07-31 11:03:32 -04:00
Paul Kaplan
6222c79bee
Merge pull request #5048 from ericrosenbaum/bugfix/update-fade-icons
...
Update fade icons
2019-07-31 10:50:03 -04:00
Paul Kaplan
e4ebd53e69
Merge pull request #5050 from paulkaplan/fix-recording-drag-firefox
...
Prevent default when dragging trim handles to prevent image drag
2019-07-31 10:49:20 -04:00
Paul Kaplan
c855152e86
Prevent default when dragging trim handles to prevent image drag
2019-07-31 10:48:06 -04:00
Eric Rosenbaum
fb22e42b59
Remove test.only
2019-07-31 10:47:37 -04:00
Eric Rosenbaum
dce65e33a5
Update fade icons
2019-07-31 10:43:54 -04:00
Eric Rosenbaum
1259457ee4
Merge pull request #5047 from paulkaplan/fix-zero-trim-update
...
Do not update trimmers only if both have not changed
2019-07-31 10:41:03 -04:00
Paul Kaplan
4757bb73e4
Do not update trimmers only if both have not changed
2019-07-31 10:27:15 -04:00
greenkeeper[bot]
6453345577
chore(package): update lockfile package-lock.json
2019-07-31 14:13:06 +00:00
greenkeeper[bot]
a931f0e7be
chore(package): update scratch-blocks to version 0.1.0-prerelease.1564581595
...
Closes #5034
2019-07-31 14:13:02 +00:00
greenkeeper[bot]
5ec2c42e55
chore(package): update lockfile package-lock.json
2019-07-31 00:11:24 +00:00
greenkeeper[bot]
f664b37b4b
chore(package): update chromedriver to version 76.0.0
2019-07-31 00:11:20 +00:00
Eric Rosenbaum
7d1dfb67b7
Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4
...
Sound editor update: selection-based editing
2019-07-30 15:27:04 -04:00
Eric Rosenbaum
6bbff14aa4
Update chromedriver
2019-07-30 15:09:27 -04:00
Eric Rosenbaum
58499cec73
Add integration test for sound editor keyboard shortcuts
2019-07-30 14:57:25 -04:00
Eric Rosenbaum
2890609053
Add unit test for audio effect adjustedTrim times
2019-07-30 11:38:52 -04:00
greenkeeper[bot]
416284afad
chore(package): update lockfile package-lock.json
2019-07-30 13:17:38 +00:00
greenkeeper[bot]
73480840db
chore(package): update scratch-vm to version 0.2.0-prerelease.20190730131442
2019-07-30 13:17:34 +00:00
Eric Rosenbaum
6100e0f199
Add integration tests for copy/paste
2019-07-29 14:00:04 -04:00
DD Liu
5b1670f520
Merge pull request #5036 from fsih/svgRendTest
...
Roll forward scratch-svg-renderer
2019-07-29 12:22:13 -04:00
DD Liu
f62f170226
update package-lock
2019-07-29 11:54:59 -04:00
DD Liu
7e38d9dd0c
update paint
2019-07-29 11:45:29 -04:00
DD Liu
5cd13c3039
Update svg renderer
2019-07-29 11:45:05 -04:00
Eric Rosenbaum
1563f7892d
Add a test for the copy to new button
2019-07-25 16:32:53 -04:00
Eric Rosenbaum
5472f0a3e9
Enable the accidentally disabled sound integration tests
2019-07-25 16:32:27 -04:00
Eric Rosenbaum
032cd5aa02
Use DragRecognizer in AudioTrimmer
2019-07-25 15:53:07 -04:00
Eric Rosenbaum
b0dbe9e323
Flip copy to new button in RTL, and use a class for flipping buttons
2019-07-25 15:29:10 -04:00
Eric Rosenbaum
8f23093617
Update snapshot
2019-07-25 15:12:04 -04:00
Eric Rosenbaum
afccf65157
Improve accuracy of waveform rendering
2019-07-25 15:10:13 -04:00
Eric Rosenbaum
c215104522
Only deselect-outside if there’s a selection
2019-07-25 14:33:49 -04:00
Ray Schamp
68389c8e6f
Merge pull request #5027 from chrisgarrity/remove-delete-slop
...
Remove touch slop
2019-07-25 11:52:02 -04:00
Chris Garrity
d4201075d0
Remove touch slop
2019-07-25 11:47:21 -04:00
Ray Schamp
1f95ff0fb1
Merge pull request #5026 from chrisgarrity/fix-file-menu
...
Check for null child before cloning menu item
2019-07-25 11:26:35 -04:00
Chris Garrity
dd0c3d7468
Check for null child before cloning menu item
2019-07-25 11:20:18 -04:00
Eric Rosenbaum
0b9969c412
Update snapshot
2019-07-24 17:11:36 -04:00
Eric Rosenbaum
d8df13a12c
Prevent selection from moving when handles cross over
2019-07-24 17:02:54 -04:00
Eric Rosenbaum
f28b6d8e00
Make the waveform rendering more precisely positioned
2019-07-24 17:01:56 -04:00
Eric Rosenbaum
c23e4c4611
Improve effect button active state padding
2019-07-24 15:03:40 -04:00
Chris Garrity