ScCN/scratch-gui
2
0 Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
4,821 Commits 3 Branches 499 Tags
c75e2acfb491d3fe53fc7e667edd034d05267363
Commit Graph
4821 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Paul Kaplan c75e2acfb4 Remove the redux throttle for targets update. 
This fixes the root cause of #2858, which is caused because we are rendering the sound editor based on the GUI editing target data, but retrieving the sound based on the vms editing target data. The throttle of the redux action was causing those to get out of sync while a project was running.

The throttle is not needed because the vm runtime already batches those updates at 30 fps. The updates that come from top-level actions like switching sprites go out immediately.

This is also a minor performance boost, because there was a few ms being spent in setting and checking timers that were not needed.
 2019-01-23 12:01:23 -05:00
Paul Kaplan 9a4ef280f8 Merge pull request #4396 from paulkaplan/improve-sound-editor-perf 
Improve sound editor performance with longer sounds
 2019-01-23 09:07:13 -05:00
Paul Kaplan b6e1de5000 Merge pull request #4412 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190118221822 
chore(package): update scratch-vm to version 0.2.0-prerelease.2019011…
 2019-01-23 09:06:47 -05:00
Paul Kaplan 743f7d5e7c Merge pull request #4393 from paulkaplan/fix-black-drag-transition 
Remove transition on sprite tiles to make placeholder not flash black.
 2019-01-23 08:47:43 -05:00
Paul Kaplan 22f6774e30 Merge pull request #4383 from paulkaplan/fix-transition-perf 
Remove scale transition from green flag, stop and sound editor buttons
 2019-01-23 08:45:23 -05:00
Paul Kaplan 5672a36f39 Merge pull request #4411 from LLK/greenkeeper/scratch-render-0.1.0-prerelease.20190122223537 
chore(package): update scratch-render to version 0.1.0-prerelease.201…
 2019-01-23 08:44:51 -05:00
Eric Rosenbaum 85d14c35ae Merge pull request #4405 from ericrosenbaum/bugfix/lego-branding 
Update WeDo 2.0 extension name
 2019-01-22 17:38:44 -05:00
greenkeeper[bot] a3897f0971 chore(package): update scratch-render to version 0.1.0-prerelease.20190122223537 
Closes #4378
 2019-01-22 22:37:13 +00:00
Eric Rosenbaum da2f290d7f Update WeDo 2.0 extension name 2019-01-22 11:38:20 -05:00
Paul Kaplan 6b6662f569 Improve paint/composite time for sound editor while sound is playing. 
Forcing the playhead onto its own painting layer removes an expensive composite with the waveform. Animate using transforms instead of left prevents layouts of the rest of the page while playing a sound.
 2019-01-22 09:15:51 -05:00
Paul Kaplan bcb287cda5 Optimize Waveform component to reduce renders and cap max nodes in svg. 
The waveform component was being re-rendered while the playhead changed, which is a costly operation because it has to calculate the full svg path data string.
 2019-01-19 09:57:31 -05:00
Paul Kaplan f4ad5b05d7 Remove transition on sprite tiles to make placholder not flash black. 
Also use white as the background since it gives the same impact and will not look bad if the filter isn't applied or takes a while to be applied
 2019-01-19 09:02:22 -05:00
greenkeeper[bot] 0fe2884842 chore(package): update scratch-vm to version 0.2.0-prerelease.20190118221822 
Closes #4390
 2019-01-18 22:35:39 +00:00
Eric Rosenbaum ff473e8fb0 Merge pull request #3922 from evhan55/extensions/disconnect-errors 
Peripheral disconnect status using new runtime/vm event
 2019-01-18 16:59:22 -05:00
Benjamin Wheeler 4498ba3724 Merge pull request #4385 from LLK/revert-4374-revert-4359-delete-select 
Add BorderedMenuItem and use it for delete menu, with updated style
 2019-01-18 16:57:12 -05:00
Ben Wheeler 7fb57a03d8 use error-primary color rather than error-light 2019-01-18 16:47:51 -05:00
Paul Kaplan eb8746382c Merge pull request #4389 from paulkaplan/fix-sound-reord 
Fix sound reorder crash
 2019-01-18 15:20:48 -05:00
Paul Kaplan 1146689f42 Fix sound reorder bug. 
We were emitting drops when getMouseOverIndex was null, which could happen either when the drop is outside the container, or there were zero boxes to check for ordering. Treat these two cases separately, and continue to not emit drops when outside the container.
 2019-01-18 15:14:06 -05:00
Paul Kaplan 5e2055fc84 Revert "Merge pull request #4354 from paulkaplan/fix-backpack-sprite" 
This reverts commit 97f8eb63b4, reversing
changes made to 2e017f060f.
 2019-01-18 15:09:12 -05:00
Ben Wheeler 3bbfe94d19 reduced size, color intensity of sprite context menu separator 2019-01-18 14:12:13 -05:00
Benjamin Wheeler 1d28f52161 Revert "Revert "Adds BorderedMenuItem and use it for delete menu"" 2019-01-18 13:39:06 -05:00
Paul Kaplan 7485aabb68 Remove scale transition from green flag, stop and sound editor buttons 
See #4382 for more info about why, and what we need to follow up on it
 2019-01-18 12:58:11 -05:00
Paul Kaplan 4af8fd38e1 Merge pull request #4380 from paulkaplan/fix-backpack-squishes 
Fix backpack squishing
 2019-01-17 15:34:13 -05:00
Paul Kaplan 8be41dda09 Fix backpack squishing 2019-01-17 15:31:08 -05:00
chrisgarrity 97319fddaf Merge pull request #4379 from LLK/greenkeeper/scratch-l10n-3.1.20190117191816 
Update scratch-l10n to the latest version 🚀
 2019-01-17 15:12:46 -05:00
greenkeeper[bot] c97a072bde chore(package): update scratch-l10n to version 3.1.20190117191816 2019-01-17 19:20:22 +00:00
chrisgarrity 5aca970268 Merge pull request #4377 from chrisgarrity/update-blocks 
update scratch-blocks for languages.
 2019-01-17 09:36:07 -05:00
chrisgarrity 1b9d52f43c update scratch-blocks for languages. 2019-01-17 09:33:59 -05:00
Paul Kaplan 9cc8d54f46 Merge pull request #4376 from paulkaplan/fix-delete-button 
Fix delete button on sprite tiles
 2019-01-17 09:18:43 -05:00
Paul Kaplan cc81cc75fc Fix snapshot tests 2019-01-17 09:15:22 -05:00
Paul Kaplan 8485a47f9b Add an integration test for using the X button to delete a sprite 2019-01-17 09:14:47 -05:00
Paul Kaplan dfc13e2e54 Fix ordering to allow close button to be clicked. 
The previous change that made the images laid out using absolute meant that the close button was layered below the sprite image, making it now clickable
 2019-01-17 09:14:47 -05:00
Paul Kaplan f4c1887872 Merge pull request #4374 from LLK/revert-4359-delete-select 
Revert "Adds BorderedMenuItem and use it for delete menu"
 2019-01-17 09:10:16 -05:00
Paul Kaplan 980a6acd53 Revert "Adds BorderedMenuItem and use it for delete menu" 2019-01-17 09:03:17 -05:00
Evelyn Eastmond c1ad2b51b6 Changes to event names to clarify them. 2019-01-16 20:48:49 -05:00
Evelyn Eastmond d72d2c5de2 Adding a new runtime event for peripheral disconnects that are intentional. 2019-01-16 20:48:49 -05:00
Karishma Chadha 6adabe3647 Merge pull request #4369 from kchadha/update-scratch-blocks 
Update scratch-blocks
 2019-01-16 16:57:27 -05:00
Karishma Chadha 8ff397a2b3 Update scratch-blocks 2019-01-16 16:46:46 -05:00
Paul Kaplan 0b2df9dbe1 Merge pull request #4364 from LLK/greenkeeper/scratch-l10n-3.1.20190116193006 
Update scratch-l10n to the latest version 🚀
 2019-01-16 16:21:34 -05:00
Paul Kaplan db99971d6e Merge pull request #4366 from LLK/greenkeeper/scratch-render-0.1.0-prerelease.20190116202853 
Update scratch-render to the latest version 🚀
 2019-01-16 16:21:22 -05:00
Paul Kaplan 946e819929 Merge pull request #4368 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190116202234 
chore(package): update scratch-vm to version 0.2.0-prerelease.2019011…
 2019-01-16 16:21:00 -05:00
greenkeeper[bot] 4ece92a2b7 chore(package): update scratch-render to version 0.1.0-prerelease.20190116202853 2019-01-16 20:53:40 +00:00
greenkeeper[bot] e71547e7f2 chore(package): update scratch-vm to version 0.2.0-prerelease.20190116202234 
Closes #4363
 2019-01-16 20:53:30 +00:00
Karishma Chadha d2f834d702 Merge pull request #4362 from paulkaplan/layout-perf 
Improve layout/paint performance in editor while running a project
 2019-01-16 15:45:23 -05:00
Karishma Chadha 97f8eb63b4 Merge pull request #4354 from paulkaplan/fix-backpack-sprite 
Fix issue where you couldn't add sprites from backpack when there are no sprites
 2019-01-16 15:39:13 -05:00
Benjamin Wheeler 2e017f060f Merge pull request #4359 from apple502j/delete-select 
Adds BorderedMenuItem and use it for delete menu
 2019-01-16 15:23:49 -05:00
Ben Wheeler 6f543ae36c Refactored the css for sprite context menu items a bit to separate classes 2019-01-16 15:22:28 -05:00
greenkeeper[bot] deeef2ab62 chore(package): update scratch-l10n to version 3.1.20190116193006 2019-01-16 19:45:31 +00:00
Paul Kaplan 1c621b7eb7 Merge pull request #4357 from paulkaplan/fix-sound-trimming 
Clear trim handles if trim cannot be completed.
 2019-01-16 13:49:19 -05:00
Paul Kaplan 8e5e7b0d3b Merge pull request #4361 from LLK/greenkeeper/scratch-l10n-3.1.20190116142721 
Update scratch-l10n to the latest version 🚀
 2019-01-16 13:15:36 -05:00