Evelyn Eastmond
d72d2c5de2
Adding a new runtime event for peripheral disconnects that are intentional.
2019-01-16 20:48:49 -05:00
Karishma Chadha
97f8eb63b4
Merge pull request #4354 from paulkaplan/fix-backpack-sprite
...
Fix issue where you couldn't add sprites from backpack when there are no sprites
2019-01-16 15:39:13 -05:00
Paul Kaplan
a2cc320d1f
Clear trim handles if trim cannot be completed.
...
There was a useability issue discovered in testing where trying to trim a sound to be of zero length would fail, but just leave the trimmers active. Clear them out, since the trim is invalid
2019-01-15 15:25:26 -05:00
Paul Kaplan
16994e35f8
Allow drop event in sortableHOC even when there are no items to sort.
...
This is used because the sortable drop is also used for general dropping as well as sorting drop, so you need to be able to drop into a sortable list that does not contain any items.
Make the corresponding reorder code be more careful to check if there is a newIndex.
2019-01-15 12:42:34 -05:00
Paul Kaplan
4d136c727b
Merge pull request #4339 from paulkaplan/prevent-large-sounds
...
Prevent creating sounds that are too big in the sound editor
2019-01-15 12:25:00 -05:00
Paul Kaplan
50a9541999
Merge pull request #4338 from paulkaplan/fix-sound-recorder-issues
...
Fix sound recorder issues
2019-01-15 12:24:47 -05:00
Paul Kaplan
2e30f1d426
Limit the size of sounds coming from effects.
2019-01-14 13:10:55 -05:00
Paul Kaplan
395b3d9d8f
Prevent 0 sample sounds while trimming #715
2019-01-14 12:54:34 -05:00
Paul Kaplan
329a6b5fd6
Fix typo in alert message
2019-01-14 12:20:30 -05:00
Paul Kaplan
3f51775f07
Only stop recording if we have collected some samples.
...
On slow machines it was possible to double click record before the chunk of samples had been processed, causing zero-length audio buffers
2019-01-14 12:20:20 -05:00
Paul Kaplan
db946df68b
Merge pull request #4322 from paulkaplan/show-loading-fullscreen
...
Show loading screen in fullscreen mode
2019-01-11 13:32:22 -05:00
chrisgarrity
c89d452fb3
Merge pull request #4314 from chrisgarrity/clickable-flag-overlay
...
Make whole stage clickable for green flag overlay
2019-01-11 13:18:53 -05:00
Paul Kaplan
ae8ba47441
Cover the fullscreen player mode stage with a loading screen
2019-01-11 11:02:09 -05:00
Ben Wheeler
95b11a7b7d
resolve function name conflict by renaming onProjectLoaded in project-fetcher-hoc
...
https://github.com/LLK/scratch-gui/pull/4312 had a function name conflict with the existing code. This change fixes that by renaming the conflicting function, and removes redundant code.
2019-01-10 17:28:40 -05:00
chrisgarrity
07eb519b09
Make whole stage clickable for green flag overlay
...
Move the onClick handler to the overlay wrapper so that the whole stage is clickable to start the project instead of just the green flag button
2019-01-10 14:21:09 -05:00
chrisgarrity
86a51bdbf8
Merge pull request #4312 from chrisgarrity/feature/support-onprojectloaded
...
add support for onProjectLoaded
2019-01-10 13:59:39 -05:00
chrisgarrity
5330a07045
Merge pull request #4298 from chrisgarrity/issue/null-flyout
...
check for non-null flyout
2019-01-10 13:59:14 -05:00
chrisgarrity
4aef0e0cb0
add support for onProjectLoaded
...
www needs to know when a project finishes loading so that remixing can be disabled while the project is in a state that cannot be remixed.
2019-01-10 10:38:41 -05:00
chrisgarrity
cf5183a3ee
Revise how unsupported browsers are handled
...
Browsers other than IE will be allowed to load the GUI.
However, if there is an error, the error boundary will display an unsupported browser message recommending they update to the latest version of a supported browser.
For the purposes of this PR, ‘supported’ means you can load the gui (anything other than IE), and recommended is just the browsers that meet our minimum requirements for Chrome, Firefox, Edge and Safari.
2019-01-09 12:24:01 -05:00
chrisgarrity
213ef4bad7
check for non-null flyout
2019-01-08 17:58:14 -05:00
Karishma Chadha
6b2cf976f6
Fix regex for extracting the project title from a .sb file
2018-12-25 13:17:52 -05:00
Christopher Willis-Ford
ee80e07ade
Add telemetry opt-in/opt-out dialog
...
The playground now displays this on startup when in Scratch Desktop
simulation mode.
2018-12-20 13:50:36 -08:00
Karishma Chadha
ea54953caf
The file uploader file input should accept .sb files as well.
2018-12-20 15:44:01 -05:00
Paul Kaplan
57e841b19b
Merge pull request #4146 from paulkaplan/list-import
...
Implement list import and export from files
2018-12-20 13:35:54 -05:00
Paul Kaplan
6c9ae25159
Fix linting
2018-12-20 13:29:44 -05:00
Benjamin Wheeler
d76b74e8d4
Merge pull request #4144 from benjiwheeler/library-history2
...
On modal mount, push history if current history state doesn't match this modal's id
2018-12-20 13:24:44 -05:00
Paul Kaplan
6fe27f7691
Remove the error logging to GA, augment Sentry with the action prop
2018-12-20 13:19:44 -05:00
Paul Kaplan
54eea42e15
Remove most of the analytics.pageview events, keeping the search queries
2018-12-20 13:19:24 -05:00
Paul Kaplan
4df56e41ca
Include the action in the sentry report
2018-12-20 13:11:07 -05:00
Paul Kaplan
50a917280a
Use new sentry API provided by www, and use analytics ID from www
2018-12-20 12:53:33 -05:00
Paul Kaplan
80df9d6f13
Fix issue with undefineds in the CSV
2018-12-20 09:23:33 -05:00
Paul Kaplan
9b3c84737b
Merge pull request #4151 from paulkaplan/show-error-id
...
Show error ID if available from Raven and report react errors
2018-12-19 14:16:58 -05:00
Paul Kaplan
40ca680e39
Show error ID if available from Raven
2018-12-19 13:39:56 -05:00
Chris Willis-Ford
0544641515
Merge pull request #4113 from cwillisf/isScratchDesktop
...
Add a helper function to check if GUI is running in Scratch Desktop
2018-12-19 10:00:51 -08:00
Christopher Willis-Ford
75053b52d1
Don't use Object.keys()
2018-12-19 08:49:46 -08:00
Paul Kaplan
aa253d7de0
Implement list import and export from files
2018-12-19 10:54:37 -05:00
Paul Kaplan
b5b3f33f58
Merge pull request #4081 from paulkaplan/more-beefers
...
Make the requiredProjectId work with the online editor
2018-12-19 09:17:05 -05:00
Paul Kaplan
12ea49bc57
Open the editor view of the required project
2018-12-19 09:05:11 -05:00
Paul Kaplan
6647eb9174
Merge pull request #4115 from towerofnix/fix-touchevent-error
...
Fix "TouchEvent is not defined" error
2018-12-19 09:01:35 -05:00
Ben Wheeler
3f4e969810
push history on modal mount, if current history ref is not this same component id
2018-12-19 08:53:33 -05:00
Christopher Willis-Ford
b9dc953ded
Derive isScratchDesktop state from a GUI prop
2018-12-19 01:10:27 -08:00
Benjamin Wheeler
b3e97adb46
Merge pull request #4134 from benjiwheeler/save-before-upload
...
When user uploads project file, project will auto-save before loading
2018-12-18 16:23:15 -05:00
Ben Wheeler
f5e2d3ddea
set title correctly
2018-12-18 16:08:29 -05:00
Paul Kaplan
910d2b3774
Make the requiredProjectId work with the online editor
2018-12-18 15:25:17 -05:00
Ben Wheeler
566ec2aa1c
added project states for sb file upload; refactored uploader
2018-12-18 14:58:03 -05:00
DD
8fc09eb050
Call add costume from library to fix bounding box issues with some library sprites
2018-12-18 13:34:32 -05:00
Florrie
47387ffe33
Fix "TouchEvent is not defined" error
2018-12-18 00:02:04 -04:00
Karishma Chadha
f41fc58545
Merge pull request #4048 from kchadha/randomize-sprite-positions
...
Randomize Sprite Positions
2018-12-13 15:59:26 -05:00
Benjamin Wheeler
49dc93f921
Merge pull request #4033 from benjiwheeler/close-file-menu2
...
close file menu on uploading sb file; don't close file menu twice
2018-12-13 15:49:17 -05:00
Karishma Chadha
7109edaa32
Merge pull request #3984 from towerofnix/treat-defaultValue-properly
...
Treat defaultValue from Blockly prompts properly
2018-12-13 15:03:53 -05:00