Chris Willis-Ford
f773ee2dab
Merge branch 'develop' into load-library-images-through-storage
2019-03-13 16:33:38 -07:00
Christopher Willis-Ford
a7487fb26d
Fix ScratchImage current jobs count going NaN
2019-03-13 16:00:24 -07:00
Paul Kaplan
1dd3e1d26a
Merge pull request #4638 from paulkaplan/remove-analytics
...
Remove most of the GA events
2019-03-13 17:03:21 -04:00
Christopher Willis-Ford
ce5aa9fb7a
Fix ScratchImage visibility check on Windows Firefox ESR
2019-03-13 11:09:36 -07:00
Paul Kaplan
846a174f13
Merge pull request #4647 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190312212117
...
Update scratch-vm to the latest version 🚀
2019-03-13 14:08:56 -04:00
greenkeeper[bot]
c779c5fe77
chore(package): update scratch-vm to version 0.2.0-prerelease.20190312212117
2019-03-13 16:08:45 +00:00
Christopher Willis-Ford
790fc13157
Fix ScratchImage incompatibilities
2019-03-12 15:01:50 -07:00
Christopher Willis-Ford
face0d20d4
Test library icon rotation by comparing src over time
2019-03-12 15:01:50 -07:00
Christopher Willis-Ford
5c16407818
Fix imageSource for rotating library icons
2019-03-12 15:01:50 -07:00
Christopher Willis-Ford
d8201fd4ad
Merge branch 'develop' into scratch-desktop
...
Conflicts:
src/components/library-item/library-item.jsx
src/components/library/library.jsx
src/components/menu-bar/menu-bar.jsx
src/containers/library-item.jsx
src/lib/project-saver-hoc.jsx
2019-03-12 15:01:42 -07:00
Christopher Willis-Ford
2b1cd4951d
Merge remote-tracking branch 'upstream/develop' into scratch-desktop
2019-03-12 15:01:26 -07:00
Christopher Willis-Ford
849fe8fc0c
Merge branch 'develop' into scratch-desktop
2019-03-12 15:01:25 -07:00
Christopher Willis-Ford
f600e6095e
Merge remote-tracking branch 'upstream/develop' into scratch-desktop
2019-03-12 15:01:25 -07:00
Christopher Willis-Ford
d952f774dd
Merge remote-tracking branch 'upstream/develop' into scratch-desktop
2019-03-12 15:01:25 -07:00
Christopher Willis-Ford
38ee27d896
Merge remote-tracking branch 'upstream/develop' into scratch-desktop
2019-03-12 15:01:24 -07:00
Christopher Willis-Ford
73e1bc352b
Merge remote-tracking branch 'upstream/develop' into scratch-desktop
2019-03-12 15:01:24 -07:00
Christopher Willis-Ford
46ce75bf2a
Prevent crash when opening tutorials library
2019-03-12 15:01:23 -07:00
Christopher Willis-Ford
2c285fee8a
Load 6 ScratchImages at a time, prioritize visible
2019-03-12 15:01:08 -07:00
Christopher Willis-Ford
d1c3cf8bb0
Move image-from-storage code into new ScratchImage component
2019-03-12 14:38:25 -07:00
Christopher Willis-Ford
a09c7ddb53
Clarify getAssetTypeForExtension
2019-03-12 14:38:25 -07:00
Christopher Willis-Ford
fec81c93a3
Make sure icon load starts immediately
2019-03-12 14:38:25 -07:00
Christopher Willis-Ford
2b3c70dfc3
Move event processing out of LibraryItemComponent
2019-03-12 14:38:25 -07:00
Christopher Willis-Ford
db9236bef2
Fix sprite lib animation: move load into LibraryItem
...
The `LibraryItem` component has been split into a container, responsible
for handling interaction with the storage module, and a component,
responsible for presentation. The component now always takes an
`iconURI` and the logic to load an icon from storage has been moved from
`Library` into `LibraryItem`.
TODO: move animation logic from `SpriteLibrary` into `LibraryItem`. This
should simplify the code quite a bit and might also improve performance.
2019-03-12 14:38:25 -07:00
Paul Kaplan
fb383ee5f5
Merge pull request #4642 from LLK/greenkeeper/scratch-render-0.1.0-prerelease.20190312125229
...
Update scratch-render to the latest version 🚀
2019-03-12 14:35:38 -04:00
Paul Kaplan
3a33e7ea86
Update blocks.jsx
2019-03-12 14:34:45 -04:00
greenkeeper[bot]
8e51409e20
chore(package): update scratch-render to version 0.1.0-prerelease.20190312125229
2019-03-12 17:34:45 +00:00
Paul Kaplan
268ad88281
Merge pull request #4636 from LLK/greenkeeper/scratch-paint-0.2.0-prerelease.20190311150519
...
Update scratch-paint to the latest version 🚀
2019-03-11 15:55:26 -04:00
Paul Kaplan
51f9aafec1
Remove analytics library imports
2019-03-11 15:41:07 -04:00
Paul Kaplan
6ea53f63ae
Merge pull request #4637 from paulkaplan/remove-auto-select
...
Remove focus selecting in slider prompt
2019-03-11 15:16:06 -04:00
Paul Kaplan
e746b98d83
Remove some of the high-volume analytics events
...
Too much traffic, not enough value. Leaving stuff having to do with tips library/tutorial card navigation as well as hardware extension connectivity, as those help us find issues with Scratch.
2019-03-11 15:14:30 -04:00
Paul Kaplan
f72d0b5985
Remove focus selecting in slider prompt
...
It is not reliably selecting the input and is making it hard to type into.
2019-03-11 15:02:46 -04:00
greenkeeper[bot]
832dabbb51
chore(package): update scratch-paint to version 0.2.0-prerelease.20190311150519
2019-03-11 17:09:36 +00:00
Paul Kaplan
c5b5931e11
Merge pull request #4633 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190308165927
...
Update scratch-vm to the latest version 🚀
2019-03-11 11:37:36 -04:00
Paul Kaplan
f0e518df8a
Merge pull request #4635 from LLK/greenkeeper/scratch-render-0.1.0-prerelease.20190304181151
...
chore(package): update scratch-render to version 0.1.0-prerelease.201…
2019-03-11 11:37:23 -04:00
Paul Kaplan
158409d4d8
Merge pull request #4568 from apple502j/slider-decimal
...
Slider range change with decimal value support
2019-03-11 11:19:49 -04:00
Paul Kaplan
abf49b3115
Fix more prop ordering for linter
2019-03-11 11:05:16 -04:00
Paul Kaplan
4af0d9fe27
Merge pull request #4628 from LLK/touch-picker
...
Make the stage color picker work with touch.
2019-03-11 11:00:31 -04:00
Paul Kaplan
a627552c8e
Fix prop ordering for linter
2019-03-11 10:58:09 -04:00
Paul Kaplan
127e1a9632
Add container test for slider prompt
...
A few modifications were made while making this test:
- Change the "defaultMin/Max" to just be called "min/max", and pass the state through to make the inputs a controlled component. It is best to make form elements controlled since it makes it more clear how data flows.
- Force the passed in data to always be of type `number`, and transform it in the constructor to always be of type `string`, and change the onOk to transform it back to a number. With inputs, it is best to be very explicit about data types, and make it clear where you are using strings and where you are using numbers.
- Do not reset the state to `0` when the field is blank, that makes typing into it very hard (only applies after making it a controlled field)
- Use consistent booleans. Since the VM uses `isDiscrete`, change it so we do not use any opposite flags (like `decimal`) for clarity.
Writing tests for this really helped me understand the behavior. If you read through the test descriptions and see anything you did not intend, let me know.
2019-03-11 10:51:50 -04:00
Paul Kaplan
438e0f9cf7
Add default values for non-required props
2019-03-11 09:52:48 -04:00
Paul Kaplan
1e532745b7
Add a selenium test for slider range
2019-03-11 09:44:56 -04:00
greenkeeper[bot]
db811553c9
chore(package): update scratch-vm to version 0.2.0-prerelease.20190308165927
2019-03-08 17:06:09 +00:00
apple502j
ef05591d20
Remove decimal option and use type=text
2019-03-08 19:32:01 +09:00
Benjamin Wheeler
c83d85e368
Merge pull request #4589 from JinXJinX/fix_account_nav
...
fix(UI): fix cursor property when hovering account nav items
2019-03-07 15:48:50 -05:00
Paul Kaplan
d8d39b1d61
Merge pull request #4585 from JinXJinX/develop
...
fix(css): fix css value has mixed support warning
2019-03-07 13:31:39 -05:00
Paul Kaplan
f364994a46
Fix trying to get color info before pickX/Y was set
2019-03-07 11:17:48 -05:00
Paul Kaplan
9273612f99
Merge pull request #4616 from LLK/greenkeeper/scratch-svg-renderer-0.2.0-prerelease.20190304180800
...
Update scratch-svg-renderer to the latest version 🚀
2019-03-06 17:12:30 -05:00
Paul Kaplan
880bc530b7
Merge branch 'develop' into greenkeeper/scratch-svg-renderer-0.2.0-prerelease.20190304180800
2019-03-06 17:11:52 -05:00
Paul Kaplan
c109c10db6
Merge pull request #4627 from kchadha/run-pify-through-babel-loader
...
Run pify package through babel loader.
2019-03-06 17:11:07 -05:00
Paul Kaplan
5258254562
Merge pull request #4630 from LLK/greenkeeper/scratch-vm-0.2.0-prerelease.20190306171051
...
chore(package): update scratch-vm to version 0.2.0-prerelease.2019030…
2019-03-06 17:10:51 -05:00
Chris Willis-Ford