Chris Garrity
043e31a472
Refactor
...
* split play-button into container and component
* revised sound library tile:
* play button in upper right
* smaller sound icon (make the tile less loaded)
2019-07-31 12:05:16 -04:00
Chris Garrity
91f5c4910f
refactor to create play-button for sound items
...
Play button doesn’t have a ‘touch-outside’ listener to stop sounds. That seems to be ok as other events cause the sound to stop.
Both handleClick and handleMouseDown are needed. Must use handleMouseDown for `preventDefault` to skip setting focus on the item. handleClick is needed to prevent the Click from propagating to the item and selecting it.
2019-07-31 12:05:16 -04:00
Chris Garrity
41cc11c32e
Handle sound ending
...
Update UI play/stop button when the sound ends
2019-07-31 12:05:16 -04:00
Chris Garrity
6216e7dfa7
improve touch interactions
...
Play button is larger (easier to touch). Can both start and stop sounds.
Sound doesn’t restart on mouseEnter if the sound is already playing.
Sound stops if you move off play button
Missing: stop button does not revert to play button when the sound finishes.
2019-07-31 12:05:16 -04:00
Chris Garrity
f3d1a91533
Add play buttons to sound library tiles for touch
...
Add prop to library items to show a play button. If a play button is present the ‘play on hover’ only applies over the icon rather than the full tile.
2019-07-31 12:05:16 -04:00
Paul Kaplan
e4ebd53e69
Merge pull request #5050 from paulkaplan/fix-recording-drag-firefox
...
Prevent default when dragging trim handles to prevent image drag
2019-07-31 10:49:20 -04:00
Paul Kaplan
c855152e86
Prevent default when dragging trim handles to prevent image drag
2019-07-31 10:48:06 -04:00
Paul Kaplan
4757bb73e4
Do not update trimmers only if both have not changed
2019-07-31 10:27:15 -04:00
Eric Rosenbaum
7d1dfb67b7
Merge pull request #4974 from ericrosenbaum/feature/sound-editor-selection4
...
Sound editor update: selection-based editing
2019-07-30 15:27:04 -04:00
Eric Rosenbaum
032cd5aa02
Use DragRecognizer in AudioTrimmer
2019-07-25 15:53:07 -04:00
Eric Rosenbaum
c215104522
Only deselect-outside if there’s a selection
2019-07-25 14:33:49 -04:00
Eric Rosenbaum
d8df13a12c
Prevent selection from moving when handles cross over
2019-07-24 17:02:54 -04:00
Eric Rosenbaum
bc3e69d047
Prevent dragging img in trimmer handles on firefox
2019-07-24 14:08:36 -04:00
Eric Rosenbaum
6e5f378633
Prevent buffer detach issues with copy/paste on firefox
2019-07-24 12:05:27 -04:00
Eric Rosenbaum
24d2e344e5
Prevent default on keyboard shortcuts
2019-07-24 11:31:20 -04:00
Eric Rosenbaum
79a819989f
Prevent img drag and select issues
2019-07-24 11:22:25 -04:00
Eric Rosenbaum
75dbed61fa
Fix bug where play after paste used old selection state
2019-07-23 17:51:46 -04:00
Eric Rosenbaum
5d2287b0b5
Use DragRecognizer to fix draggging on touch
2019-07-23 16:05:29 -04:00
Eric Rosenbaum
3823dd0629
Remove unused prop
2019-07-22 13:56:00 -04:00
Eric Rosenbaum
056da9ab94
Use offline context to create offline nodes
2019-07-22 13:55:49 -04:00
Chris Garrity
6bf9fac393
addressing comments
...
* add scratchLogo as default for logo prop
* prefer `{featureAllowed && (<Component />)} over ternary operator with a null ‘else’
* renamed `handleSaveToComputer` as `getSaveToComputerHandler` to more clearly represent what it’s doing (returning a function to be the handler)
* renamed the parameter that is the function to handle clicking on the load project menu item (also updated the comments in `SBFileUploader`)
2019-07-22 12:25:43 -04:00
Eric Rosenbaum
c46069759a
Cleanup and lint fixes
2019-07-09 17:45:25 -04:00
Eric Rosenbaum
68a4284e8c
Add util for encodeAndAddSoundToVM
2019-07-09 17:33:33 -04:00
Eric Rosenbaum
91c81131d8
Add keyboard shortcuts
2019-07-09 15:32:30 -04:00
Eric Rosenbaum
0a489ea2ea
Add copy, paste, copy to new and delete buttons
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
c11b4a34ef
Protect effects from error due to very short sound
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
e5a517a325
Include selection state in undo/redo stack
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
7bbe5f0589
Add fade in, fade out and mute effects
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
8f949f532f
Apply effects to selection
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
b34e1c69f0
Cleanup and connect trim button to delete
2019-07-09 15:32:29 -04:00
Eric Rosenbaum
64562a8a05
Selection and delete
2019-07-09 15:32:29 -04:00
Paul Kaplan
26e4bc2ad2
Fix merge conflicts
2019-06-26 10:56:54 -04:00
Paul Kaplan
18241a5cbd
Merge branch 'develop' into touch-share
2019-06-26 10:35:13 -04:00
Paul Kaplan
0bbb11012d
Merge pull request #4935 from LLK/drag-angle
...
Allow vertical scrolling of sprite tile pane on touch devices
2019-06-24 14:05:32 -04:00
Paul Kaplan
044b958e08
Add vm init callback
2019-06-21 08:48:53 -04:00
chrisgarrity
164ddbe4f4
Revert "Revert "Merge pull request #4790 from LLK/e16n""
2019-06-20 17:12:59 -04:00
picklesrus
8d3a85860e
Revert "Merge pull request #4790 from LLK/e16n"
...
This reverts commit c061f2e2f06e007b1e4a
2019-06-20 11:21:56 -04:00
Paul Kaplan
eed4c36b7b
Emit hover on touch end to make sharing to sprites work on touch
2019-06-19 15:41:59 -04:00
Paul Kaplan
abdeb8dbdb
Fix context menu coming up when dragging
2019-06-19 11:27:00 -04:00
Paul Kaplan
8611c9ff1a
Refactor gesture recognizer with tests
2019-06-19 11:26:42 -04:00
Paul Kaplan
4b7f72c00c
Only start tile drag for certain angles
2019-06-19 09:22:05 -04:00
Chris Willis-Ford
dc49c0ebe4
Merge branch 'develop' into e16n
2019-06-18 16:06:46 -07:00
Chris Willis-Ford and Karishma Chadha
86edd829c0
Apply suggestions from code review
...
Comments slightly tweaked from kchadha's suggestions
Co-Authored-By: Karishma Chadha <kchadha@media.mit.edu >
2019-06-18 11:21:03 -07:00
Paul Kaplan
1a588880bf
Merge pull request #4901 from paulkaplan/no-videos-on-desktop
...
Use a "title card" instead of video if using Scratch Desktop
2019-06-05 16:10:16 -04:00
Paul Kaplan
e2c2392a70
Only show items in the library that would have image steps for offline
...
Because the video steps get replaced by an image step if offline, we should not show items that would result in having no content
2019-06-05 15:09:28 -04:00
Paul Kaplan
13e324b52d
Use title card instead of video if using scratchDesktop flag
2019-06-05 12:53:32 -04:00
Paul Kaplan
637b9fd225
Merge pull request #4832 from paulkaplan/do-not-select-stage
...
Make surprise and library backdrop additions NOT select the stage
2019-06-05 10:45:34 -04:00
Christopher Willis-Ford
c9d1535967
move defineDynamicBlock into its own file
2019-06-03 13:04:15 -07:00
Paul Kaplan
dc82e5f653
Merge pull request #4873 from LLK/revert-4800-delay-gui
...
Revert "Delay loading and rendering gui"
2019-05-30 11:35:57 -04:00
Paul Kaplan
d958b14b8d
Revert "render only new toolbox xmls"
2019-05-30 10:50:41 -04:00
Chris Garrity